vpp.git
7 years agoAPI refactoring : flow 60/4860/4
Pavel Kotucek [Tue, 24 Jan 2017 12:40:26 +0000 (13:40 +0100)]
API refactoring : flow

Change-Id: I99e913b954f8b02f347bfeff093856a1c5e96781
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoUpdate CSIT tests 170108 -> 170122 32/4832/2
Jan Gelety [Tue, 24 Jan 2017 11:16:40 +0000 (12:16 +0100)]
Update CSIT tests 170108 -> 170122

- update of CSIT operational branch to be used for VPP-patch test

Change-Id: I5abf9026318a7a8b4cd56c0044b7f0061ff41f58
Signed-off-by: Jan Gelety <jgelety@cisco.com>
7 years agospan: tx functionality 26/4826/2
Pavel Kotucek [Tue, 24 Jan 2017 07:26:31 +0000 (08:26 +0100)]
span: tx functionality

span-output (tx) was enabled on wrong arc_name

Change-Id: Ic21dfaec35c975de79abec66421b353637ac9394
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agomake test: elegantly handle expected API failures 75/4875/3
Klement Sekera [Wed, 25 Jan 2017 07:00:40 +0000 (08:00 +0100)]
make test: elegantly handle expected API failures

Allow writing simple code to expect API failure when needed:

with self.vapi.expect_negative_api_retval():
    do_api_call()  # expected to return negative retval in response

Change-Id: Id58d91d9ce38d20ad6ff7a43a6897e79ffbd23bf
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoAPI refactoring : classify 59/4859/3
Pavel Kotucek [Tue, 24 Jan 2017 09:58:12 +0000 (10:58 +0100)]
API refactoring : classify

Change-Id: Ib75197ef8e5057e7f0d9361a10705c3743d05333
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agotest adding and removing shared mcast dst tunnels 95/4695/6
Eyal Bari [Mon, 16 Jan 2017 10:02:46 +0000 (12:02 +0200)]
test adding and removing shared mcast dst tunnels

Adds and delete 2000 multicast vxlan tunnels sharing group address
to test mcast tunnel ref count code as part of the stability stage (before starting traffic tests)

Change-Id: Ic50cedf80471e14431feb493104eff5ea7d5d429
Signed-off-by: Eyal Bari <ebari@cisco.com>
7 years agoSNAT: static mappings for dhcp addressed interfaces (VPP-590) 28/4828/2
Matus Fabian [Tue, 24 Jan 2017 07:42:28 +0000 (23:42 -0800)]
SNAT: static mappings for dhcp addressed interfaces (VPP-590)

updated API
added test

Change-Id: I3f6017ecf09b924cb320c1b5f323cd33f7a37447
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoFix coverity defect. 55/4855/1
Vengada [Wed, 25 Jan 2017 07:38:41 +0000 (23:38 -0800)]
Fix coverity defect.
Typo resulted in passing next0[1] instead of next1[0]. Corrected it

Change-Id: I6e863c7c23c8c014ef0fef9ea1368fbaf3bc9809
Signed-off-by: Vengada <venggovi@cisco.com>
7 years agoping: fix double-free crash under VMWare hypervisor 44/4844/2
Andrew Yourtchenko [Tue, 24 Jan 2017 14:47:27 +0000 (15:47 +0100)]
ping: fix double-free crash under VMWare hypervisor

bi0 retrieval from the ping reply events vector was incorrectly done
always from the first element.

For TBD reason the sending of the ping requests under VMWare was batched,
as a result the replies arrive close enough to make the events arrive as
an array, which exposed this bug. KVM never exhibited this behavior, which
explains not seeing this issue there.

Change-Id: I485d6f983571e25baa9407c21ef604937586d8bd
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
7 years agofix OS_ID test in root Makefile 19/4819/3
Gabriel Ganne [Mon, 23 Jan 2017 11:08:58 +0000 (12:08 +0100)]
fix OS_ID test in root Makefile

fixup for 2ce7f9834ab55728520bff0dd15f8d82c10b95a0

redhat, centos -> rpm
debian, ubuntu -> deb

Change-Id: I0a07d3689b2bb5656d1bc688677680f83ac2e0bb
Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
7 years agoFix PAPI async response 40/4840/1
Wojciech Dec [Tue, 24 Jan 2017 13:18:12 +0000 (14:18 +0100)]
Fix PAPI async response

Previous changes forgot to return the decoded result

Change-Id: I4eb27802eb2672532d856d9b9671ef806374bcd0
Signed-off-by: Wojciech Dec <wdec@cisco.com>
7 years agoLISP: add RLOC and map-notify counters 83/4783/6
Filip Tehlar [Mon, 16 Jan 2017 09:30:03 +0000 (10:30 +0100)]
LISP: add RLOC and map-notify counters

Change-Id: Ie6dd9521507cd4731f1bad99c50238310238914f
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agobinary-api debug CLI works with plugins 13/4813/4
Dave Barach [Sat, 21 Jan 2017 00:50:09 +0000 (19:50 -0500)]
binary-api debug CLI works with plugins

Change-Id: I81f33f5153d5afac94b66b5a8cb91da77463af79
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoSNAT: Multiple inside interfaces (VPP-447) 51/4751/4
Matus Fabian [Wed, 18 Jan 2017 09:46:01 +0000 (01:46 -0800)]
SNAT: Multiple inside interfaces (VPP-447)

NAT only packets aimed at outside interface and in case of hairpinning

Change-Id: Ida371380fce664b9434ca5ddd2369c980ff26beb
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoAdd static mapping support for dhcp client interfaces 06/4706/3
Dave Barach [Mon, 16 Jan 2017 15:54:02 +0000 (10:54 -0500)]
Add static mapping support for dhcp client interfaces

Change-Id: I0412f95b71b9768d41c9c398a24adb1555bde20b
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix cosmetic issue in dpdk/Makefile 11/4811/2
Damjan Marion [Fri, 20 Jan 2017 22:59:28 +0000 (23:59 +0100)]
Fix cosmetic issue in dpdk/Makefile

Change-Id: I95684396e3dad53ddf7479467a36a5b68e5703cf
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix issue in rpm versioning for release builds 12/4812/1
Damjan Marion [Fri, 20 Jan 2017 23:04:30 +0000 (00:04 +0100)]
Fix issue in rpm versioning for release builds

Change-Id: I562f93017ee90b0828d36624dca694c04e332a74
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd dpdk development packaging 13/4613/19
Damjan Marion [Mon, 9 Jan 2017 19:24:50 +0000 (20:24 +0100)]
Add dpdk development packaging

Change-Id: I6aa2a6709241d99ce734c29e47487eb456907351
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix coverity warning, VPP-608 02/4802/2
Dave Barach [Fri, 20 Jan 2017 13:34:15 +0000 (08:34 -0500)]
Fix coverity warning, VPP-608

Change-Id: I1086debdf90a51205af17c35e93cd9aeff598135
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVXLAN - Add IPv6 tunnels src ref count 82/4782/4
Eyal Bari [Thu, 19 Jan 2017 15:01:09 +0000 (17:01 +0200)]
VXLAN - Add IPv6 tunnels src ref count

and refactored hash table mem keys access
hash_set_key_dup - same as hash_set_mem but duplicates the key
hash_unset_key_free - same as hash_unset_mem but frees the key

Change-Id: I18cdcf7e41c57faa615d6337acaf8d1ad058a4c1
Signed-off-by: Eyal Bari <ebari@cisco.com>
7 years agoPython API: Missing locking of results data structure. 73/4773/9
Ole Troan [Thu, 19 Jan 2017 08:44:44 +0000 (09:44 +0100)]
Python API: Missing locking of results data structure.

The wrong assumption that the GIL combined with CPython's "mostly"
thread safe assurance does not hold. The combination of a slow
event handler for notification and calling the API at the same
time let to contention on the results data structure.

Added suitable locking.

Also added an atexit() to attempt a VPP disconnect on shutdown.

Also: lots more comments, docstrings, duplicated code removed.
Some of the problem here was a disagreement between caller
and author as to how the API should be used; the comments should
help.

Change-Id: I0cb7d0026db660ec141425c5ad474f14bacea36e
Signed-off-by: Ole Troan <ot@cisco.com>
Co-Authored-By: Ian Wells <iawells@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoaf_packet: multithreading support 59/4759/3
Mohsin KAZMI [Wed, 18 Jan 2017 10:59:45 +0000 (11:59 +0100)]
af_packet: multithreading support

This patch adds multithreading support for af_packet interfaces.

Change-Id: Ief5d1117e7ffeaa59dbc2831e583d5d8e8d4fa7a
Signed-off-by: Mohsin KAZMI <sykazmi@cisco.com>
7 years agojvpp: include libjvpp_common in rpm packages 54/4754/2
Marek Gradzki [Wed, 18 Jan 2017 13:16:13 +0000 (14:16 +0100)]
jvpp: include libjvpp_common in rpm packages

Change-Id: Idef5f036c9dc679b062931f38fcc311d00fc0017
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoFix coverity warnings, VPP-608 58/4758/2
Dave Barach [Wed, 18 Jan 2017 15:23:22 +0000 (10:23 -0500)]
Fix coverity warnings, VPP-608

Change-Id: Ib0144ba3a9a09971d3946c932e8fed6d5c1ad278
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix crash on deleting activated vhost-user - VPP-603 38/4738/2
Wojciech Dec [Tue, 17 Jan 2017 20:45:11 +0000 (21:45 +0100)]
Fix crash on deleting activated vhost-user - VPP-603

Vhost-user pool getting freed prematurely

Change-Id: I952821ec85efa68923d09a643c70b6b309ea2574
Signed-off-by: Wojciech Dec <wdec@cisco.com>
7 years agomake test: fix text output when non-interactive 36/4736/2
Klement Sekera [Tue, 17 Jan 2017 12:42:48 +0000 (13:42 +0100)]
make test: fix text output when non-interactive

Output everything to stdout instead of mixing stdout and stderr.

Change-Id: I3146760e068fda7f1ffaaf36683d5153dcda4561
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoBFD: IPv6 support 37/4737/2
Klement Sekera [Mon, 2 Jan 2017 07:22:23 +0000 (08:22 +0100)]
BFD: IPv6 support

Change-Id: Iaa9538c7cca500c04cf2704e5bf87480543cfcdf
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agosample-plugin: fix build 41/4741/2
Damjan Marion [Tue, 17 Jan 2017 21:38:58 +0000 (22:38 +0100)]
sample-plugin: fix build

Change-Id: I8a2c91c4148981db31317ef9d2c5c2c28942daa9
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agodpdk: remove duplicate code in buffers.c 26/4726/4
Damjan Marion [Tue, 17 Jan 2017 13:12:42 +0000 (14:12 +0100)]
dpdk: remove duplicate code in buffers.c

Change-Id: Idc17b4a32d40012556d5d8550942db0372ebf23d
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agomake test: add checkstyle target 34/4734/2
Klement Sekera [Tue, 17 Jan 2017 09:37:05 +0000 (10:37 +0100)]
make test: add checkstyle target

Change-Id: I59d3c3bc77474c96e1d6fa51811c1b13fb9a6c5b
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agovagrant: stop rsync from wiping changes from /vpp 29/4729/2
Padraig Connolly [Tue, 17 Jan 2017 14:13:03 +0000 (14:13 +0000)]
vagrant: stop rsync from wiping changes from /vpp

*Fixes issue where any changes to the vpp directory withing vagrant
 are wiped if user reboots the vagrant vm
*Rsync will now only run if provisioning hasn't occured before

Change-Id: Ic29eb1321fba33e82df4075e7a95c96fa2e6739f
Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
7 years agofix rpm warnings for defattr directory of lua/* 21/4721/1
Gabriel Ganne [Tue, 17 Jan 2017 09:00:54 +0000 (10:00 +0100)]
fix rpm warnings for defattr directory of lua/*

eg.
Processing files: vpp-api-lua-17.04-rc0~119_g3bd11d78.x86_64
warning: %defattr doesn't define directory mode so file mode defined in %defattr is used for directory: ...

Change-Id: Ifd205b6effce6160cf6f7bdbd959e484099ff619
Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
7 years agoDHCPv6 Proxy; fix crash when DHCPv6 prxy is not configured and client packet is received 14/4714/2
Neale Ranns [Mon, 16 Jan 2017 17:09:40 +0000 (18:09 +0100)]
DHCPv6 Proxy; fix crash when DHCPv6 prxy is not configured and client packet is received

Change-Id: I0250acdee803545b8923549e2099863a95544691
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
7 years agoAdd --without-libssl configure parameter 13/4713/3
Damjan Marion [Mon, 16 Jan 2017 21:06:10 +0000 (22:06 +0100)]
Add --without-libssl configure parameter

This replaces --without-ipsec and --without-ipv6sr
and allows other parts of the code to be disabled if
libssl is not available.

Change-Id: Id97ff3685a7924d7f86622952e0405d94ceb5957
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agodpdk: add 'show dpdk version' cli 12/4712/3
Damjan Marion [Mon, 16 Jan 2017 20:36:28 +0000 (21:36 +0100)]
dpdk: add 'show dpdk version' cli

Change-Id: Iaecebae25ee4b8df8ca919992a0433e92e82e90c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix LISP coverity warning 10/4710/3
Florin Coras [Mon, 16 Jan 2017 08:57:02 +0000 (00:57 -0800)]
Fix LISP coverity warning

- uninitialized field in locator pair

Change-Id: I6832eaf5217eaad8f0fa8da1801aa31465c1f37d
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agodpdk: register rte_delay_us callback from vnet 11/4711/1
Damjan Marion [Mon, 16 Jan 2017 20:29:39 +0000 (21:29 +0100)]
dpdk: register rte_delay_us callback from vnet

Change-Id: Ibf7fc9a54d3fbee431b4814fa8abc5ba29ed9eef
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoLISP: Enhance IPx offset computing 47/4647/8
Filip Tehlar [Mon, 2 Jan 2017 09:22:56 +0000 (10:22 +0100)]
LISP: Enhance IPx offset computing

Change-Id: I0ccb0db73bcf4e2a282cabd4ebbe49599fa8ee7c
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoDefine more dependencies between libs 97/4697/3
Damjan Marion [Mon, 16 Jan 2017 13:00:03 +0000 (14:00 +0100)]
Define more dependencies between libs

Change-Id: Ia74699bad15c1c583571944458fc8a5c3ded574b
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd 'make test' to verify job 05/4705/2
Damjan Marion [Mon, 16 Jan 2017 15:19:38 +0000 (16:19 +0100)]
Add 'make test' to verify job

Change-Id: Iaab9c1a1c691a613d25ea28a22ac5db5943d8892
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoToplevel Makefile cleanup 89/4689/2
Damjan Marion [Sun, 15 Jan 2017 20:30:50 +0000 (21:30 +0100)]
Toplevel Makefile cleanup

Change-Id: I2f4cb267dbb4d6e6fc6bef908c4bb548c5f37b35
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix linker warnings for jvpp shared libs 00/4700/1
Marek Gradzki [Mon, 16 Jan 2017 13:00:56 +0000 (14:00 +0100)]
Fix linker warnings for jvpp shared libs

Change-Id: I02d01ce210d5bbe11ad2ee70f7703647f9147416
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoProvision linux stack ip4 and ip6 addresses for tap interfaces 88/4688/1
Dave Barach [Sat, 14 Jan 2017 15:30:50 +0000 (10:30 -0500)]
Provision linux stack ip4 and ip6 addresses for tap interfaces

To simplify system configuration. Converted existing code to use an
argument structure, instead of [one or two too many] discrete
parameters.

Change-Id: I3eddfa74eeed918c1b04a6285fba494651594332
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agovlib: add buffer and thread callbacks 92/4592/9
Damjan Marion [Wed, 4 Jan 2017 12:19:27 +0000 (13:19 +0100)]
vlib: add buffer and thread callbacks

Change-Id: I8e2e8f94a884ab2f9909d0c83ba00edd38cdab77
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoSNAT: IPFIX logging (VPP-445) 72/4672/2
Matus Fabian [Fri, 13 Jan 2017 12:15:54 +0000 (04:15 -0800)]
SNAT: IPFIX logging (VPP-445)

Change-Id: I8450217dd43a1cd9f510e40dfb22274ffc33a4c6
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-279: Document changes for vnet/vnet/devices 44/4644/4
Billy McFall [Wed, 11 Jan 2017 13:44:52 +0000 (08:44 -0500)]
VPP-279: Document changes for vnet/vnet/devices

Add doxygen documentation for netmap CLI commands.

Change-Id: I8d3ce12b1cfa5af30ddcd31cb476ca4652cfc2f3
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agoFix remove-rpath script, take 2 86/4686/1
Damjan Marion [Fri, 13 Jan 2017 21:11:56 +0000 (22:11 +0100)]
Fix remove-rpath script, take 2

Change-Id: If0fc5adb495b243dc9d7bfb8112ffee79ca1335e
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix remove-rpath script 85/4685/2
Damjan Marion [Fri, 13 Jan 2017 19:58:19 +0000 (20:58 +0100)]
Fix remove-rpath script

Change-Id: Ieb9ca2c5ac64dbb73de1b3dd701bb794c91aeae5
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agovppctl: new bash completion for vppctl commands 48/4648/6
Padraig Connolly [Tue, 10 Jan 2017 17:10:39 +0000 (17:10 +0000)]
vppctl: new bash completion for vppctl commands

Bash completion for vppctl
*vppctl_completion uses generated list vppctl-cmd-list to provide bash completion
*List of commands generated using grep, then moved by vpp packaging
*Once vpp package installed restart bash to use

Change-Id: I3b25e55a432c395af421231cf7c37c2e243fee61
Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
7 years agoLISP: Fix gpe API 75/4675/3
Filip Tehlar [Fri, 13 Jan 2017 13:13:09 +0000 (14:13 +0100)]
LISP: Fix gpe API

Change-Id: Iba076fc13e3f870c49fc5ca971dc7b8799188a27
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoSNAT: fixed crash - interface without IP address (VPP-599) 78/4678/2
Matus Fabian [Fri, 13 Jan 2017 13:35:34 +0000 (05:35 -0800)]
SNAT: fixed crash - interface without IP address (VPP-599)

Change-Id: I7f4d0cbde3d3c4ed6537e6351d5487546daea058
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-580: Host Interface created via Command Line Arg is misnamed 77/4577/2
Billy McFall [Thu, 5 Jan 2017 18:23:39 +0000 (13:23 -0500)]
VPP-580: Host Interface created via Command Line Arg is misnamed

Host interfaces created via the command-line arguments are missed named
(i.e. - UnknownEthernet0 instead of af_packet0). In DPDK 16.11, they
changed the driver names from eth_xxx to net_xxx. However, looks like
the AF_PACKET driver still returns "AF_PACKET PMD" as the driver name
in the rte_eth_dev_info_get(..) call. I modified the driver name look
table in vnet/devices/dpdk/dpdk.h to revert the name back.

Change-Id: I2b0a9f6b4d5245b76548027891d40f81a56b230d
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agomake test: improve test results printing 77/4677/1
Klement Sekera [Fri, 13 Jan 2017 06:25:25 +0000 (07:25 +0100)]
make test: improve test results printing

Accomodate longer test descriptions by increasing the headings
size.

Change-Id: I51c90b8d91feaa83b78972d0802d3054f8510f36
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoSNAT: add API and test for NAT pool address from interface 56/4656/2
Matus Fabian [Thu, 12 Jan 2017 12:24:35 +0000 (04:24 -0800)]
SNAT: add API and test for NAT pool address from interface

Change-Id: I2a868f736fae8d37b438c604a9284653ea415541
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agomake test: fix capture handling special-case 57/4657/2
Klement Sekera [Thu, 12 Jan 2017 06:17:01 +0000 (07:17 +0100)]
make test: fix capture handling special-case

Change-Id: I4fc5dce832f9a6162181967c5290e6d0daa4f9f0
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoAccount for pool realloc when importing FIB entries during VRF export 60/4660/1
Neale Ranns [Tue, 10 Jan 2017 17:13:41 +0000 (18:13 +0100)]
Account for pool realloc when importing FIB entries during VRF export

Change-Id: I8ec6d53fa9c0790f85802663f70a6b3630239f8d
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
7 years agomake test: fix typo 53/4653/2
Klement Sekera [Thu, 12 Jan 2017 02:39:42 +0000 (03:39 +0100)]
make test: fix typo

Change-Id: I70b4123129aab5770a45ccde4cef4452d06386b8
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoFix ARP on unnumbered interfaces (VPP-583) 54/4654/2
Neale Ranns [Mon, 9 Jan 2017 13:33:38 +0000 (14:33 +0100)]
Fix ARP on unnumbered interfaces (VPP-583)

Change-Id: Iea1e2c31c016c3bb6344f73173d082a2c548ffee
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
7 years agojvpp: include jvpp_common in vpp packages 51/4651/1
Marek Gradzki [Thu, 12 Jan 2017 08:16:23 +0000 (09:16 +0100)]
jvpp: include jvpp_common in vpp packages

Change-Id: Idcf37fc4a031c1c95362aeadf11768103e40d0fd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agomake test: improve documentation and PEP8 compliance 53/4553/7
Klement Sekera [Wed, 4 Jan 2017 11:58:53 +0000 (12:58 +0100)]
make test: improve documentation and PEP8 compliance

Change-Id: Ib4f0353aab6112fcc3c3d8f0bcbed5bc4b567b9b
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoRemove unnecessary build macro to fix slow builds. 50/4650/1
Thomas F Herbert [Wed, 11 Jan 2017 13:55:31 +0000 (08:55 -0500)]
Remove unnecessary build macro to fix slow builds.

JIRA: VPP-588

Change-Id: I05bcba3158edb4aee12ead82a30c611fddd29352
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
7 years agoBFD: fix bfd_udp_add API 46/4646/2
Klement Sekera [Wed, 11 Jan 2017 07:16:53 +0000 (08:16 +0100)]
BFD: fix bfd_udp_add API

Fix reporting of bs_index in the return message. Enhance test suite
to cover this case.

Change-Id: I37d35b850818bc1a05abe67ca919c22aeac978b6
Signed-off-by: Klement Sekera <ksekera@cisco.com>
7 years agoAcquire SNAT pool addresses from specific interfaces 49/4649/1
Dave Barach [Wed, 11 Jan 2017 18:01:14 +0000 (13:01 -0500)]
Acquire SNAT pool addresses from specific interfaces

Pick up addresses added by DHCP client, or by static configuration
Needs to have binary API support added

Change-Id: I962ef89e6e5f36cdc5457b92e165c498b08b25a9
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agojvpp: add missing dependencies on various libs 32/4632/4
Marek Gradzki [Tue, 10 Jan 2017 18:58:43 +0000 (19:58 +0100)]
jvpp: add missing dependencies on various libs

Change-Id: Ifa6845458f7249d2179a20b954fcdd49d6c68aa1
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agovxlan unit test - minor fixes 38/4638/3
Eyal Bari [Wed, 11 Jan 2017 11:39:54 +0000 (13:39 +0200)]
vxlan unit test - minor fixes

moved ip4_range and ip4n_range to util
added n_ucast_tunnels

Change-Id: I9140c4e54a0636d90a97db03da842f5183319af5
Signed-off-by: Eyal Bari <ebari@cisco.com>
7 years agoMakefile.am cleanup 37/4637/3
Damjan Marion [Wed, 11 Jan 2017 10:11:00 +0000 (11:11 +0100)]
Makefile.am cleanup

 - remove unused stuff
 - add --quiet flag to libtool
 - avoid building some tests programs when tests are not enabled

Change-Id: Ie34aeec1a598ad811256a00354f66cfddae9d0b9
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoRemove vcgn plugin 27/4627/3
Damjan Marion [Tue, 10 Jan 2017 16:07:38 +0000 (17:07 +0100)]
Remove vcgn plugin

Change-Id: I79f18ec386dedd91a8dcea2ca5726208b7b3c67c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agotest: ip4 vrf instances multi-context test (CSIT-492) 29/4429/6
Jan [Thu, 8 Dec 2016 12:10:03 +0000 (13:10 +0100)]
test: ip4 vrf instances multi-context test (CSIT-492)

- add/delete IPv4 VRF instances and verify results by parsing output
  of ip_fib_dump API command and by traffic

Change-Id: I61ed5013adca29afd00b942f65be7bf964f38d85
Signed-off-by: Jan Gelety <jgelety@cisco.com>
7 years agoVPP-575 : Inconsistency in flag values for neighbors dump 36/4636/2
Pavel Kotucek [Wed, 11 Jan 2017 09:13:54 +0000 (10:13 +0100)]
VPP-575 : Inconsistency in flag values for neighbors dump

Change-Id: Ice6861c150055d06aefff14b60dbc28e3d73769d
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agojvpp: compile static Java files and include in generated jars 29/4629/2
Marek Gradzki [Tue, 10 Jan 2017 15:43:53 +0000 (16:43 +0100)]
jvpp: compile static Java files and include in generated jars

Most Java bindings for VPP APIs provide some tests/examples.
The patch includes them in the compilation process.

Change-Id: Icef3d061c1afd727e8544a7fe5c0204453b1c1d0
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoFix LISP Coverity warning 28/4628/1
Florin Coras [Tue, 10 Jan 2017 16:57:54 +0000 (08:57 -0800)]
Fix LISP Coverity warning

Change-Id: Idf58a62a5ec47bcf52ae36d00d2844a3db72273b
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoAdded a sub-case to take into Thunderx platform 24/4624/2
Marco [Tue, 10 Jan 2017 12:53:31 +0000 (13:53 +0100)]
Added a sub-case to take into Thunderx platform

Change-Id: Ib440414693af6fe29ffaf78fc3b2992911afbcc6
Signed-off-by: Marco <marco.varlese@suse.com>
7 years agoAPI refactoring : l2, mpls, sr 37/4537/6
Pavel Kotucek [Tue, 3 Jan 2017 09:48:54 +0000 (10:48 +0100)]
API refactoring : l2, mpls, sr

Change-Id: Ic5f273dae607a1d3902489e65734c76f027dc30f
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoIPv6 NS RS tests and fixes 10/4610/3
Neale Ranns [Mon, 9 Jan 2017 09:00:45 +0000 (01:00 -0800)]
IPv6 NS RS tests and fixes

includes Fix for VPP-584 with API change to remove prefix length from LL programming

Change-Id: If860751c35e60255fb977f73bc33e8c2649e728e
Signed-off-by: Neale Ranns <nranns@cisco.com>
7 years agoVPP-585: vhost-user interface deletion leaks memory. 19/4619/2
Ole Troan [Tue, 10 Jan 2017 09:07:04 +0000 (10:07 +0100)]
VPP-585: vhost-user interface deletion leaks memory.

Change-Id: I69bbc447e1989adea40f052eac4550036b6e2e1e
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agojapi: include tests in jar files 78/4578/3
Damjan Marion [Thu, 5 Jan 2017 21:10:01 +0000 (22:10 +0100)]
japi: include tests in jar files

Change-Id: Idffaafda8fac06a45edef6f3ef13379293d0faa0
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAPI refactoring : dpdk 04/4604/4
Pavel Kotucek [Mon, 9 Jan 2017 14:11:03 +0000 (15:11 +0100)]
API refactoring : dpdk

Change-Id: If2541be803a0303401b013390e117c26fd1d9739
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoRevert "vppctl: bash completion for vppctl commands" 20/4620/2
Damjan Marion [Tue, 10 Jan 2017 09:39:21 +0000 (10:39 +0100)]
Revert "vppctl: bash completion for vppctl commands"

This patch is causing build failures

This reverts commit d995c757f05f78aa759b0a65c0a7e38088e690a9.

Change-Id: I0c8d5a4208135d77aaa3a6a470d26140f7b74733
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoSelf-service garbage collection for the API message allocator 12/4612/1
Dave Barach [Mon, 9 Jan 2017 20:54:00 +0000 (15:54 -0500)]
Self-service garbage collection for the API message allocator

Change-Id: Iadc08eede15fa5978e4010bbece0232aab8b0fee
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agovppctl: bash completion for vppctl commands 91/3991/25
Padraig Connolly [Tue, 29 Nov 2016 17:17:20 +0000 (17:17 +0000)]
vppctl: bash completion for vppctl commands

Added bash completion that will include all commands from build time
*Script takes list of commands generated by doxygen-siphon-list
*Configured doxygen-siphon makefile to generate just cli commands
*List of cli commands put in /usr/share/vpp
*Stopped siphon using doxygen bootstrap, uses main bootstrap instead
*Added rpm/deb check for installation of packages, separate from bootstrap
*NOTE: Once you have installed the vpp .deb/.rpm package you will have to
 restart bash

Change-Id: Ie503e80d5177481f6e7dbe59378f2e0d76f29152
Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
7 years agoVPP-279: af_packet via Command-line Arg should no longer be supported 86/4586/3
Billy McFall [Fri, 6 Jan 2017 22:55:25 +0000 (17:55 -0500)]
VPP-279: af_packet via Command-line Arg should no longer be supported

With the CLI command 'create host-interface', no longer need to
support af_packet interface creation via Command-line Arg. However,
this is mostly implemented by passing arguments to DPDK. Instead of
blocking functionality, put a warning in the log directing the user
to the CLI.

Change-Id: I6c6fba6096f32ef232f1da0c5d39396c6d13f54f
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agoUpdate CSIT tests 170101 -> 170108 00/4600/2
Jan Gelety [Mon, 9 Jan 2017 08:40:48 +0000 (09:40 +0100)]
Update CSIT tests 170101 -> 170108

- update of CSIT operational branch to be used for VPP-patch test

Change-Id: I58f1ea5f05a80874a16831bc7d23875d46610daa
Signed-off-by: Jan Gelety <jgelety@cisco.com>
7 years agomake test: Loopback interface CRUD test 67/4467/8
Matej Klotton [Thu, 22 Dec 2016 10:06:56 +0000 (11:06 +0100)]
make test: Loopback interface CRUD test

Change-Id: I0581da7a682bfe4dd6520ecf1b2ea6bd8c20b1b3
Signed-off-by: Matej Klotton <mklotton@cisco.com>
7 years agopapi: fix building on aarch64 91/4591/3
Damjan Marion [Sun, 8 Jan 2017 17:03:21 +0000 (18:03 +0100)]
papi: fix building on aarch64

Change-Id: I3983576bd4e0f197193a7d281763d545a55e7d64
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoIn python tests send NS packets to the solicited mcast address with correct mcast... 88/4588/2
Neale Ranns [Sat, 7 Jan 2017 18:04:09 +0000 (10:04 -0800)]
In python tests send NS packets to the solicited mcast address with correct mcast MAC, rather than to quiered addr and broadcast MAC

Change-Id: Idb2f8ad09ccb421b7974b8a944cb411cfb4be9d5
Signed-off-by: Neale Ranns <nranns@cisco.com>
7 years agoMultiple Autotools improvements 90/4590/2
Damjan Marion [Sun, 8 Jan 2017 14:34:50 +0000 (15:34 +0100)]
Multiple Autotools improvements

- Defines some dependencies between shared libraries
- updates version.h only when version changes

Updating version.h on each "make" and "make install" was causing issues with
parallel builds. "make install" was re-linking vpp binary due to "updated"
version.h and in parallel it was re-linking shared libraries as part of
installation process. That was resulting on sporadic build failures.

Change-Id: I2a27ae1aea6a7a4100822018e095a60dd48d39ca
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoplugin: add API to get pointer to symbol in different plugin 80/4580/2
Damjan Marion [Fri, 6 Jan 2017 13:33:05 +0000 (14:33 +0100)]
plugin: add API to get pointer to symbol in different plugin

Change-Id: Ic2fbbd8227d5d0c033e5d7b5f43b859a4889d2f3
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agopython clients can set the API rx message queue length 85/4585/2
Dave Barach [Fri, 6 Jan 2017 21:33:06 +0000 (16:33 -0500)]
python clients can set the API rx message queue length

Change-Id: I7af1493a823747e0f7389ad6c2093e4cec6c2ce9
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-279: doxygen documentation for host interface CLI commands 84/4584/3
Billy McFall [Fri, 6 Jan 2017 17:40:14 +0000 (12:40 -0500)]
VPP-279: doxygen documentation for host interface CLI commands

Change-Id: I2c6c16688be35e2e122c2377ded467c68a4c5a97
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agoAdded basic tests for multicast vxlan tunnels 34/4434/5
Eyal Bari [Tue, 20 Dec 2016 16:36:46 +0000 (18:36 +0200)]
Added basic tests for multicast vxlan tunnels

unicast flood test - test headend replication
multicast flood test - test flooding when a multicast vxlan tunnel is present in BD
multicast receive test - verify that multicast packet are received on their
   corresponding unicast tunnels and that unmatched packets are dropped

all tests run after adding and removing 200 mcast tunnels to test stability

Change-Id: Ia05108c39ac35096a5b633cf52480a9ba87c14df
Signed-off-by: Eyal Bari <ebari@cisco.com>
7 years agoAdded vpe.api java binding generation 73/4573/2
Jan Srnicek [Thu, 5 Jan 2017 11:42:00 +0000 (12:42 +0100)]
Added vpe.api java binding generation

added missing path for vpe.api file

Change-Id: I61f727002dd663d6a5656b0d01380e77b44c4a42
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
7 years agoFix uninitialized stack local, VPP-581 75/4575/2
Dave Barach [Thu, 5 Jan 2017 15:08:52 +0000 (10:08 -0500)]
Fix uninitialized stack local, VPP-581

Sporadically messes up the client message allocation ring, by setting
c->message_bounce[msg_id] non-zero. A day-1 bug, made blatantly
obvious by the python API language binding for no particular reason.

Manually cherry-picked from stable/1701 due to the recent tree
reorganization.

Change-Id: Ifa03c5487436cbe50a6204db48fd9ce4938e32bb
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFIB memory leaks (VPP-578) 71/4571/2
Neale Ranns [Thu, 5 Jan 2017 09:01:47 +0000 (01:01 -0800)]
FIB memory leaks (VPP-578)

1) vec_free the fe_srcs of a fib_entry_t when the fib_entry_t is itself reed
2) in the load-balance fixup if a drop path is required add this to a new vector of next-hops 'fixed_nhs'. This vector is managed by the load-balance function. The caller continues to manage its own set. The function is now const implying that the caller is safe to assume the next-hops do not change.

Change-Id: I0f29203ee16b9a270f40edf237488fa99ba65320
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
7 years agoLISP: make data plane programming thread safe 51/4551/3
Filip Tehlar [Wed, 4 Jan 2017 09:42:25 +0000 (10:42 +0100)]
LISP: make data plane programming thread safe

Change-Id: I4b949e606fa3969d4c03dc6e753a2546be6329cf
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoMerging all ioam plugin libraries to single library 22/4522/2
AkshayaNadahalli [Fri, 23 Dec 2016 12:16:08 +0000 (17:46 +0530)]
Merging all ioam plugin libraries to single library

Double commit from 1702 branch to master.

Change-Id: I33a646ba45848c7400df4271e4933e28e62c9ad7
Signed-off-by: AkshayaNadahalli <anadahal@cisco.com>
(cherry picked from commit e4e9fbbb7c8fa4385ae31072d60ad8621fe798a4)
Signed-off-by: AkshayaNadahalli <anadahal@cisco.com>
7 years agoFix library dependency issue 61/4561/3
Damjan Marion [Wed, 4 Jan 2017 15:07:54 +0000 (16:07 +0100)]
Fix library dependency issue

Change-Id: I2b08194f4554b2c0f1e595184ef0a36bd494ad17
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agorename vpp python's api debian scripts 60/4560/1
Gabriel Ganne [Wed, 4 Jan 2017 13:42:21 +0000 (14:42 +0100)]
rename vpp python's api debian scripts

python's api has been renamed from *vpp-python-api* -> *vpp-api-python*
deb scripts need to follow the package name in order to be called

Change-Id: I0c9ec45cc3d478c3b90aa75bcd2b8a9f7809cbc9
Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
7 years agovlib: merge libvlib_unix.so into libvlib.so 41/4541/2
Damjan Marion [Tue, 3 Jan 2017 19:11:35 +0000 (20:11 +0100)]
vlib: merge libvlib_unix.so into libvlib.so

Change-Id: Iedbee427d838794c4b26db5bd07b8d27aad9fcd8
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agofix version.h generation for out-of-tree builds 40/4540/2
Damjan Marion [Tue, 3 Jan 2017 18:56:43 +0000 (19:56 +0100)]
fix version.h generation for out-of-tree builds

Change-Id: Ic882f5aec74858a36533ed8cd61a7726947dceef
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agovxlan fix mcast tunnel delete 05/4505/3
Eyal Bari [Mon, 2 Jan 2017 12:29:21 +0000 (14:29 +0200)]
vxlan fix mcast tunnel delete

Change-Id: I15f7ff1e957718e808bfad811895deaacb85d2a3
Signed-off-by: Eyal Bari <ebari@cisco.com>