tap: crash in multi-thread environment 66/19766/2
authorSteven Luong <sluong@cisco.com>
Thu, 23 May 2019 00:57:25 +0000 (17:57 -0700)
committerSteven Luong <sluong@cisco.com>
Thu, 23 May 2019 16:49:32 +0000 (09:49 -0700)
commitc2c89782d34df0dc7197b18b042b4c2464a101ef
tree9de6febd9ae7f6dbaf66c2998a3ded119c696e31
parent55203e745f5e3f1f6c4dbe99d6eab8dee4d13ea6
tap: crash in multi-thread environment

In tap tx routine, virtio_interface_tx_inline, there used to be an
interface spinlock to ensure packets are processed in an orderly fashion
  clib_spinlock_lock_if_init (&vif->lockp);

When virtio code was introduced in 19.04, that line is changed to
  clib_spinlock_lock_if_init (&vring->lockp);
to accommodate multi-queues.

Unfortunately, althrough the spinlock exists in the vring, it was never
initialized for tap, only for virtio. As a result, many nasty things can
happen when running tap interface in multi-thread environment. Crash is
inevitable.

The fix is to initialize vring->lockp for tap and remove vif->lockp as it
is not used anymore.

Change-Id: Ibc8f5c8192af550e3940597c06992dfdaccb4c49
Signed-off-by: Steven Luong <sluong@cisco.com>
src/vnet/devices/tap/tap.c
src/vnet/devices/virtio/virtio.c
src/vnet/devices/virtio/virtio.h