From 07dce1e11de9872b5c9695e8cbbf89a2bcb3f63d Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Tue, 6 Mar 2018 11:42:36 +0100 Subject: [PATCH] vppapigen: require service definition for singleton messages Change-Id: Ie7b1c5e50588f65657c3c0900e5914ea82ebb50f Signed-off-by: Marek Gradzki --- src/tools/vppapigen/vppapigen.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/tools/vppapigen/vppapigen.py b/src/tools/vppapigen/vppapigen.py index 57e5e3a411e..e6237a753f9 100755 --- a/src/tools/vppapigen/vppapigen.py +++ b/src/tools/vppapigen/vppapigen.py @@ -601,10 +601,6 @@ class VPPAPI(object): continue if msgs[d].singular is True: continue - #if d.endswith('_counters'): - # continue - #if d.endswith('_event'): - # continue if d.endswith('_reply'): if d[:-6] in svcs: continue @@ -634,9 +630,8 @@ class VPPAPI(object): if d+'_reply' in msgs: s['services'].append(Service(d, d+'_reply')) else: - self.logger.warning('{} missing reply message ({})' - .format(d, d+'_reply')) - s['services'].append(Service(d, None)) + raise ValueError('{} missing reply message ({}) or service definition' + .format(d, d+'_reply')) return s -- 2.16.6