From 0bff37f74e2e4359b94a31a64a518cbf25ec1acd Mon Sep 17 00:00:00 2001 From: Neale Ranns Date: Thu, 1 Aug 2019 01:04:24 -0700 Subject: [PATCH] qos: Uninitialised variable (coverity) Type: fix Fixes: 83832e7ced8be8b7de394415feaba70c32e3c38d Change-Id: I63130c442f71d1aef0d389ab00bac8092224bec2 Signed-off-by: Neale Ranns --- src/vnet/qos/qos_store.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vnet/qos/qos_store.c b/src/vnet/qos/qos_store.c index 18e79a33653..06336434e5d 100644 --- a/src/vnet/qos/qos_store.c +++ b/src/vnet/qos/qos_store.c @@ -168,6 +168,7 @@ qos_store_cli (vlib_main_t * vm, qs = 0xff; enable = 1; sw_if_index = ~0; + value = ~0; while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT) { @@ -188,6 +189,8 @@ qos_store_cli (vlib_main_t * vm, if (~0 == sw_if_index) return clib_error_return (0, "interface must be specified"); + if (~0 == value) + return clib_error_return (0, "value to be stored must be specified"); if (0xff == qs) return clib_error_return (0, "input location must be specified"); -- 2.16.6