From 2a6861ff7bc90c1518b68459210830052774d429 Mon Sep 17 00:00:00 2001 From: Mohsin Kazmi Date: Mon, 15 Apr 2019 13:17:55 +0200 Subject: [PATCH] tap: fix the crash Crash will happen when someone will try to setup a tap interface in host namespace without providing the host side of tap interface custom name. This patch fixes the problem by using the default name in this case. Change-Id: Ic1eaea5abd01bc6c766d0e0fcacae29ab7a7ec45 Signed-off-by: Mohsin Kazmi --- src/vnet/devices/tap/tap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vnet/devices/tap/tap.c b/src/vnet/devices/tap/tap.c index 388cfa34c37..91d4a811ad8 100644 --- a/src/vnet/devices/tap/tap.c +++ b/src/vnet/devices/tap/tap.c @@ -175,6 +175,9 @@ tap_create_if (vlib_main_t * vm, tap_create_if_args_t * args) _IOCTL (vif->tap_fd, TUNSETIFF, (void *) &ifr); vif->ifindex = if_nametoindex (ifr.ifr_ifrn.ifrn_name); + if (!args->host_if_name) + args->host_if_name = (u8 *) ifr.ifr_ifrn.ifrn_name; + unsigned int offload = 0; hdrsz = sizeof (struct virtio_net_hdr_v1); if (args->tap_flags & TAP_FLAG_GSO) -- 2.16.6