From 41b25cf6380d1420b24e191cd7e95cbce1e7cfdc Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Wed, 5 Dec 2018 14:41:21 -0600 Subject: [PATCH] fix spurious error setting SA on ipsec intf Reverse the polarity on test to determine if old SA session deletion succeeded. 0 == success, not failure. Change-Id: I499cb04c7f13165e6c92367d4385057b77fe3836 Signed-off-by: Matthew Smith --- src/vnet/ipsec/ipsec_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vnet/ipsec/ipsec_if.c b/src/vnet/ipsec/ipsec_if.c index 3054af16765..e8b1a4e041a 100644 --- a/src/vnet/ipsec/ipsec_if.c +++ b/src/vnet/ipsec/ipsec_if.c @@ -586,7 +586,7 @@ ipsec_set_interface_sa (vnet_main_t * vnm, u32 hw_if_index, u32 sa_id, if (ipsec_get_sa_index_by_sa_id (old_sa->id) == old_sa_index) hash_unset (im->sa_index_by_sa_id, old_sa->id); - if (!ipsec_add_del_sa_sess_cb (im, old_sa_index, 0)) + if (ipsec_add_del_sa_sess_cb (im, old_sa_index, 0)) { clib_warning ("IPsec backend add/del callback returned error"); return VNET_API_ERROR_SYSCALL_ERROR_1; -- 2.16.6