From 8ae3a53c7a60c0d656c46298509fa40987c8fa8b Mon Sep 17 00:00:00 2001 From: Ole Troan Date: Sun, 10 Mar 2019 21:26:14 +0100 Subject: [PATCH] VPP-1486: stat segment file descriptor leak Close the mmap file descriptor at first opportunity. Change-Id: If8faa1de0a57dc7d8abb3eed97861813b841bd92 Signed-off-by: Ole Troan --- src/vpp-api/client/stat_client.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vpp-api/client/stat_client.c b/src/vpp-api/client/stat_client.c index 25a37f76da8..761c73f0fb7 100644 --- a/src/vpp-api/client/stat_client.c +++ b/src/vpp-api/client/stat_client.c @@ -141,16 +141,19 @@ stat_segment_connect_r (const char *socket_name, stat_client_main_t * sm) if (fstat (mfd, &st) == -1) { + close (mfd); perror ("mmap fstat failed"); return -4; } if ((memaddr = mmap (NULL, st.st_size, PROT_READ, MAP_SHARED, mfd, 0)) == MAP_FAILED) { + close (mfd); perror ("mmap map failed"); return -5; } + close (mfd); sm->memory_size = st.st_size; sm->shared_header = memaddr; sm->directory_vector = -- 2.16.6