From a3d55df1e91a7df4ad4c0e1b639ba12a1ed04c79 Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Fri, 6 Oct 2023 19:06:35 -0700 Subject: [PATCH] tls: report error if connected cannot be initialized Type: fix Signed-off-by: Florin Coras Change-Id: I987ac6b461b473836917bce6ce0d4ac109cc8ddb --- src/vnet/tls/tls.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vnet/tls/tls.c b/src/vnet/tls/tls.c index b3cec80c83a..aca8c9f16a3 100644 --- a/src/vnet/tls/tls.c +++ b/src/vnet/tls/tls.c @@ -227,7 +227,12 @@ tls_notify_app_connected (tls_ctx_t * ctx, session_error_t err) app_session->opaque = ctx->parent_app_api_context; if ((err = app_worker_init_connected (app_wrk, app_session))) - goto failed; + { + app_worker_connect_notify (app_wrk, 0, err, ctx->parent_app_api_context); + ctx->no_app_session = 1; + session_free (app_session); + return -1; + } app_session->session_state = SESSION_STATE_READY; parent_app_api_ctx = ctx->parent_app_api_context; @@ -244,9 +249,6 @@ tls_notify_app_connected (tls_ctx_t * ctx, session_error_t err) return 0; -failed: - ctx->no_app_session = 1; - tls_disconnect (ctx->tls_ctx_handle, vlib_get_thread_index ()); send_reply: return app_worker_connect_notify (app_wrk, 0, err, ctx->parent_app_api_context); -- 2.16.6