From ac3e72cb9765f78f1cf03ff5d5ccd9ff944668b6 Mon Sep 17 00:00:00 2001 From: Neale Ranns Date: Sun, 6 Oct 2019 01:04:26 -0700 Subject: [PATCH] ip: Fix IP unnumbered dump of one interface Type: fix Change-Id: I35fb6fdfba50c4a59cf1ffb94cb51487bcf5afc9 Signed-off-by: Neale Ranns --- src/vnet/ip/ip_api.c | 2 +- test/test_neighbor.py | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/vnet/ip/ip_api.c b/src/vnet/ip/ip_api.c index dd1d1dcaf6c..322a3ed115a 100644 --- a/src/vnet/ip/ip_api.c +++ b/src/vnet/ip/ip_api.c @@ -989,7 +989,7 @@ vl_api_ip_unnumbered_dump_t_handler (vl_api_ip_unnumbered_dump_t * mp) si = vnet_get_sw_interface (vnm, ntohl (mp->sw_if_index)); - if (!(si->flags & VNET_SW_INTERFACE_FLAG_UNNUMBERED)) + if (si->flags & VNET_SW_INTERFACE_FLAG_UNNUMBERED) { send_ip_unnumbered_details (am, reg, sw_if_index, diff --git a/test/test_neighbor.py b/test/test_neighbor.py index 69b00ea6ff2..81c3acb09a3 100644 --- a/test/test_neighbor.py +++ b/test/test_neighbor.py @@ -311,7 +311,16 @@ class ARPTestCase(VppTestCase): # self.pg2.set_unnumbered(self.pg1.sw_if_index) + # + # test the unnumbered dump both by all interfaces and just the enabled + # one + # unnum = self.vapi.ip_unnumbered_dump() + self.assertTrue(len(unnum)) + self.assertEqual(unnum[0].ip_sw_if_index, self.pg1.sw_if_index) + self.assertEqual(unnum[0].sw_if_index, self.pg2.sw_if_index) + unnum = self.vapi.ip_unnumbered_dump(self.pg2.sw_if_index) + self.assertTrue(len(unnum)) self.assertEqual(unnum[0].ip_sw_if_index, self.pg1.sw_if_index) self.assertEqual(unnum[0].sw_if_index, self.pg2.sw_if_index) -- 2.16.6