From b533f3fadeab73aef04b6fd65ab997ed7fce50df Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Tue, 6 Mar 2018 11:10:56 +0100 Subject: [PATCH] vppapigen: do not allow to define message as both request and reply Change-Id: I0738fac32dd0c5d927c52d2eb2c1100d14c147cf Signed-off-by: Marek Gradzki --- src/tools/vppapigen/vppapigen.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/tools/vppapigen/vppapigen.py b/src/tools/vppapigen/vppapigen.py index a1bb0e184df..57e5e3a411e 100755 --- a/src/tools/vppapigen/vppapigen.py +++ b/src/tools/vppapigen/vppapigen.py @@ -574,6 +574,7 @@ class VPPAPI(object): msgs = {d.name: d for d in s['defines']} svcs = {s.caller: s for s in s['services']} + replies = {s.reply: s for s in s['services']} seen_services = {} for service in svcs: @@ -584,6 +585,9 @@ class VPPAPI(object): raise ValueError('Service definition refers to unknown message' ' definition in reply: {}' .format(svcs[service].reply)) + if service in replies: + raise ValueError('Service definition refers to message' + ' marked as reply: {}'.format(service)) for event in svcs[service].events: if event not in msgs: raise ValueError('Service definition refers to unknown ' -- 2.16.6