From f31acfafb2e78841c0cc1813ddf787829d7f937d Mon Sep 17 00:00:00 2001 From: Dave Barach Date: Tue, 28 Jan 2020 17:03:05 -0500 Subject: [PATCH] dhcp: disable extraneous vlib_log spew When there are no dhcp client interfaces configured, it's not useful to make periodic / timeout log entries. Type: fix Signed-off-by: Dave Barach Change-Id: I16b68fe15ad9de789e49ad1b782b3b0e536bad60 --- src/plugins/dhcp/client.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/plugins/dhcp/client.c b/src/plugins/dhcp/client.c index 441590cbcee..8dc57cb78ce 100644 --- a/src/plugins/dhcp/client.c +++ b/src/plugins/dhcp/client.c @@ -887,15 +887,18 @@ dhcp_client_process (vlib_main_t * vm, break; case ~0: - /* *INDENT-OFF* */ - DHCP_INFO ("timeout"); - pool_foreach (c, dcm->clients, - ({ - timeout = dhcp_client_sm (now, timeout, - (uword) (c - dcm->clients)); - })); - /* *INDENT-ON* */ - if (pool_elts (dcm->clients) == 0) + if (pool_elts (dcm->clients)) + { + DHCP_INFO ("timeout"); + /* *INDENT-OFF* */ + pool_foreach (c, dcm->clients, + ({ + timeout = dhcp_client_sm (now, timeout, + (uword) (c - dcm->clients)); + })); + /* *INDENT-ON* */ + } + else timeout = 100.0; break; } -- 2.16.6