From f70cead5eb928954908de48300cc7a9c88430c0f Mon Sep 17 00:00:00 2001 From: Paul Vinciguerra Date: Sun, 10 Mar 2019 07:32:59 -0700 Subject: [PATCH] Tests: 'Fix' __del__ in test/remote_test.py. This is not a fix as much as supressing a warning. __del__ is not a destructor. test/remote_test.py:385:13: F821 undefined name 'cls' cls.vpp.poll() ^ test/remote_test.py:386:16: F821 undefined name 'cls' if cls.vpp.returncode is None: ^ test/remote_test.py:387:17: F821 undefined name 'cls' cls.vpp.terminate() ^ test/remote_test.py:388:17: F821 undefined name 'cls' cls.vpp.communicate() Change-Id: I6f0ecf3ae5dee7f279a4e25994cc1c49470bca26 Signed-off-by: Paul Vinciguerra --- test/remote_test.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/remote_test.py b/test/remote_test.py index 43cb9b93080..e90ccb24f83 100644 --- a/test/remote_test.py +++ b/test/remote_test.py @@ -375,12 +375,14 @@ class RemoteVppTestCase(VppTestCase): def __init__(self): super(RemoteVppTestCase, self).__init__("emptyTest") + # Note: __del__ is a 'Finalizer" not a 'Destructor'. + # https://docs.python.org/3/reference/datamodel.html#object.__del__ def __del__(self): if hasattr(self, "vpp"): - cls.vpp.poll() - if cls.vpp.returncode is None: - cls.vpp.terminate() - cls.vpp.communicate() + self.vpp.poll() + if self.vpp.returncode is None: + self.vpp.terminate() + self.vpp.communicate() @classmethod def setUpClass(cls, tempdir): -- 2.16.6