Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
5993a34
)
stats: coverity errors leaking fd
04/31304/3
author
Ole Troan
<
[email protected]
>
Tue, 16 Feb 2021 00:06:22 +0000
(
01:06
+0100)
committer
Neale Ranns
<
[email protected]
>
Tue, 16 Feb 2021 09:15:40 +0000
(09:15 +0000)
Type: fix
Signed-off-by: Ole Troan <
[email protected]
>
Change-Id: I21368e37d70c5a64babd904bcf5f79339a5ab064
Signed-off-by: Ole Troan <
[email protected]
>
src/vpp/stats/stat_segment.c
patch
|
blob
|
history
diff --git
a/src/vpp/stats/stat_segment.c
b/src/vpp/stats/stat_segment.c
index
43a4870
..
6a666f5
100644
(file)
--- a/
src/vpp/stats/stat_segment.c
+++ b/
src/vpp/stats/stat_segment.c
@@
-335,7
+335,10
@@
vlib_map_stat_segment_init (void)
format_clib_error, clib_mem_get_last_error ());
/* Set size */
if ((ftruncate (mfd, memory_size)) == -1)
- return clib_error_return (0, "stat segment ftruncate failure");
+ {
+ close (mfd);
+ return clib_error_return (0, "stat segment ftruncate failure");
+ }
memaddr = clib_mem_vm_map_shared (0, memory_size, mfd, 0, mem_name);