stats: coverity errors leaking fd 04/31304/3
authorOle Troan <ot@cisco.com>
Tue, 16 Feb 2021 00:06:22 +0000 (01:06 +0100)
committerNeale Ranns <neale@graphiant.com>
Tue, 16 Feb 2021 09:15:40 +0000 (09:15 +0000)
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I21368e37d70c5a64babd904bcf5f79339a5ab064
Signed-off-by: Ole Troan <ot@cisco.com>
src/vpp/stats/stat_segment.c

index 43a4870..6a666f5 100644 (file)
@@ -335,7 +335,10 @@ vlib_map_stat_segment_init (void)
                              format_clib_error, clib_mem_get_last_error ());
   /* Set size */
   if ((ftruncate (mfd, memory_size)) == -1)
-    return clib_error_return (0, "stat segment ftruncate failure");
+    {
+      close (mfd);
+      return clib_error_return (0, "stat segment ftruncate failure");
+    }
 
   memaddr = clib_mem_vm_map_shared (0, memory_size, mfd, 0, mem_name);