Ole Troan [Thu, 8 Jun 2017 08:29:38 +0000 (10:29 +0200)]
Release: Script to generate LF release template.
Change-Id: I88d46c71dffd15e31ce8852af224a4f95a76b1ab
Signed-off-by: Ole Troan <[email protected]>
Damjan Marion [Wed, 26 Apr 2017 08:38:14 +0000 (10:38 +0200)]
Move scripts to extras/
Change-Id: I2abd6367915d4652fcf45025bd251046f3f206ab
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit
5ef1fef692182dabc986995390d46552d88fb9df)
Marek Gradzki [Tue, 6 Jun 2017 15:42:05 +0000 (17:42 +0200)]
Bump vpp version to 17.04.2 for next development cycle
17.04.2 was used, because 17.04.1 tag was already laid.
One of the reasons to bump version for bux fix release
is to have correct version of jvpp artifacts in nexus.
Currently jvpp jars are published as 17.04-SNAPSHOT
and (by nexus desing) are cleaned up on daily basis
because 17.04 artifacts are already in release repository.
Change-Id: Id541c7423c9616cf7baef90c1c784bb442660f0e
Signed-off-by: Marek Gradzki <[email protected]>
Neale Ranns [Fri, 26 May 2017 10:48:53 +0000 (03:48 -0700)]
MPLS lookup DPO does not pop the label (nor does it handle replicate)
Change-Id: I7de6b96631d1645d0eadd38525860d84d78e316d
Signed-off-by: Neale Ranns <[email protected]>
Robert Varga [Thu, 25 May 2017 14:18:28 +0000 (16:18 +0200)]
Fix JNI templates
The JNI templates around array and object handling are wrong in the
sense that they fail to delete local references for objects which
have been assigned to fields/arrays. Fix this by invoking
DeleteLocalRef.
Change-Id: I1c31d81f4235d821ccd51c96be7b176f64284928
Signed-off-by: Robert Varga <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Neale Ranns [Wed, 24 May 2017 16:37:49 +0000 (09:37 -0700)]
MPLS trace fixes
Change-Id: I141a14e1098e562bdb3c3ac576754f4f19dbcb04
Signed-off-by: Neale Ranns <[email protected]>
Jan Gelety [Mon, 22 May 2017 06:40:22 +0000 (08:40 +0200)]
Update CSIT tests 170313 -> rls1704
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I8e598987ea44fffdd100004b492008df63ca2eef
Signed-off-by: Jan Gelety <[email protected]>
Steven [Fri, 19 May 2017 04:22:00 +0000 (21:22 -0700)]
vhost: buffers leak and interface disable upon vring descriptor out of mmap
When processing a vring descriptor which is outside of mmap, we disable
the interface and spit a message to shut/no shut the interface. This is
not practical as application using vhost cannot constantly checking the
logs and do the recovery. The proposed fix is to log an error, like
other errors that we encounter.
The other bug is buffer leak in the function rewind. At the end of the
while loop when b_current != b_head, we still have to give back 1 more
buffer or add 1 to rx_buffers_len.
Change-Id: I68c0b24f070e644cd8878f42272a7b518f14393f
Signed-off-by: Steven <[email protected]>
(cherry picked from commit
95827e430762a2858f4e56e1248a4a93d629a938)
flyingeagle23 [Mon, 15 May 2017 08:57:20 +0000 (16:57 +0800)]
ping command does not work when there is woker thread (VPP-844)
Change-Id: Ic896b237a7d141243e1b7d6d4fbb2a120f44363e
Signed-off-by: flyingeagle23 <[email protected]>
(cherry picked from commit
92a838b14a1862ef07c631412069e968f303639b)
Pierre Pfister [Thu, 20 Apr 2017 13:34:00 +0000 (15:34 +0200)]
vhost: Fix mmap size calculation
I had a bug where a requested size of 1G was resulting in
an aligned size of '1G + 2M', resulting in an OOM error.
Previous code was adding one huge page size
when memory is already aligned.
Change-Id: Idd3aa0e9b893fb3efccba6ae1c7161e26d3f9456
Signed-off-by: Pierre Pfister <[email protected]>
Neale Ranns [Tue, 16 May 2017 15:46:45 +0000 (08:46 -0700)]
ARP learning fixes (VPP-843)
learn ARP peers if, 1) it's a reply to a local address, 2) we are sending a response to a request.
send proxy ARP responses only in the interface the request was sent.
Change-Id: I22b949c65122824233076492b7dd537daca07bc2
Signed-off-by: Neale Ranns <[email protected]>
(cherry picked from commit
d5b6aa139856a1447f7bc5377058202110eaa4cf)
Steven [Wed, 17 May 2017 04:26:13 +0000 (21:26 -0700)]
vhost: bad packet assembled from descriptor chaining
When the descriptor is chained via multiple parts, vhost is supposed
to reassemble the different parts to form a packet prior to passing
the packet to the next input node. However, bad packet was seen, having
bad ethertype, source, and destination mac addresses.
The problem was due to the destination pointer not being incremented as
each chain is processed. THe result was the first chain is copied to the
beginning of the buffer, the next chain is copied, then the last chain
is also copied to the beginning of the buffer. As a result, the ethertype,
source and destination mac, etc, are being overwritten by the very last
chain of the descriptor.
Change-Id: I78f9a91de68c85574047912576dcc311d7597e21
Signed-off-by: Steven <[email protected]>
Florin Coras [Wed, 10 May 2017 19:32:53 +0000 (12:32 -0700)]
Validate ip6 interface fib tables early on
This should avoid random crashes due to reception of packets (multicast
in particular) before ip6 addresses are configured on the interfaces.
Change-Id: Ibcf1a5a2ae2fa75f8b57da1b2f09f32c081210d7
Signed-off-by: Florin Coras <[email protected]>
Marek Gradzki [Fri, 12 May 2017 16:24:34 +0000 (18:24 +0200)]
jvpp: fix memory allocation for variable lenght messages (VPP-841)
Change-Id: I9a46125e3cf9815c08cf8cca17713ec6e9121eae
Signed-off-by: Marek Gradzki <[email protected]>
Neale Ranns [Sat, 13 May 2017 12:52:58 +0000 (05:52 -0700)]
Fix FIB recursion loops via cover (VPP-842)
Change-Id: Ia91c3e8cb27b9e4c1cccefc0a4857dd9995450ab
Signed-off-by: Neale Ranns <[email protected]>
Andrew Yourtchenko [Thu, 11 May 2017 10:33:54 +0000 (12:33 +0200)]
acl-plugin: unapply the ACLs if interface is being deleted
(HC2VPP-137 is the client behavior triggering this)
If the user does not unapply the ACLs off the interface,
but deletes the interface, the subsequent reuse of the
sw_if_index might find itself with the datapath
hooked up for ACL processing even though there is
no ACL configured. The fix is to unapply any ACLs
in the callback which is called upon the sw_if_index
addition/deletion.
Change-Id: Icea413d7fbf1ef891844a4818626e1b34fe79cbf
Signed-off-by: Andrew Yourtchenko <[email protected]>
Andrew Yourtchenko [Tue, 2 May 2017 18:08:51 +0000 (20:08 +0200)]
Avoid active connection prevent timeout of idle conns after it
Fix a logic error related to timing out of the connections
following the active one. To avoid this class of issue in
the future, create corresponding testcases, as well as some
trivial sanity testcases for both IPv4 and IPv6.
Since these tests are timing-dependent and take up time,
mark them as extended tests.
Change-Id: I2c72bad5efda7db8aa9cb05801fe47928dc47927
Signed-off-by: Andrew Yourtchenko <[email protected]>
(cherry picked from commit
57d7dbc8bf8a49ee2421fe97bd3ed7099d2384bf)
Hongjun Ni [Wed, 26 Apr 2017 10:40:55 +0000 (18:40 +0800)]
Fix mac check issue for vitual tunnel interface with no mac address
Change-Id: I6ce21317fcaa25781199f4329be815f076ab8b09
Signed-off-by: Hongjun Ni <[email protected]>
Shwetha Bhandari [Thu, 27 Apr 2017 08:43:10 +0000 (14:13 +0530)]
ioam: adding missing setup api msg crc table
Change-Id: Ic95fe6179de1151796188813cc595187d4c842a0
Signed-off-by: Shwetha Bhandari <[email protected]>
(cherry picked from commit
851a37a78f80427a910a9cb571e5a7d70c120e38)
Milan Lenco [Wed, 26 Apr 2017 13:02:16 +0000 (15:02 +0200)]
Temporary workaround for the bug VPP-698
Change-Id: Ie0548868154ef5e9bdc7a57a16f68284683ad9a5
Signed-off-by: Milan Lenco <[email protected]>
Ole Troan [Fri, 21 Apr 2017 19:15:53 +0000 (21:15 +0200)]
Python API: Missing python-cffi dependency for RPM.
Change-Id: I36852524f8a8bb38031e4e7bf92828e89abbb984
Signed-off-by: Ole Troan <[email protected]>
Ole Troan [Fri, 21 Apr 2017 15:14:29 +0000 (17:14 +0200)]
make test: mark all BFD tests as extended
Change-Id: Id6c482cf01f49257a05600ae1458f5db09c13cf0
Signed-off-by: Ole Troan <[email protected]>
Damjan Marion [Mon, 3 Apr 2017 23:28:26 +0000 (01:28 +0200)]
Fix issue with gre protocol registration when running multithreaded
Change-Id: Ic5bd7da08f8a46b548d56516e4633f0b8badf2a1
Signed-off-by: Damjan Marion <[email protected]>
Damjan Marion [Mon, 3 Apr 2017 12:56:08 +0000 (14:56 +0200)]
Fix issue with udp port registration when running multithreaded
Change-Id: I16606757176649e61f0a51895329586311144766
Signed-off-by: Damjan Marion <[email protected]>
Klement Sekera [Fri, 24 Mar 2017 04:47:15 +0000 (05:47 +0100)]
make test: fix broken plugin paths
Change-Id: I25a6882ec503fc5bb3694411fbdc2eb1f1e1fafc
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit
6abbc2884a0d2006f2b7cc1d9f5b74cefbb7ac78)
Klement Sekera [Fri, 24 Mar 2017 03:29:06 +0000 (04:29 +0100)]
make test: properly propagate exit status
Change-Id: Ie9f48a0d5e0a9cd08eb8f07d49149eee40f04131
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit
0c8ad446db72078a2255329c2cfaced517829c78)
Damjan Marion [Thu, 23 Mar 2017 09:48:47 +0000 (10:48 +0100)]
Comment out dpdk section in startup.conf
It is empty anyway and it is causing problems if dpdk plugin is not
loaded.
Change-Id: I7b49afec39c78cbaf0c57b50621fb3e6848e3469
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit
60750434fce12e320968a5bbc14cca080048ffd1)
Ole Troan [Thu, 20 Apr 2017 06:55:27 +0000 (08:55 +0200)]
1704: Release notes update. Including old 17.01.
Change-Id: Ifd6e9ce769297534f8de088f583c23ad3f2c51df
Signed-off-by: Ole Troan <[email protected]>
Florin Coras [Wed, 19 Apr 2017 20:49:43 +0000 (13:49 -0700)]
Update release notes
Change-Id: Ie554934b86ab24e82ca22680f6b3d772f5d6e8f9
Signed-off-by: Florin Coras <[email protected]>
Ole Troan [Wed, 19 Apr 2017 11:32:35 +0000 (13:32 +0200)]
1704: Release notes.
Change-Id: I2881ae9c68a4edf60e83923e6409cbd767ada914
Signed-off-by: Ole Troan <[email protected]>
Juraj Sloboda [Fri, 14 Apr 2017 01:24:45 +0000 (03:24 +0200)]
Support ping from outside network in 1:1 NAT (VPP-695)
Change-Id: Iec8fd4c2bd26874bd8bda82172af797e9b92592c
Signed-off-by: Juraj Sloboda <[email protected]>
Juraj Sloboda [Mon, 3 Apr 2017 04:33:23 +0000 (06:33 +0200)]
Make fixes in SNAT code
Change-Id: I691d1bfb2923a07c0003485b1d0272aaf9ed27ee
Signed-off-by: Juraj Sloboda <[email protected]>
Neale Ranns [Tue, 18 Apr 2017 19:56:45 +0000 (12:56 -0700)]
Memory leak in load-balance maps
Change-Id: Iec67ae1232e346d5e0000e0b4c997fdc31865bc6
Signed-off-by: Neale Ranns <[email protected]>
Vengada [Wed, 12 Apr 2017 11:38:56 +0000 (04:38 -0700)]
VPP-341: IOAM documentation
Change-Id: I24139082c795ccdfe19d398637a287523ec7a4cc
Signed-off-by: Vengada <[email protected]>
Signed-off-by: Shwetha <[email protected]>
Signed-off-by: AkshayaNadahalli <[email protected]>
Neale Ranns [Thu, 13 Apr 2017 07:44:52 +0000 (00:44 -0700)]
Remove unsed parameter from fib_table_entry_special_add() (only used in FIB tests). The DPO was incorrectly initialised with FIB_PROTO_MAX
Change-Id: I962df9e162e4dfb6837a5ce79ea795d5ff2d7315
Signed-off-by: Neale Ranns <[email protected]>
shwethab [Tue, 11 Apr 2017 06:21:44 +0000 (06:21 +0000)]
VPP-693: IOAM configuration for SRv6 localsid
This add debug cli to accept SRv6 localsid that will be
used to attract the return traffic for M-Anycast flows.
Change-Id: I8f8dd115c36498141ae4cb143c6584141950b1d3
Signed-off-by: shwethab <[email protected]>
Filip Tehlar [Mon, 10 Apr 2017 05:54:31 +0000 (07:54 +0200)]
LSIP: make LISP statistics collecting thread safe, VPP-692
Change-Id: If884835c0f63de162ecf75fecd2a63a1240ee910
Signed-off-by: Filip Tehlar <[email protected]>
Marek Gradzki [Mon, 10 Apr 2017 12:54:02 +0000 (14:54 +0200)]
jvpp: remove redundant libvlib.la dependency
Follows https://gerrit.fd.io/r/#/c/5681/
Should fix VPP-689.
Change-Id: I5514c3d2657f4ee0a932d14c80f55d1471f5d56f
Signed-off-by: Marek Gradzki <[email protected]>
Eyal Bari [Thu, 30 Mar 2017 00:05:06 +0000 (03:05 +0300)]
BRIDGE-DOMAIN:enable arp term,mac/ip learning on local ints
we should not suppress arps on remote interface instead we should flood them to the local one
used shg != 0 to identify packets from remote interfaces and disable arp term l2 input feature for them
Change-Id: I701537c05df7451a25ccb5bfc9e2b03ea70cff20
Signed-off-by: Eyal Bari <[email protected]>
(cherry picked from commit
a0623f8d26501a230801908cd4bc38d67a35dd23)
John Lo [Sat, 8 Apr 2017 03:32:32 +0000 (23:32 -0400)]
Fix init of ENIC driver to allow receiving of jumbo packets
Set rxmode.enable_scatter field in DPDK port config parameter so ENIC
driver will use multiple mbuf's for receiving jumbo packets.
Also remove ENIC driver check to disable setting ENIC MTU as this
capability is now working with the new ENIC driver, subject to 9002B
limit.
Change-Id: I563976201c4968d4538c0759505cef2de876934a
Signed-off-by: John Lo <[email protected]>
(cherry picked from commit
250b95b71babdfb558554c788a82cf45ccc34ab8)
Florin Coras [Thu, 6 Apr 2017 22:27:35 +0000 (15:27 -0700)]
Fix gpe dp args to allow for 32 bit bridge domain ids, VPP-690
Change-Id: I4e3df197eed33acbceaff495279def8716773303
Signed-off-by: Florin Coras <[email protected]>
Marek Gradzki [Thu, 6 Apr 2017 07:37:00 +0000 (09:37 +0200)]
jvpp: remove unused print&endian headers (fixes VPP-688)
Change-Id: I97e03d98758a08b1f75a9a1f35f0181385a10ae8
Signed-off-by: Marek Gradzki <[email protected]>
Sergio Gonzalez Monroy [Wed, 5 Apr 2017 14:12:38 +0000 (15:12 +0100)]
Fix name typo
Change-Id: Ic7128d4f8a13c021e0fd4731a717193d050431d2
Signed-off-by: Sergio Gonzalez Monroy <[email protected]>
Klement Sekera [Tue, 4 Apr 2017 14:19:48 +0000 (16:19 +0200)]
BFD: add ARP-awareness, fix bugs
Make BFD ARP-aware when sending out packets.
Fix a few one-liner bugs discovered while integrating with cisco
nexus. Enhance CLI view to better observe session state.
Change-Id: I266c29492f351207b84328ab665d9d697969da9c
Signed-off-by: Klement Sekera <[email protected]>
Milan Lenco [Wed, 5 Apr 2017 13:05:12 +0000 (15:05 +0200)]
Fix two more memif coverity issues
Change-Id: Iff7e1562d395f1f2e000fa8c2e98bb85969479d7
Signed-off-by: Milan Lenco <[email protected]>
Filip Tehlar [Wed, 5 Apr 2017 08:06:03 +0000 (10:06 +0200)]
LISP: fix crash when GPE interface is re-added, VPP-685
Change-Id: Ib83baf6ddec4ac192f6b4123d9eb599fb370fd0c
Signed-off-by: Filip Tehlar <[email protected]>
Andrew Yourtchenko [Tue, 4 Apr 2017 20:38:33 +0000 (20:38 +0000)]
acl-plugin: fix pretty-printing in "api trace custom-dump" (VPP-683)
Change-Id: Id15b401223aabe7dacb7566c871ebefc17fbb1fc
Signed-off-by: Andrew Yourtchenko <[email protected]>
Filip Tehlar [Tue, 4 Apr 2017 13:26:54 +0000 (15:26 +0200)]
LISP: fix crash when adding a negative forwarding entry, VPP-681
Change-Id: I190696da5555c05074ee0eee32eb914bd16e38fb
Signed-off-by: Filip Tehlar <[email protected]>
Andrew Yourtchenko [Tue, 4 Apr 2017 14:10:40 +0000 (14:10 +0000)]
acl-plugin: make the IPv4/IPv6 non-first fragment handling in line with ACL (VPP-682)
This fixes the previously-implicit "drop all non-first fragments" behavior
to be more in line with security rules: a non-first fragment is treated
for the purposes of matching the ACL as a packet with the port
match succeeding. This allows to change the behavior to permit
the fragmented packets for the default "permit specific rules"
ruleset, but also gives the flexibility to block the non-initial
fragments by inserting into the begining a bogus rule
which would deny the L4 traffic.
Also, add a knob which allows to potentially turn this behavior off
in case of a dire need (and revert to dropping all non-initial fragments),
via a debug CLI.
Change-Id: I546b372b65ff2157d9c68b1d32f9e644f1dd71b4
Signed-off-by: Andrew Yourtchenko <[email protected]>
Pierre Pfister [Tue, 4 Apr 2017 14:55:21 +0000 (15:55 +0100)]
Fix typo in minimal epoll polling time
epoll was supposed to not sleep when timeout
is less than 1ms, but a typo made it not sleep
any time the requested timeout is lower than
1000 seconds (in practice, never...).
This patch replaces "1e3" with "1e-3", which
represents 1ms.
Change-Id: I731851b27a6bf6ab8e41586e017e94b962b09bf3
Signed-off-by: Pierre Pfister <[email protected]>
Milan Lenco [Fri, 31 Mar 2017 13:32:09 +0000 (15:32 +0200)]
Fix memif coverity issues
Change-Id: I1cd649e1d4582792f75d0db60a9524471fc76a9f
Signed-off-by: Milan Lenco <[email protected]>
Dave Barach [Sun, 26 Mar 2017 23:36:18 +0000 (19:36 -0400)]
vpp-678: Rename "show interfaces" -> "show interface"
To line up with "show interface placement," recently added. Otherwise,
"show int" refers only to "show interface placement," which tends to
annoy the cash customers...
Change-Id: Iea9e3681aeb051e2b0e1ecbf06706d98af9a3abf
Signed-off-by: Dave Barach <[email protected]>
(cherry picked from commit
13ad1f02922858177915b1cb1450041d2e4d85de)
Pablo Camarillo [Wed, 29 Mar 2017 14:54:40 +0000 (07:54 -0700)]
VPP-673 Fix L2 steering.
Change-Id: I1eab03525f234139ceefbc9b9895a35a03a56910
Signed-off-by: Pablo Camarillo <[email protected]>
Andrew Yourtchenko [Wed, 29 Mar 2017 14:47:10 +0000 (16:47 +0200)]
acl-plugin: cleaner node bugfixes (VPP-675)
- use the counters in a private struct rather than node error counters
- ensure the timer for the non-idle connections is restarted
- fix the deletion of conn at the current tail the list
Change-Id: I632f63574d2ced95fb75c5e7fb588c78fb3cce1c
Signed-off-by: Andrew Yourtchenko <[email protected]>
Filip Tehlar [Wed, 29 Mar 2017 07:39:23 +0000 (09:39 +0200)]
LISP: fix IID in decap, VPP-676
Change-Id: I3f67d32d5d76069a27176deef6cba0c1a194b7ec
Signed-off-by: Filip Tehlar <[email protected]>
Jim Gibson [Mon, 27 Mar 2017 20:19:54 +0000 (20:19 +0000)]
af_packet driver failure to check VLIB_BUFFER_NEXT_PRESENT flag
af_packet driver must check that VLIB_BUFFER_NEXT_PRESENT flag is set
when walking vlib_buffer_t next_buffer chain on transmit.
On buffer allocation:
- next_buffer is not and may contain a stale invalid value that
should be ignored if not overwritten by a valid value.
- VLIB_BUFFER_NEXT_PRESENT flag is cleared and only set
if a valid value is written to next_buffer.
Change-Id: Iebf76ce8eea24a0d63c7bf749e672d6a232c80e7
Signed-off-by: Jim Gibson <[email protected]>
Neale Ranns [Wed, 29 Mar 2017 16:34:10 +0000 (09:34 -0700)]
Coverity Error: logically dead code in IP unnumbered CLI
Change-Id: Id3398bd4b7a56c168aaab37942b92715e19d4025
Signed-off-by: Neale Ranns <[email protected]>
Pablo Camarillo [Thu, 16 Mar 2017 09:43:05 +0000 (10:43 +0100)]
Bugfixing and documentation for SRv6
- Fixed three coverity issues
- Linked SRv6 docs
- Moved sample plugin to examples folder
- Fixed bug with hash. Now everything is using mhash. Potentially in the future we want to do bihash.
Change-Id: Ie03a13c8fecb1e315e67d0596cbd23220779aaf2
Signed-off-by: Pablo Camarillo <[email protected]>
shwethab [Wed, 29 Mar 2017 11:36:37 +0000 (11:36 +0000)]
SR replicate mheap corruption fix VPP-672
Change-Id: If1c68fc63fa71fab198f2bf4f79bdd7a9841c2e8
Signed-off-by: shwethab <[email protected]>
Signed-off-by: Pablo Camarillo <[email protected]>
Ole Troan [Mon, 20 Mar 2017 20:38:37 +0000 (21:38 +0100)]
Python API: Fixup of debian package after cFFI changes.
Change-Id: I4c2a1a818f28d4c6cf52af45f3b7dbfa41d77ccb
Signed-off-by: Ole Troan <[email protected]>
(cherry picked from commit
afaa85f873a7bff1cf1e32c22f909af3018ccfee)
John Lo [Sat, 25 Mar 2017 00:11:15 +0000 (20:11 -0400)]
Implement MAC Flush for BD or Interface from the L2FIB
Allow non-static MACs in the L2FIB which is associated with an
interface or a bridge domain (BD) be flushed. MAC flush are
initiated automatically when an interface is removed from a BD
or when a BD is deleted. MAC flush can also be invoked manually
via the following CLI:
l2fib mac-flush interface <if-name>
l2fib mac-flush bridge-domain <bd-id>
Change-Id: Ie33243622834810a765f48ebcd22bdb8e8fc87a4
Signed-off-by: John Lo <[email protected]>
Ole Troan [Sat, 25 Mar 2017 18:25:05 +0000 (19:25 +0100)]
Python-API: debian packaging now depends on python-all (for pybuild)
Change-Id: I6b1dd6bdf03fa506c4b114d15800d9fe03e36395
Signed-off-by: Ole Troan <[email protected]>
(cherry picked from commit
9f81d4fe5cfab856e23926bfdb11c03c04838478)
AkshayaNadahalli [Tue, 28 Mar 2017 06:49:54 +0000 (12:19 +0530)]
Fix output feature processing (VPP-670)
Double committing to 17.04 as its a bug-fix.
Change-Id: I94539812191ad0eb8abe78e2dad25ab96c780f30
Signed-off-by: AkshayaNadahalli <[email protected]>
Ole Troan [Wed, 22 Mar 2017 20:14:32 +0000 (21:14 +0100)]
Change default branch in .gitreview
Change-Id: I204a6125615accaa96b94657e7f76b243c9305d1
Signed-off-by: Ole Troan <[email protected]>
Damjan Marion [Wed, 22 Mar 2017 09:18:13 +0000 (10:18 +0100)]
Add memif - packet memory interface for intra-host communication
Change-Id: I94c06b07a39f07ceba87bf3e7fcfc70e43231e8a
Signed-off-by: Damjan Marion <[email protected]>
Co-Authored-By: Milan Lenco <[email protected]>
John Lo [Wed, 22 Mar 2017 17:27:27 +0000 (13:27 -0400)]
Update MAC address kept for Bonded Interface and its Slaves
Change-Id: I9f7f9f840c3c1aad5e8c9a4fa1ba7a58a85cfd9e
Signed-off-by: John Lo <[email protected]>
Filip Tehlar [Wed, 22 Mar 2017 08:02:33 +0000 (09:02 +0100)]
LISP: improve DP speed
Change-Id: I5bd0721b70dfc240fa9225df3704774f6b0ede81
Signed-off-by: Filip Tehlar <[email protected]>
Damjan Marion [Wed, 22 Mar 2017 10:08:39 +0000 (11:08 +0100)]
vlib: add description field in plugin registration
Change-Id: I88b322a5d602f3d6d3310e971479180a89430e0e
Signed-off-by: Damjan Marion <[email protected]>
Andrew Yourtchenko [Wed, 22 Mar 2017 09:51:14 +0000 (10:51 +0100)]
ping: allow the user to send bursts of N packets instead of single packet
Change-Id: I3c1d3a2db56487473123e6fec2b076a063473313
Signed-off-by: Andrew Yourtchenko <[email protected]>
Klement Sekera [Tue, 21 Mar 2017 07:27:18 +0000 (08:27 +0100)]
make test: run all tests in test-cov target
Change-Id: I7040c1ecc8b6e5e883420c1c81aa8b70e56263e5
Signed-off-by: Klement Sekera <[email protected]>
Klement Sekera [Tue, 21 Mar 2017 07:21:25 +0000 (08:21 +0100)]
make test: support out-of-tree plugins
usage:
env EXTERN_PLUGINS=/path/to/plugins make test
Change-Id: I8eece726dfafeff1cffd921c1e18cd3eb7eb64ed
Signed-off-by: Klement Sekera <[email protected]>
Klement Sekera [Thu, 16 Mar 2017 08:14:59 +0000 (09:14 +0100)]
make test: support out-of-tree tests
env EXTERN_TESTS="/path/to/extra/tests" make test
causes to run the default test set and tests collected from
test_*.py files under subtree specified in EXTERN_TESTS.
Change-Id: I58c5471dd6010730278a5b47d4318737d920bc28
Signed-off-by: Klement Sekera <[email protected]>
Sergio Gonzalez Monroy [Tue, 7 Mar 2017 14:39:29 +0000 (14:39 +0000)]
dpdk: fix plugin linking with sw crypto libraries
Change-Id: I3e3bf786ab3c7672ff2cc7acd221421072e3ac8b
Signed-off-by: Sergio Gonzalez Monroy <[email protected]>
Steven [Thu, 16 Mar 2017 04:18:55 +0000 (21:18 -0700)]
vhost: support interrupt mode
vhost currently supports only polling mode. This patch is to add
interrupt mode. When the interface is configured for interrupt
mode, our input node does not get called unless there is a packet
in the vring.
If a particular CPU has one interface configured for polling mode
and another in interrupt, the input node is set to polling for
that CPU.
This diffs also includes two crashes in vlib's dispatch_node. One is
included in https://gerrit.fd.io/r/#/c/5516. The other crash is in
the ASSERT. The ASSERT can become true when the caller of
dispatch_node is in a loop. The first call converted the node
to polling. The second call thereafter will hit the ASSERT.
Change-Id: If17b6d48b20d7d8605c6a161459828637173cd32
Signed-off-by: Steven <[email protected]>
Martin [Tue, 14 Mar 2017 09:25:45 +0000 (02:25 -0700)]
SNAT: added actual delete to snat_det_map
Change-Id: I8187b43129b80fadd90ea493afb922064f79abbe
Signed-off-by: Martin <[email protected]>
Marek Gradzki [Tue, 21 Mar 2017 10:51:54 +0000 (11:51 +0100)]
policer: fix byte ordering in policer_details msg
Change-Id: Id53131e8cd32bfd35739a7bd7cdbadf3a9f4d941
Signed-off-by: Marek Gradzki <[email protected]>
Vengada [Tue, 21 Mar 2017 08:04:46 +0000 (01:04 -0700)]
Initial draft of VPP changes to cleanup iOAM export.
This is needed for iOAM export for NSH.
Change-Id: I702934b2cde8b1c07ec5c299d5fcd98dce94c62c
Signed-off-by: Vengada <[email protected]>
Andrew Yourtchenko [Tue, 21 Mar 2017 09:31:55 +0000 (10:31 +0100)]
ACL plugin 1.2
L3 path support, L2+L3 unified processing node, skip IPv6 EH support.
Change-Id: Iac37a466ba1c035e5c2997b03c0743bfec5c9a08
Signed-off-by: Andrew Yourtchenko <[email protected]>
Filip Tehlar [Thu, 9 Mar 2017 15:48:39 +0000 (16:48 +0100)]
LISP statistics
Change-Id: I399cac46d279e020ba33459ef759d9d29d3ac716
Signed-off-by: Filip Tehlar <[email protected]>
Gabriel Ganne [Mon, 20 Mar 2017 14:13:02 +0000 (15:13 +0100)]
armv8 - fix os_cpu_clock_frequency for armv8
System timer of ARMv8 runs at a different frequency than the CPU's.
The frequency is fixed, typically in the range 1-50MHz. It can be
read at CNTFRQ special register.
Change-Id: I6a21a6a9e2df783559df0caec63d5525c2258227
Signed-off-by: Gabriel Ganne <[email protected]>
Damjan Marion [Mon, 20 Mar 2017 15:34:15 +0000 (16:34 +0100)]
vnet: add device-input threadplacement infra
This change adds two new debug CLI command:
- "show interface placmenet" to display which
thread (main or worker) is responsible for processing
interface rx queue
vpp# show interface placement
Thread 0 (vpp_main):
node af-packet-input:
host-vpp1 queue 0
Thread 1 (vpp_wk_0):
node af-packet-input:
host-virbr0 queue 0
Thread 2 (vpp_wk_1):
node af-packet-input:
host-vpp2 queue 0
host-lxcbr0 queue 0
- "set interface placmenet" to assign thread (main or worker)
which process specific interface rx queue
vpp# set interface placement host-vpp1 queue 0 main
Change-Id: Id4dd00cf2b05e10fae2125ac7cb4411b446c5e9c
Signed-off-by: Damjan Marion <[email protected]>
John Lo [Fri, 17 Mar 2017 22:05:35 +0000 (18:05 -0400)]
Fix bonded interface name to use instance number starting from 0
With DPDK 17.02, bonded interface device_index does not start
from 0 and may vary depends on the existence of other interfaces.
Implement instance number for bonded interface so the interface
name can make use of instance number starting from 0.
Change-Id: Ia8eb7bd530446faa02ee7c7d1f6abdc22ac60b62
Signed-off-by: John Lo <[email protected]>
Neale Ranns [Sat, 18 Mar 2017 09:57:38 +0000 (02:57 -0700)]
Check change in unnumbered setting before updating IP enabled state
Change-Id: I6424a083ec889961ba4d0cd1df8348f20436be14
Signed-off-by: Neale Ranns <[email protected]>
Damjan Marion [Fri, 17 Mar 2017 22:58:32 +0000 (23:58 +0100)]
features: remove remaining .end_node
Change-Id: If882adb9c937f57223c524ed87453f3053f616ed
Signed-off-by: Damjan Marion <[email protected]>
Ole Troan [Thu, 9 Mar 2017 20:10:45 +0000 (21:10 +0100)]
PNEUM: Fix Coverity error (missing unlock).
Change-Id: I53433e89d06fbc95e160887517acafc1544e81b5
Signed-off-by: Ole Troan <[email protected]>
Alexander Popovsky (apopovsk) [Fri, 17 Mar 2017 19:08:16 +0000 (12:08 -0700)]
Fix bonded ethernet PMD name for DPDK 17.02
In DPDK 17.02 bonded PMD name is changed from rte_bond_pmd
to net_bonding.
Change-Id: I1a57a16b0ae68b5fa56a561a4f75981112228572
Signed-off-by: Alexander Popovsky (apopovsk) <[email protected]>
Neale Ranns [Wed, 15 Mar 2017 19:41:17 +0000 (15:41 -0400)]
64 bit per-thread counters
after:
TenGigabitEthernet5/0/1-output active 107522
17375708 0 7.22e0 161.60
TenGigabitEthernet5/0/1-tx active 107522
17375708 0 6.93e1 161.60
ip4-input-no-checksum active 107522
17375708 0 2.52e1 161.60
ip4-lookup active 107522
17375708 0 3.10e1 161.60
ip4-rewrite active 107522
17375708 0 2.52e1 161.60
before
TenGigabitEthernet5/0/1-output active 433575
110995200 0 6.95e0 256.00
TenGigabitEthernet5/0/1-tx active 433575
110995200 0 7.14e1 256.00
ip4-input-no-checksum active 433575
110995200 0 2.66e1 256.00
ip4-lookup active 433575
110995200 0 3.29e1 256.00
ip4-rewrite active 433575
110995200 0 2.59e1 256.00
Change-Id: I46405bd22189f48a39f06e3443bb7e13f410b539
Signed-off-by: Neale Ranns <[email protected]>
Neale Ranns [Thu, 16 Mar 2017 19:49:09 +0000 (15:49 -0400)]
Fix IP feature ordering.
Drop comes before lookup when enabled. is_first_or_last is not required when setting a feature, the anchor is added in find_config_with_features().
Don't make the PG interfaces automatically L3 enabled, this way we can have tests that check the L3 protocol disbaled behaviour.
Change-Id: Icef22a920b27ff9cec6ab2da6b05f05c532cb60f
Signed-off-by: Neale Ranns <[email protected]>
Neale Ranns [Thu, 16 Mar 2017 11:34:55 +0000 (07:34 -0400)]
MPLS performance improvments.
1 - Quad loop lookup and label imposition.
2 - optimise imposition for the 1 label case
3 - input gets TTL from header directly (no byte swap)
Change-Id: I59204c9e5d134b0df75d7afa43e360f946d1ffe7
Signed-off-by: Neale Ranns <[email protected]>
Neale Ranns [Sat, 11 Mar 2017 13:55:21 +0000 (05:55 -0800)]
Attached hosts
allow this config to function:
set int ip address loop0 169.254.1.1/32 (the default GW address for attached hosts)
set int unnumbered af_packet0 use loop0 ('enable' IP on the host interface)
ip route add 192.168.1.1/32 via af_packet0 (where to find the host)
repeat for each host and host interface.
Inter-host communication is throught the /32 routes.
To allow this:
1 - attached host routes have the ATTACHED flag set, so the ARP code accepts then as legitimate sources
2 - unnumbered interfaces inherit the source address from the IP interface
Change-Id: Ib66c5f0e848c528f79372813adc3a0c11b50717f
Signed-off-by: Neale Ranns <[email protected]>
Ole Troan [Fri, 17 Mar 2017 08:54:51 +0000 (09:54 +0100)]
Python API: Fix RPM packaging (again).
Change-Id: I5c510cde1227a131ddda58d090cd5dbf112ce1fb
Signed-off-by: Ole Troan <[email protected]>
Steven [Fri, 24 Feb 2017 18:03:22 +0000 (10:03 -0800)]
vlib: fix potential crash in dispatch_node ELOG_DATA call
dispatch_node may be invoked from vlib main or worker threads. The call to
ELOG_DATA in dispatch_node passes the parameter &vm->elog_main. It works fine
when dispatch_node is invoked from the main thread. It does bad thing when it
is invoked from the worker thread.
While we are at it, make two additional enhancements to the same area.
1. Use ELOG_TRACK_DATA instead of ELOG_DATA to enhance g2 viewer presentation.
2. Since ELOG_DATA is in the data path, it could get very chatty. Make the call
to ELOG_TRACK_DATA conditional compile.
Change-Id: I80ca0eea10bc1e5d0d5549f9844dd9a34dbb65a2
Signed-off-by: Steven <[email protected]>
Neale Ranns [Wed, 15 Mar 2017 16:34:25 +0000 (12:34 -0400)]
Cache a 'has-features' flag on the adjacency for faster access. Reclaim the node_index memeber from the rewrite for space - this is only used for formtting
before:
ip4-rewrite * * * * 2.66e1 256.00
after:
ip4-rewrite * * * * 2.40e1 256.00
Change-Id: Ic397150727cad38811564777419ad6bd26b8a3a6
Signed-off-by: Neale Ranns <[email protected]>
Neale Ranns [Thu, 16 Mar 2017 20:12:57 +0000 (16:12 -0400)]
Use the feature anchor in the MPLS input arc - it performs much better
Change-Id: I3d64ddb248478accd4d9b3124f018c9aab63a60f
Signed-off-by: Neale Ranns <[email protected]>
Neale Ranns [Fri, 10 Mar 2017 19:53:27 +0000 (11:53 -0800)]
Adjacency refinement; check the cover's interface against the adjacency's
Change-Id: I3fa2f35056b74e479288bb956f2713f727a81c72
Signed-off-by: Neale Ranns <[email protected]>
Alexander Popovsky (apopovsk) [Fri, 17 Mar 2017 01:21:14 +0000 (18:21 -0700)]
Add epel-rpm-macros for CentOS/RHEL install-dep
%py2_install is required by vpp-api-python and is not available on
bare CentOS/RHEL install, causing 'fg: no job control' error.
Added 'epel-rpm-macros' to the list of EPEL dependencies
Change-Id: I1e09d7d825d9d8db06e7385d2b8d5579c8ce748b
Signed-off-by: Alexander Popovsky (apopovsk) <[email protected]>
Damjan Marion [Thu, 16 Mar 2017 16:46:41 +0000 (17:46 +0100)]
vlib: additional runtime_data checks
Change-Id: I9b6ed9741fae89bdefa6f601398eb63a21155069
Signed-off-by: Damjan Marion <[email protected]>
Andrew Yourtchenko [Thu, 16 Mar 2017 12:24:24 +0000 (12:24 +0000)]
ping: Fix coverity error 163907
Return an error if the ip6_interface_first_address decides to return NULL.
Change-Id: Iea0184382b8fbe2af81a781c3671687a1fbb5b32
Signed-off-by: Andrew Yourtchenko <[email protected]>
Eyal Bari [Thu, 16 Mar 2017 08:02:57 +0000 (10:02 +0200)]
API:replaced all REPLY_MACRO's with api_helper_macros.h
Change-Id: I08ab1fd0abdd1db4aff11a38c9c0134b01368e11
Signed-off-by: Eyal Bari <[email protected]>
Steven [Fri, 10 Mar 2017 07:49:32 +0000 (23:49 -0800)]
vhost: wrong value return for VHOST_USER_VRING_GET_BASE
When the VM is migrated, the driver sends VHOST_USER_VRING_GET_BASE
message to the device to get the vring offset. The device is
supposed to shut down the vring, and return the current vring offset.
What the code did was to shutdown the vring, initialize the vring,
and return 0 to the driver.
The fix is to first store last_avail_idx in the message and then close
the vring.
Change-Id: I432e9f50f36d89fe53a45e050edcf5e1218caf7a
Signed-off-by: Steven <[email protected]>