Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
ed81245
)
PNEUM: Fix Coverity error (missing unlock).
94/5694/4
author
Ole Troan
<ot@cisco.com>
Thu, 9 Mar 2017 20:10:45 +0000
(21:10 +0100)
committer
Dave Barach
<openvpp@barachs.net>
Fri, 17 Mar 2017 20:36:55 +0000
(20:36 +0000)
Change-Id: I53433e89d06fbc95e160887517acafc1544e81b5
Signed-off-by: Ole Troan <ot@cisco.com>
src/vpp-api/pneum/pneum.c
patch
|
blob
|
history
diff --git
a/src/vpp-api/pneum/pneum.c
b/src/vpp-api/pneum/pneum.c
index
cbae5cf
..
8b34d3e
100644
(file)
--- a/
src/vpp-api/pneum/pneum.c
+++ b/
src/vpp-api/pneum/pneum.c
@@
-235,9
+235,10
@@
pneum_rx_resume (void)
pneum_main_t *pm = &pneum_main;
if (!pm->rx_thread_handle) return;
pthread_mutex_lock(&pm->queue_lock);
- if (rx_is_running)
return
;
+ if (rx_is_running)
goto unlock
;
pthread_cond_signal(&pm->resume_cv);
rx_is_running = true;
+ unlock:
pthread_mutex_unlock(&pm->queue_lock);
}