Matus Fabian [Fri, 21 Sep 2018 06:18:41 +0000 (23:18 -0700)]
NAT: Refactoring / Housekeeping (VPP-1415)
Change-Id: Ia3ce24cc94f9b2fb331ad62a4181ddcd41bc78ca
Signed-off-by: Matus Fabian <matfabia@cisco.com>
John Lo [Thu, 20 Sep 2018 20:07:00 +0000 (16:07 -0400)]
Add more CLI options to vpp_api_test for calling ip_add_del_route
Change-Id: I114e93b6bc71cfcdcfe6d3ddde26f77118e36ab8
Signed-off-by: John Lo <loj@cisco.com>
Florin Coras [Fri, 21 Sep 2018 01:36:54 +0000 (18:36 -0700)]
tcp: accept fin-ack in syn-rcvd state
Change-Id: Ibe57abc7d2a06be80146ce28edf4c60ecda991eb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Thu, 20 Sep 2018 18:50:35 +0000 (11:50 -0700)]
vhost: show vhost may display garbage after the interface name
DBGvpp# show vhost-user
Virtio vhost-user interfaces
Global:
coalesce frames 32 time 1e-3
number of rx virtqueues in interrupt mode: 0
Interface: VirtualEthernet0/0/0�?x�D (ifindex 3)
The fix is to use format_vnet_hw_if_index_name rather than hi->name. The former
format the name with %v rather than %s
Change-Id: If4d275e1eb249cf87b2d6b796b42f24769f9e3e3
Signed-off-by: Steven <sluong@cisco.com>
Andrew Yourtchenko [Thu, 20 Sep 2018 13:36:51 +0000 (15:36 +0200)]
bihash template: avoid memory leak upon rehash
Call the BV (value_free) when we have performed the rehash
and thus no longer need the memory that old value for the
bucket refers to.
Change-Id: Ibb82174fc8002aeb3e1a6c8d1f90293d73bc45d8
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Tue, 18 Sep 2018 16:41:38 +0000 (18:41 +0200)]
rename vpp-dpdk-dev to vpp-ext-deps
We need to have new tenants in the development package.
This is first of series of patches which will allow us to have multiple
external libs and tools packaged for developer's convenience.
Change-Id: I884bd75fba96005bbf8cea92774682b2228e0e22
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Fri, 7 Sep 2018 15:57:41 +0000 (08:57 -0700)]
UDP-Encap: name counters for the stats segment
change the ADD api so that is returns the 'ID' that can be used
by the client to read the stats from the stats segment and to
delete the object. Previously a similar value used required
to be chosen by the client, now VPP allocates one (like it
does e.g. for interfaces)
Change-Id: I563cf6092276eb990c52d5457c86e72546bcf69e
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Thu, 20 Sep 2018 09:49:25 +0000 (02:49 -0700)]
SR-MPLS: MPLS table checks (VPP-1422)
Change-Id: I397715ea8c1966f5ee61128f284d62d875c568e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Tue, 18 Sep 2018 05:09:02 +0000 (22:09 -0700)]
session/svm: add want_tx_event flag to fifo
Have applications use explicit flag to request events from vpp when it
transmits from a full fifo.
Change-Id: I687c8f050a066bd5ce739d880eaec1f286038d95
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Fri, 7 Sep 2018 16:32:36 +0000 (09:32 -0700)]
Route counters in the stats segment
route ADD API changed to return the stats segment index to use to read the counters
Change-Id: I2ef41e01eaa2f9cfaa49d9c88968897793825925
Signed-off-by: Neale Ranns <nranns@cisco.com>
Mohsin Kazmi [Tue, 21 Aug 2018 14:07:03 +0000 (16:07 +0200)]
vhost-user: Add disable feature support in api
Two flags to disable mergable rx buffers and indirect
descriptors are added to api.
Change-Id: Iba0ee9c48d19dfc3d3420a3fdaf44a1a1d325e99
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Juraj Sloboda [Mon, 23 Jul 2018 10:22:54 +0000 (12:22 +0200)]
NAT44 virtual fragmentation reassembly for endpoint-dependent mode (VPP-1325)
Change-Id: I36ece2ef2eaef9fa559d69ec7f7f07e7c16a7a9d
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Steven [Wed, 19 Sep 2018 22:30:25 +0000 (15:30 -0700)]
vmxnet3: invoke vlib_buffer_enqueue_to_next() with the wrong buffers for chain buffers
If we invoke the subject API with 2 buffers, each with 2 chains, the content of
buffers[0] should be head of 1st buffer, and content of buffer[1] should be
head of 2nd buffer.
What the code did was to put
buffers[0] = head of 1st buffer
buffers[1] = next chain of 1st buffer
buffers[2] = head of 2nd buffer
buffers[3] = next chain of 2nd buffer
This is wrong and can cause crash.
The fix is to only increment bi when the entire packet is found which may consist
of multiple fragments.
Change-Id: If02cd5186a039d7a6c08a0959112840bdb242317
Signed-off-by: Steven <sluong@cisco.com>
juraj.linkes [Wed, 19 Sep 2018 13:01:47 +0000 (15:01 +0200)]
VPP-1421: Reworked results gathering
The previous version sent the whole VPPTestResult object through pipe,
which uses pickle to transfer objects. Pickle does not support sending
any arbitrary objects and was causing issues. Now just a tuple of
(test_id, result) is sent.
Change-Id: I3a3a9e6f1b9ac9b05889babfc1f7560c7ac4471c
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Andrew Yourtchenko [Wed, 19 Sep 2018 13:50:55 +0000 (15:50 +0200)]
bihash template: reinstate the check for the available memory in the arena
ffb14b9554afa1e58c3657e0c91dda3135008274 has changed the semantics
of alloc_arena_next to become an offset off alloc_arena, but
in the available memory check in BV (alloc_aligned) it still treats
it as a virtual address, resulting in the check always succeeding,
thus over a prolonged period bihash arena allocator
potentially overwriting whatever is following the arena.
Change-Id: I18882c5f340ca767a389e15cca2696a0a97ef015
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Wed, 19 Sep 2018 11:55:32 +0000 (04:55 -0700)]
GRE: fix 4o6 and 6o4 adj stacking
Change-Id: I13dc5eab8835c4f3b95906816d42dccfeee8b092
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Wed, 19 Sep 2018 08:39:43 +0000 (10:39 +0200)]
dpdk: mask and warn if rx/tx offload is not available
Warning messsage is displayed in system log:
vpp# show log
1970/ 1/ 1 01:00:01:198 warn dpdk unsupported rx offloads requested on port 0: scatter
Change-Id: I40021066daf2d37ca5233e3adce55e412f0d3932
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Wed, 19 Sep 2018 11:07:02 +0000 (04:07 -0700)]
L2-fib-dump: send 1 or 0 rather than flag value
Change-Id: I487b3b480347f60ffe3af4029adfb22b6700cea7
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 2 Aug 2018 19:16:03 +0000 (12:16 -0700)]
socket api: do not delay sending of messages
Instead of relying on main epoll loop to send messages, try to send as
soon as possible.
Change-Id: I27c0b4076f3599ad6e968df4746881a6717d4299
Signed-off-by: Florin Coras <fcoras@cisco.com>
dongjuan [Tue, 11 Sep 2018 11:20:30 +0000 (11:20 +0000)]
nat: free port_bitmap
Change-Id: Ied0fc50f1afb0f7fc563784544699726a6d03380
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Florin Coras [Tue, 18 Sep 2018 23:12:50 +0000 (16:12 -0700)]
session: improve close procedure
Change-Id: I6201a044e70ab6a58db8212960c57edc77c41f96
Signed-off-by: Florin Coras <fcoras@cisco.com>
Yichen Wang [Wed, 19 Sep 2018 00:32:29 +0000 (17:32 -0700)]
Fix documentation for SHG in bridge domain
Change-Id: If094971cf011d09fa0daf3ff393f490e584c1151
Signed-off-by: Yichen Wang <yicwang@cisco.com>
Steven [Tue, 18 Sep 2018 19:34:59 +0000 (12:34 -0700)]
vmxnet3: add support for "non-default" next node
Support feature arc
Support set interface next node
Enqueue packet to either ip4, ip6, or ethernet_input based on packet type
Change-Id: I11fb6bba98ee0bfa1d057474fc6cf3be48ef1c48
Signed-off-by: Steven <sluong@cisco.com>
jdenisco [Mon, 17 Sep 2018 19:39:09 +0000 (15:39 -0400)]
docs: Added Related Projects and Archive
Change-Id: I9a6076aa53d810ec44761d9f9459eb91f2c05974
Signed-off-by: jdenisco <jdenisco@cisco.com>
Klement Sekera [Tue, 18 Sep 2018 12:32:27 +0000 (14:32 +0200)]
fix TEST_JOBS=auto max jobs detection
Change-Id: I63f747e92d239e878550392df24fb7aac2b5a3e3
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Matthew Smith [Tue, 18 Sep 2018 15:52:58 +0000 (10:52 -0500)]
disable scatter/gather for ENA with DPDK 18.08
The scatter/gather rxmode flag was set for ENA when building
against DPDK >= 18.08. ENA does not support this, so disable
it. It looks like enabling it was a copy/paste error.
Also, after offloads are adjusted based on whether "no-multi-seg"
is set, those configurations are overwritten by copying
port_conf_template over the port config. That should only happen
for versions of DPDK older than 18.08 because 18.08 and newer
make changes directly on the port config instead of making changes
to the template. Make the clib_memcpy() conditional on the DPDK
version being less than 18.08. After doing so, compiler
errors complain about port_conf_template being declared but not
used, so make it's declaration conditional.
Change-Id: If81980d71c379a565b51dd700b953f8c811a8703
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Ole Troan [Tue, 18 Sep 2018 10:46:14 +0000 (12:46 +0200)]
STATS: First go at documentation
Change-Id: I4d586456c46994b60ff7670d1411997a3615a284
Signed-off-by: Ole Troan <ot@cisco.com>
Florin Coras [Fri, 29 Jun 2018 15:44:31 +0000 (08:44 -0700)]
svm: better march support for svm fifo
Change-Id: I6a4335654882a2ca66d3d465e35e350868242b8d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Tue, 18 Sep 2018 09:06:33 +0000 (11:06 +0200)]
STATS: Optimistic concurrency handling in Python library.
Change-Id: I2135f3e77206fd171636a1e0b07c373c0bf093e4
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 18 Sep 2018 08:23:01 +0000 (10:23 +0200)]
STATS: Add Python 3 support to vpp_stats.py.
Change-Id: Iad0b0315fbd493b67e6ca490206ec8e8422790ea
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 4 Sep 2018 11:19:12 +0000 (13:19 +0200)]
STATS: Dynamically mapped shared memory segment
Move from using a hash to a vector with offsets into shared memory.
Limit exposure of VPP data structures and include files to
external stats library and applications.
Change-Id: Ic06129f12d10cf4c4946a86d9bc734eacff2c7da
Signed-off-by: Ole Troan <ot@cisco.com>
Dave Barach [Sun, 16 Sep 2018 15:03:04 +0000 (11:03 -0400)]
Register cdp_input when enabled for the first time
Graceful handling of unknown tlv types
Change-Id: Idbc9ed524fc8b865c8e12571813cc73548bde480
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Sun, 16 Sep 2018 21:49:36 +0000 (14:49 -0700)]
vmxnet3: fix clang initialization error
Change-Id: I2958bd3bdec98d3e380a8ff8f970563020e28afd
Signed-off-by: Florin Coras <fcoras@cisco.com>
zhanglimao [Sat, 15 Sep 2018 05:19:41 +0000 (13:19 +0800)]
fix nsh map index error, it will cause vpp appear Segmentation fault when vpp process double packages
Change-Id: Ib32bb351356b84aaf696c57398610b52a5a1f4dd
Signed-off-by: zhanglimao <zhanglimao0017@gmail.com>
Florin Coras [Sat, 15 Sep 2018 00:56:29 +0000 (17:56 -0700)]
tls: fix openssl engine write complete condition
Change-Id: Ic1526f6916970ce2b0c4fc0d148d4396fa629b5f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 14 Sep 2018 20:17:41 +0000 (13:17 -0700)]
session: ensure detach is done with worker barrier
Change-Id: I98a79f2c3b0268c414dd295c7ebfc561ce049d4b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 14 Sep 2018 21:46:39 +0000 (14:46 -0700)]
tls: use application interface apis
This also exposes app to tls sessions. As a result "sh session verbose"
will show for each tls session both the application's session (app to
tls) and the tls session (tls to tcp).
Change-Id: I1e65c63362ce58f314e762d7db78b44479e1e3a5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven Luong [Sun, 18 Mar 2018 15:01:27 +0000 (08:01 -0700)]
vmxnet3 device driver
Implemented vmxnet3 deivice driver for VMWare ESXi. Tested with Ubuntu 18.04
connected to ESXi 6.0
Ubuntu-18.04 (VPP) --- ESXi-6.0
Change-Id: I85fbc86f2d8532b017bc4271612d17e24e498e4d
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Thu, 13 Sep 2018 15:45:12 +0000 (08:45 -0700)]
BIER API and load-balancing fixes
Change-Id: Ibda19d786070c942c75016ab568c8361de2f24af
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 14 Sep 2018 13:27:42 +0000 (09:27 -0400)]
Remove scaffolding
Change-Id: I4acebbf76556428bb45356c8e5b85c72a85a1656
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Thu, 13 Sep 2018 18:02:12 +0000 (20:02 +0200)]
cpack: add deb/rpm packaging to VPP module
This allows easy packaging of external projects, including
VOM and sample plugin.
i.e.
$ make -C build-root PLATFORM=vpp TAG=vpp sample-plugin-install
$ ninja -C build-root/build-vpp-native/sample-plugin package
ninja: Entering directory `build-root/build-vpp-native/sample-plugin'
[0/1] Run CPack packaging tool...
CPack: Create package using DEB
CPack: Install projects
CPack: - Install project: sample-plugin
CPack: - Install component: vpp-plugin-sample
CPack: - Install component: vpp-plugin-sample-dev
CPack: Create package
CPack: - package: build-root/build-vpp-native/sample-plugin/vpp-plugin-sample_18.10~rc0~413~g1433e9d1-1_amd64.deb generated.
CPack: - package: build-root/build-vpp-native/sample-plugin/vpp-plugin-sample-dev_18.10~rc0~413~g1433e9d1-1_amd64.deb generated.
Change-Id: I6b3ec2433961e53edd976b19659ce214d272c40a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 14 Sep 2018 09:35:14 +0000 (11:35 +0200)]
dpdk: add detection of mellanox PMDs
Change-Id: I523fc489f5e73ba726ab0711eab3fdde53dc35e8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 14 Sep 2018 12:38:53 +0000 (14:38 +0200)]
vlib: introduce user flags in vlib_frame_t
Those flags have local significance and they can be used for
sending hints to the next node.
Change-Id: Ic2596ee81c64cd16f96344365370e8fcdc465354
Signed-off-by: Damjan Marion <damarion@cisco.com>
Andrew Yourtchenko [Thu, 13 Sep 2018 09:13:13 +0000 (11:13 +0200)]
acl-plugin: do not do clib_smp_atomic_add on per-worker counters
Just do a regular increment, since we are not contending for these counters.
This also makes the tests pass on ARM ThunderX (VPP-1395).
Change-Id: I333aaa11d4145d13d322868900bc114df85a020d
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
John Lo [Thu, 13 Sep 2018 22:10:25 +0000 (22:10 +0000)]
Revert "L2-input: use vlib_buffer_enqueue_to_next"
The patch did not improve single input link performance and
degrade performance with multiple input links.
This reverts commit
b1232555e91b286feab5667b5a22f29aa8e96626.
Change-Id: Ib9336a2e0610088b9145a43cacbdadb52dabd522
Signed-off-by: John Lo <loj@cisco.com>
John Lo [Thu, 13 Sep 2018 18:08:59 +0000 (14:08 -0400)]
Ehnance and fix vpp_api_test and custom_dump to support SR-MPLS
Change-Id: I2e06de176f4272b4b7475857b42fe0d106382b6f
Signed-off-by: John Lo <loj@cisco.com>
Florin Coras [Wed, 12 Sep 2018 23:08:01 +0000 (16:08 -0700)]
vcl: keep track of unexpected events
If sessions are marked as blocking, events for other sessions received
while waiting for the blocking sessions, are added to a pending list and
processed later.
Change-Id: Ia6c71006b1c2bcb78af708390da0cd436af397cc
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Thu, 13 Sep 2018 16:43:19 +0000 (18:43 +0200)]
cmake: use VPP package in VOM
Change-Id: I83b244be920521e580085beffb7e40613e67c8ee
Signed-off-by: Damjan Marion <damarion@cisco.com>
John Lo [Thu, 13 Sep 2018 19:08:08 +0000 (15:08 -0400)]
Fix memory leak in API/CLI to create/modify SR policies
The segment list vector built by the API/CLI is not freed after
SR policy creation or modification.
Change-Id: If439005481cada6c6af7cb560fe7a4381dd49384
Signed-off-by: John Lo <loj@cisco.com>
Ping Yu [Thu, 13 Sep 2018 22:41:33 +0000 (18:41 -0400)]
Add a polling configure to make thread bind with hardware engine
Change-Id: Ib4130098dd9bf45370bdee9a04e4804074df58b1
Signed-off-by: Ping Yu <ping.yu@intel.com>
Neale Ranns [Wed, 12 Sep 2018 10:53:03 +0000 (06:53 -0400)]
L2-FWD: use vlib_buffer_enqueue_to_next and cache prefetch fix
before:
l2-fwd ... 1.72e1 256.00
after:
l2-fwd ... 1.49e1 256.00
Change-Id: I24b29b799435776abc6e60df0dd0301b74aac99b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Wed, 12 Sep 2018 20:37:30 +0000 (22:37 +0200)]
vppinfra: optmize clib_count_equal functions
Change-Id: Ia4c79d560bfa1118d4683a89a1209a08c5f546b3
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Thu, 13 Sep 2018 09:36:25 +0000 (02:36 -0700)]
NAT: TCP MSS clamping
NAT plugin changes the MSS value in TCP SYN packets to avoid fragmentation.
If the negotiated MSS value is greater than the configured value it is changed
to the configured value. If the negotiated MSS value is smaller than the
configured value it remains unchanged.
Change-Id: Ic3c4f94a2f1b76e2bf79f50f3ad36a4097f3f188
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Paul Vinciguerra [Thu, 13 Sep 2018 01:02:21 +0000 (18:02 -0700)]
Trivial: Fix lisp flag label
Change-Id: Ic5339169124edc8ea1f82ffcba7cde8b7f224e83
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Fri, 7 Sep 2018 18:04:52 +0000 (11:04 -0700)]
IP-neighbor: add and delete internal API
Change-Id: I4d1ab5ff0c8f0756e91bf63e045f88513bb7d039
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Paul Vinciguerra [Wed, 12 Sep 2018 20:40:13 +0000 (13:40 -0700)]
Fix: vppapigen make build fails on fresh install
Steps to reproduce:
vagrant@localhost:/vagrant$ build-root/vagrant/build.sh
...
@@@@ Building vpp in /vagrant/build-root/build-vpp-native/vpp @@@@
[51/1169] Generating API header /vagrant/build-root/build-vpp-native/vpp/vlibmemory/memclnt.api.json
FAILED: cd /vagrant/build-root/build-vpp-native/vpp/vlibmemory && mkdir -p /vagrant/build-root/build-vpp-native/vpp/vlibmemory && /vagrant/src/tools/vppapigen/vppapigen --includedir /vagrant/src --input /vagrant/src/vlibmemory/memclnt.api JSON --output /vagrant/build-root/build-vpp-native/vpp/vlibmemory/memclnt.api.json
AttributeError: 'module' object has no attribute 'dumps'
This seems to be due to JSON.py namespace colliding with the standard lib json.py
Change-Id: If389e4e05ef0c166b0c2b3bef7ec0185298679a8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Wed, 12 Sep 2018 13:42:50 +0000 (09:42 -0400)]
L2-input: use vlib_buffer_enqueue_to_next
use the same trick as l2-ouput to group the processing of packets
on the same interface.
Change-Id: Ib2a6a1b5f362372936197f5bb2fdd0fe9439226b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Wed, 12 Sep 2018 16:08:13 +0000 (12:08 -0400)]
fix bihash test code
Change-Id: Ie71b99385c33122cbf55f80ebabdc2ccdb4cf2ae
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Wed, 12 Sep 2018 10:12:36 +0000 (12:12 +0200)]
cmake: create cmake VPP module, update sample-plugin so it uses it
Change-Id: I32e91ba8e55797ffe169f98b09bdb42caa5c7de2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 12 Sep 2018 12:01:10 +0000 (14:01 +0200)]
Always use 'lib' instead of 'lib64'
It is packaging responsibility to put libs in the right place.
Use of lib64 resulted in huge amount of files with hardcoded lib64.
This patch simplifies things...
Change-Id: Iab0dea0583e480907732c5d2379eb951a00fa9e6
Signed-off-by: Damjan Marion <damarion@cisco.com>
Pierre Pfister [Wed, 12 Sep 2018 12:08:53 +0000 (14:08 +0200)]
Fix LB memory leak and remove useless code
Vector sort_arr was actually never freed.
This change also removes some nearby code which
happens to be totally useless.
Change-Id: I2f265c1b4770cbcd75a2fb69ea54e46e1b54245a
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Damjan Marion [Wed, 12 Sep 2018 11:32:01 +0000 (13:32 +0200)]
fix missing extern in vnet/ethernet/node.c
Change-Id: Idabdd1112ba7e390a7b14a83cc7fbd198c8754df
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Wed, 12 Sep 2018 11:37:43 +0000 (07:37 -0400)]
L2-Learn: use vlib_buffer_enqueue_to_next
before:
l2-learn ... 2.00e1 256.00
after:
l2-learn ... 1.77e1 256.00
Change-Id: I22fe9ab4ec995ee22c547cfe16bf88c04838520c
Signed-off-by: Neale Ranns <nranns@cisco.com>
Yichen Wang [Wed, 29 Aug 2018 06:05:27 +0000 (23:05 -0700)]
vhost: Fix VPP crash when reloading VM with mixed-type ports [VPP-1406]
When VM is having mixed type of vhost-user and SRIOV ports, QEMU (RedHat
v2.10) will not send disconnect signal to VPP, and just gives the new
memory region directly. VPP is not able to handle new memory region
mapping without disconnect signal first, which will result in a SEGV.
The fix will handle the VM reboot scenario without explict disconnect
signal from QEMU.
The fix is to invalidate the avail, desc, and used pointers in the txvq
when the new memory regions are received. This is because these pointers
are not valid anymore with the new memory regions. In the input node, check
to make sure the avail pointer is valid and punt if not.
Change-Id: Ieb8b427b202f4442a58907dab1661d63a03650de
Signed-off-by: Yichen Wang <yicwang@cisco.com>
Neale Ranns [Tue, 11 Sep 2018 14:39:43 +0000 (07:39 -0700)]
VXLAN-GBP: use common types on the API
Change-Id: I11ec0d7048d36c30a97d437e5b0abd05f06ab0eb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Khers [Tue, 4 Sep 2018 12:00:37 +0000 (16:30 +0430)]
device flags will set in dpdk_update_link_state.
Change-Id: If74acb0168bed2201d2a8b47bf3f860540d1574b
Signed-off-by: Khers <s3m2e1.6star@gmail.com>
Matthew Smith [Tue, 11 Sep 2018 18:50:48 +0000 (13:50 -0500)]
Add patch for ixgbe x550 SFP+ to DPDK 18.08
Patch for ixgbe which has been used with DPDK 18.02, 18.05.
If the link flaps before link status has been successfully
collected, the MAC will be reset and the PMD will not wait
long enough for it to come back up before giving up, which
will continue happening every time an attempt is made to
check the link status.
This patch was submitted to upstream DPDK in July 2018 but
it has not been included in a release yet.
Change-Id: Ib2100b33d2a986f3cf74e42fc5538412f76f42c7
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Sirshak Das [Wed, 22 Aug 2018 00:46:52 +0000 (08:46 +0800)]
Add and enable u32x4_extend_to_u64x2_high for aarch64 NEON intrinsics.
This is the high version of extendto. This function accomplishes the
same task as both shuffling and extending done by SSE intrinsics.
This enables the NEON version for buffer indexes to buffer pointer
translation.
Change-Id: I52d7bbf3d76ba69c9acb0e518ff4bc6abf3bbbd4
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Reviewed-by: Yi He <yi.he@arm.com>
Verified-by: Lijian Zhang <lijian.zhang@arm.com>
Ed Warnicke [Mon, 30 Jul 2018 20:48:32 +0000 (15:48 -0500)]
Fix create memif socket
create interface memif [id <id>] [socket-id <socket-id>] ...
Can optionally take a socket-id.
You create a socket-id with:
create memif socket [id <id>] [filename <path>]
Unfortunately, this doesn't work because "create memif" was
deprecated. It results in:
vpp# create memif socket id 0 filename /run/vpp/test.socket
command deprecated. Please use 'create interface memif' instead.
This fixes it by clipping out the
create memif
command entirely.
Change-Id: If503758706bf758b6cb46e958200527a5856c600
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Florin Coras [Tue, 11 Sep 2018 23:33:36 +0000 (16:33 -0700)]
vcl: add apis that expos fifo as buffer
Change-Id: I4bd9c9f73499711e04b38d53daa5c917a4285bf5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 11 Sep 2018 07:10:41 +0000 (00:10 -0700)]
vcl: improve read and fifo event handling
Change-Id: Ic1c51818b8aa8dbd164e70bb3b7471868e5af6f6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Tue, 11 Sep 2018 21:20:23 +0000 (17:20 -0400)]
bihash 32/64 bit shared memory interop
This patch makes 32/64 bit interoperable shared memory bihash tables
work regardless of where they're mapped.
Change-Id: If5b4a37ccdaa75410eba755c7d7195633de1b30b
Signed-off-by: Dave Barach <dave@barachs.net>
Neale Ranns [Tue, 11 Sep 2018 12:55:50 +0000 (05:55 -0700)]
indent off in ip_lookup_set_buffer_fib_index
when the name of the structure crosses a line boundary it's painful to parse...
Change-Id: I5d0606900802fb8d64a065f31f3e2a53bd8a5f40
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Sun, 9 Sep 2018 08:41:02 +0000 (04:41 -0400)]
L2-learn; cache prefetch fix
the header is written (STORE) the data is only read (LOAD)
Change-Id: Ia3ac0c81224a0db736c329ed3e2e55b7417f08a0
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Wed, 5 Sep 2018 22:42:26 +0000 (15:42 -0700)]
GBP Endpoint Updates
- common types on the API
- endpoints keyed in various ways for DP lookup
- conparison functions for VPP IP address types
Change-Id: If7ec0bbc5cea71fd0983fe78987d147ec1bd7ec8
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Mohsin Kazmi [Tue, 11 Sep 2018 11:06:42 +0000 (13:06 +0200)]
vat: remove the endiness for u8
Change-Id: I9636a4e631cacf22d3189e292888c34f615298b0
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Ole Troan [Tue, 11 Sep 2018 09:26:12 +0000 (11:26 +0200)]
VAT: plugin load errors
- NSH plugin overrode vat_api_hookup()
- Missing format function in mactime.
Change-Id: I2dcbc2522d8f525d223c2ee3bb667111d1b3b78e
Signed-off-by: Ole Troan <ot@cisco.com>
Matthew Smith [Fri, 7 Sep 2018 22:14:30 +0000 (17:14 -0500)]
remove libvlib from libvlibmemoryclient libs
On CentOS 7, having libvlibmemoryclient link libvlib causes
a SEGV when a program or library is run which links against
libvlibmemoryclient and dlopen() is called. This is because
dlopen() executes any functions with __attribute((constructor))
set. The VLIB_CLI_COMMAND macro creates CLI registration
functions that have this attribute set. So CLI registration
functions end up being run by applications which are clients
of the VPP API.
This doesn't occur on ubuntu 16.04, because ld seems to
omit shared libraries that were listed on the command line
if they are not used to resolve any symbols.
Removing the link to libvlib on vlibmemoryclient to fix this
problem results in another problem. Tests of libvcl_preload
fail when running 'make test'. This happens because
libvcl_preload calls dlopen but does not link against libdl.
When libvlibmemoryclient had libvlib linked, these errors
did not occur since libvlib links libdl. Adjusted the build
of libvcl_preload to explicitly link libdl.
Change-Id: I271ba2f9226ce1602e1f6c1525f3b093bb0345ed
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
dongjuan [Tue, 4 Sep 2018 09:40:53 +0000 (17:40 +0800)]
nat: fix busy ports of each thread
which can create dead loop in
nat_alloc_addr_and_port_default function
Change-Id: I468c25ce0f0a0b3f881de564623dea208b2ca700
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Sirshak Das [Wed, 22 Aug 2018 04:02:04 +0000 (12:02 +0800)]
Replacing vtbl NEON intrinsic with rev NEON intrinsic for byte_swap.
Using rev16 vector intrinsic to reverse byteorder in each word
independently.
Change-Id: I071c40780baffe0bda614ec5d9dd92858f574b0d
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Reviewed-by: Brian Brooks <brian.brooks@arm.com>
Reviewed-by: Yi He <yi.he@arm.com>
Verified-by: Lijian Zhang <lijian.zhang@arm.com>
Sirshak Das [Wed, 22 Aug 2018 06:04:33 +0000 (14:04 +0800)]
Add u32x4_extend_to_u64x2 for aarch64 using NEON intrinsics
This is used in vlib_get_buffers_with_offset.
Change-Id: If4ff776bc97d21a22e870300b164eeb6a5ec3638
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Reviewed-by: Brian Brooks <brian.brooks@arm.com>
Reviewed-by: Yi He <yi.he@arm.com>
Verified-by: Lijian Zhang <lijian.zhang@arm.com>
Sirshak Das [Fri, 3 Aug 2018 16:24:51 +0000 (11:24 -0500)]
Add horizontal add (hadd) vector intrinsic via NEON.
Having the NEON equivalent of u32x4_hadd for CLIB_HAVE_VEC128
Change-Id: I210f96f7ecb9b80b4753311a68e5e09ccda7e95b
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Reviewed-by: Brian Brooks <brian.brooks@arm.com>
Reviewed-by: Yi He <yi.he@arm.com>
Verified-by: Lijian Zhang <lijian.zhang@arm.com>
Klement Sekera [Thu, 6 Sep 2018 17:31:36 +0000 (19:31 +0200)]
vapi: support VLAs in typedefs
Change-Id: I3af3916b68189c2174020e5ecc29a7bc45b25efa
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Damjan Marion [Mon, 10 Sep 2018 11:55:46 +0000 (13:55 +0200)]
dpdk: clean interface link information on admin down / stop
Change-Id: Ie68814c8afc6cd67eb75da0b95dffa7b404cb7ba
Signed-off-by: Damjan Marion <damarion@cisco.com>
Andrew Yourtchenko [Mon, 10 Sep 2018 15:26:36 +0000 (15:26 +0000)]
dpdk-plugin: do not request SCTP offload, some cards do not support it while supporting TCP/UDP
The DPDK plugin sets all of the offload flags, which may cause an initialization failure
on the NICs that do not support SCTP offload. The VPP code does not deal with the SCTP
offload at the moment at all, so after discussing with Damjan, we agreed
the best approach to fix the issue is to not request the SCTP offload.
The output of "show hardware" for the NIC in question before this patch:
Name Idx Link Hardware
GigabitEthernet1/0/0 1 down GigabitEthernet1/0/0
Ethernet address 00:e0:67:09:90:4b
Intel 82540EM (e1000)
carrier down
flags: pmd pmd-init-fail maybe-multiseg tx-offload intel-phdr-cksum
rx queues 1, rx desc 1024, tx queues 1, tx desc 1024
cpu socket 0
Errors:
rte_eth_dev_configure[port:0, errno:-22]: Unknown error -22
And the excerpt from "show log":
1970/ 1/ 1 00:00:00:739 notice dpdk Ethdev port_id=0 requested Tx offloads 0x1c doesn't match Tx offloads capabilities 0xf in rte_eth_dev_configure()
Change-Id: I159d65c02fc3f044441972205f1f0ac08e52050c
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Mon, 10 Sep 2018 12:42:56 +0000 (05:42 -0700)]
cmake VOM: j factor chosen based on number of cores
Change-Id: If1c27359cd93f6de6da9a93c3573997a51201959
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Mon, 10 Sep 2018 11:09:21 +0000 (13:09 +0200)]
new multiversioning on ethernet input nodes
Change-Id: I1aa196756b3ff4969b8ff2f117778d2cd87d6dd5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohsin Kazmi [Mon, 20 Aug 2018 16:32:39 +0000 (18:32 +0200)]
vxlan-gbp: Add support for vxlan gbp
This patch implements vxlan with extension of group based
policy support.
Change-Id: I70405bf7332c02867286da8958d9652837edd3c2
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Damjan Marion [Mon, 10 Sep 2018 08:11:17 +0000 (10:11 +0200)]
cmake: put vpp_api_test back to packaging
Change-Id: I1ccd9bd2861d5d8e57b1bd7f9e2439147f603a58
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Sun, 9 Sep 2018 16:40:51 +0000 (09:40 -0700)]
session: lock app worker mq for io events
Also fixes vcl client/server stats and closing procedure.
Change-Id: I7d5a274ea0a3c8ea13062bf61bf402248dfe1a19
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Sat, 8 Sep 2018 21:06:16 +0000 (14:06 -0700)]
vlib: crash in linux_epoll_input_inline for accessing free file index [VPP-1412]
Under rare scenario, epoll may still post an event to VPP although the file
descriptor is already deleted via epoll_ctl (EPOLL_CTL_DEL) and the file
descriptor is close. VPP tries to access the free file index entry and crash.
The fix is to throw away the events which the file descriptor is already deleted.
Change-Id: Ieca3a1873aecb28630c3abc42c40341f27c2faa7
Signed-off-by: Steven <sluong@cisco.com>
(cherry picked from commit
aec7297ba012e1fe4bbf85cdaec8e810aa476cea)
Mohsin Kazmi [Mon, 3 Sep 2018 13:25:43 +0000 (15:25 +0200)]
cmake: Move VOM to cmake
Change-Id: I352dbb8e972e59a4caae4acd507153446470ce6b
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Thu, 6 Sep 2018 16:50:26 +0000 (09:50 -0700)]
L2 BVI/FIB: Update L2 FIB table when BVI's MAC changes
also some moving of l2 headers to reduce dependencies
Change-Id: I7a700a411a91451ef13fd65f9c90de2432b793bb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Sat, 8 Sep 2018 00:09:35 +0000 (17:09 -0700)]
vcl: set worker pthread stop key
Otherwise the key destructor is not called on pthread_exit.
Change-Id: I11e6b9683a926eecd3f40a44aab41924ff9c3101
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 7 Sep 2018 21:32:58 +0000 (14:32 -0700)]
vcl: register workers in order
Change-Id: Ibc74e7f7587f8b17fc0dcec20cc4530b9dd4c3ca
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 7 Sep 2018 20:29:17 +0000 (13:29 -0700)]
session: detect namespace for transport apps
Change-Id: I770607cb213d538a29d7bd5762682981b01e9d18
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 7 Sep 2018 16:13:15 +0000 (09:13 -0700)]
session: fix reentrant listens
Change-Id: I72d400401a308012b43513179870823f6f921e44
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matthew Smith [Thu, 6 Sep 2018 15:59:49 +0000 (10:59 -0500)]
update regex used by rpm build to find lib files
The old expression was '*.so.*.*.*' to find shared library
files with 3 components in the version.
Building from master gives you files with 2 components in
the version (e.g. libvnet.so.18.10). So most libs were not
getting included in vpp-lib.
Change-Id: Ib89d2f5aeb2417eed1b6b851089b9d22f540a226
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Dave Barach [Fri, 7 Sep 2018 15:12:27 +0000 (11:12 -0400)]
Improve NTP / kernel time change event handling
clib_time_verify_frequency(...) rejects clock frequency changes
greater than 1%.
vlib_worker_thread_barrier_sync_int (...) continuously checks that the
barrier hold-down timer is not unreasonably far in the future.
Change-Id: I00ecb4c20e44de5d6a9c1499fa933e3dd834d11a
Signed-off-by: Dave Barach <dbarach@cisco.com>
Damjan Marion [Fri, 7 Sep 2018 10:39:02 +0000 (12:39 +0200)]
cmake: set packaging component for different files
Change-Id: I033a1f5cdb24f77462cb5ec90a62226d93f52925
Signed-off-by: Damjan Marion <damarion@cisco.com>