vpp.git
4 years agol2: fix l2input_feat_names overflow 17/24017/2
Benoît Ganne [Mon, 16 Dec 2019 14:51:38 +0000 (15:51 +0100)]
l2: fix l2input_feat_names overflow

Type: fix

Change-Id: I59549b3aab5a0ccfe7db02757f78528e028121a5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovirtio: fix the tx queue thread binding 97/23097/6
Mohsin Kazmi [Wed, 30 Oct 2019 14:00:04 +0000 (15:00 +0100)]
virtio: fix the tx queue thread binding

Type: fix

Change-Id: Ibbe7e20aebc9153ceba07e048dc0eaa45193f4ea
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agoquic: Implement crypto contexts 10/23310/15
Nathan Skrzypczak [Thu, 7 Nov 2019 12:52:09 +0000 (13:52 +0100)]
quic: Implement crypto contexts

Type: feature

Make quic use the crypto contexts. This introduces a crypto context
pool backed by a hashtable giving ctx indexes by connect params
(ckpair, engine, rx & tx fifo sizes).
Applications keep the initialization vector common.

Change-Id: I22ed6711196cd70a2f2f74240f12113c7af8dfcd
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agogso: minor fixes to gso segmentation 07/23907/2
Mohsin Kazmi [Mon, 9 Dec 2019 10:46:01 +0000 (11:46 +0100)]
gso: minor fixes to gso segmentation

Type: fix

Change-Id: I01602ba7f1a4820c7790a771a5a7281ed66ff905
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agodocs: improve compressed core file documentation 34/24034/1
Dave Barach [Tue, 17 Dec 2019 14:35:23 +0000 (09:35 -0500)]
docs: improve compressed core file documentation

In particular, document "zcat vpp_core.gz | dd conv=sparse of=vpp_core"

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I01b70492ced864b47847c2ef7bc1ea8eb0980ec3

4 years agoip: Protocol Independent IP Neighbors 19/22819/26
Neale Ranns [Mon, 30 Sep 2019 10:53:31 +0000 (10:53 +0000)]
ip: Protocol Independent IP Neighbors

Type: feature

 - ip-neighbour: generic neighbour handling; APIs, DBs, event handling,
aging
 - arp: ARP protocol implementation
 - ip6-nd; IPv6 neighbor discovery implementation; separate ND,
MLD, RA
 - ip6-link; manage link-local addresses
 - l2-arp-term; events separated from IP neighbours, since they are not
the same.

vnet retains just enough education to perform ND/ARP packet
construction.
arp and ip6-nd to be moved to plugins soon.

Change-Id: I88dedd0006b299344f4c7024a0aa5baa6b9a8bbe
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovcl: RX event may lost when accept session repeatedly 10/24010/3
wanghanlin [Mon, 16 Dec 2019 11:14:39 +0000 (19:14 +0800)]
vcl: RX event may lost when accept session repeatedly

Type: fix

Some applications may call accept repeatedly to process all connect
request until get EAGIAIN error. Subsequent call may get RX event of
previous accepted session, then should process it rather than just
discard it.

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: Ice53442de66289a62591b79a9cc31e883e894c23

4 years agoquic: update quicly to v0.0.8-vpp 09/23909/4
MathiasRaoul [Tue, 10 Dec 2019 10:56:20 +0000 (10:56 +0000)]
quic: update quicly to v0.0.8-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I7470d79d1e39716ff83ba2d2b320813d79e2554c

4 years agofib: Glean on NBMA interface points to drop 04/24004/5
Neale Ranns [Mon, 16 Dec 2019 00:53:11 +0000 (00:53 +0000)]
fib: Glean on NBMA interface points to drop

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Iaae7a9e120bbf8168c581b06d3ac0e124b32e0e7

4 years agofib: Adjacency walk fix for IPv6 23/24023/2
Neale Ranns [Mon, 16 Dec 2019 23:14:14 +0000 (23:14 +0000)]
fib: Adjacency walk fix for IPv6

Type: fix

Change-Id: Id3a1950e49d5eb1883af06a14df97e98f55162a8
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovppinfra: bihash walk cb typedef and continue/stop controls 23/23823/2
Neale Ranns [Fri, 6 Dec 2019 05:53:17 +0000 (05:53 +0000)]
vppinfra: bihash walk cb typedef and continue/stop controls

Type: feature

Change-Id: I28f7a658be3f3beec9ea32635b60d1d3a10d9b06
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agofib: Adjacency creation notifications for dlegates 03/24003/1
Neale Ranns [Sun, 15 Dec 2019 22:26:37 +0000 (22:26 +0000)]
fib: Adjacency creation notifications for dlegates

Type: feature

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3feddfe44dee528b9ca05aa0150e9423306ae49d

4 years agotests: changes for scapy 2.4.3 migration 99/23999/3
snaramre [Fri, 13 Dec 2019 23:39:35 +0000 (23:39 +0000)]
tests: changes for scapy 2.4.3 migration

Type: fix
Change-Id: I7e041b666dabd90df23a920a1f1d99db4c10ddfe
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agobonding: Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/partner-state 90/23390/5
Steven Luong [Wed, 13 Nov 2019 03:45:49 +0000 (19:45 -0800)]
bonding: Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/partner-state

We already had /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/state in
the stats segment. Add also the partner-state to be complete.
Change to populate stats segment with the states at startup, after processing
an lacp pdu, and after timer expiration.

Unit test
---------
sudo vpp_get_stats dump | grep /if/lacp
63.00 /if/lacp/3/1/state
61.00 /if/lacp/3/1/partner-state
63.00 /if/lacp/3/2/state
61.00 /if/lacp/3/2/partner-state

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ib7b8e1183d572bb6e422a846aaa2b7b3559a0dc7

4 years agohsa: Fix timing & nits 03/23903/3
Nathan Skrzypczak [Tue, 10 Dec 2019 09:23:13 +0000 (10:23 +0100)]
hsa: Fix timing & nits

Type: fix

Change-Id: I4fef896a3556df75532ef938ca2e263287dd74e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoip: SVR: fix wrong return value 39/23939/2
Klement Sekera [Wed, 11 Dec 2019 13:06:27 +0000 (13:06 +0000)]
ip: SVR: fix wrong return value

Type: fix

Change-Id: I9498b660bf2045bb6aac96d19bb9456a14b35847
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoikev2: fix crash during SA rekey 16/23816/4
Filip Tehlar [Sat, 30 Nov 2019 20:49:40 +0000 (20:49 +0000)]
ikev2: fix crash during SA rekey

Type: fix

Change-Id: Ib00ab9b2f28c0f4d85e96bf95697f61b8e415f37
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
4 years agovcl: fix disconnect from binary api 73/23973/2
Florin Coras [Thu, 12 Dec 2019 20:01:24 +0000 (12:01 -0800)]
vcl: fix disconnect from binary api

Type: fix

Change-Id: I4398d26879b5efd932fa1d9ae232aa918ec736d6
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovlib: fix "<command> help" 44/23944/2
Dave Barach [Wed, 11 Dec 2019 14:46:56 +0000 (09:46 -0500)]
vlib: fix "<command> help"

Walk the sub_commands vector directly.

Type: fix
Fixes: 6b3f25caff262b536a5449ac5461dd041c92a655

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3022b39e5a739647ec68effc6756166ce2da85b6

4 years agosession svm: support for segments larger than 4GB 52/23952/5
Florin Coras [Wed, 11 Dec 2019 22:27:53 +0000 (14:27 -0800)]
session svm: support for segments larger than 4GB

Type: feature

Change-Id: I7d3017bbb369261d74f51807a226f2c12f45291c
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agogbp: use explicit types in api 35/23835/2
Ole Troan [Fri, 6 Dec 2019 12:28:54 +0000 (13:28 +0100)]
gbp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia886858fe608782d64a5346dd33e1e9fa22d8b8f

4 years agosession svm: per thread fifo segment slices 71/23871/15
Florin Coras [Mon, 9 Dec 2019 02:30:42 +0000 (18:30 -0800)]
session svm: per thread fifo segment slices

Type: refactor

Change-Id: I9be652e56cdb48b0aee3253f7ce8d9bed299d824
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
4 years agoavf: explicit types in api 30/23830/2
Ole Troan [Fri, 6 Dec 2019 12:14:14 +0000 (13:14 +0100)]
avf: explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If693e066eeb9312d4535893c279446dc43e8baa2

4 years agonat: session cleanup fix 83/23683/9
Filip Varga [Wed, 27 Nov 2019 16:40:29 +0000 (17:40 +0100)]
nat: session cleanup fix

Ticket: VPP-1795
Type: fix

Change-Id: Ib3b5742119d7013c293a11eb3dd1aadf46b422dd
Signed-off-by: Filip Varga <fivarga@cisco.com>
4 years agordma: add explicit types in api 29/23829/2
Ole Troan [Fri, 6 Dec 2019 12:12:29 +0000 (13:12 +0100)]
rdma: add explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I80c674b73b7f86cf159b8779aab31a87b20def9a

4 years agodocs: Rework the startup configuration section 23/23923/5
John DeNisco [Tue, 10 Dec 2019 19:25:50 +0000 (14:25 -0500)]
docs: Rework the startup configuration section

Type: docs

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ic60aac96a4aeb5532f98dfb85c776bf549c0d660
Signed-off-by: Dave Barach <dave@barachs.net>
4 years agovcl: separate binary api connections per thread worker 87/23687/15
Florin Coras [Thu, 28 Nov 2019 22:21:21 +0000 (14:21 -0800)]
vcl: separate binary api connections per thread worker

Type: fix

Change-Id: I2d72efc74a3b0a5b9e4da265475b1b01bf361125
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoapi: Use vl_msg_push/pop_heap 25/23625/9
Nathan Skrzypczak [Mon, 25 Nov 2019 15:29:38 +0000 (16:29 +0100)]
api: Use vl_msg_push/pop_heap

Type: refactor

Change-Id: I0eb46676fc22ce6825b2d879498df344b5a855e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agosession: Add mq debug cli 29/23729/4
Nathan Skrzypczak [Mon, 2 Dec 2019 15:44:42 +0000 (16:44 +0100)]
session: Add mq debug cli

Type: feature

This add a `show app message queue` cli command
that shows mq size per app & thread.

Change-Id: I5c6ce024b149fb7a47d899bc514c5a4887429982
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: Add support for unidirectional streams 59/23759/5
Nathan Skrzypczak [Tue, 3 Dec 2019 15:25:11 +0000 (16:25 +0100)]
quic: Add support for unidirectional streams

Type: feature

Change-Id: I3a642626a444504594c5e3df40dbc92df54136f0
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agohsa: Add option for multiple ips 43/23843/4
Nathan Skrzypczak [Fri, 6 Dec 2019 13:44:25 +0000 (14:44 +0100)]
hsa: Add option for multiple ips

Type: feature

Change-Id: I133f12f9075a09bda0c5c1ed143d03838b33f6da
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: Use per thread next_cid 01/23901/2
Nathan Skrzypczak [Tue, 10 Dec 2019 09:10:01 +0000 (10:10 +0100)]
quic: Use per thread next_cid

Type: fix

Change-Id: Ia89427257b78f6f7ba62c9d1076bf0593ee2dca7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agodevices: vhost API cleanup 77/22277/7
Jakub Grajciar [Thu, 26 Sep 2019 08:21:59 +0000 (10:21 +0200)]
devices: vhost API cleanup

Use consistent API types.

Type: fix

Change-Id: I2dec594cb834a45004edc9ca58ad7c7b4bd7ff06
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agoquic: Add aggregated quicly stats 16/23916/3
Nathan Skrzypczak [Tue, 10 Dec 2019 12:40:46 +0000 (13:40 +0100)]
quic: Add aggregated quicly stats

Type: feature

Change-Id: Ice8de7030a0330cfe77a58657701f0703e0695dd
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: add more detailed statistics 52/23852/5
MathiasRaoul [Fri, 6 Dec 2019 15:38:56 +0000 (15:38 +0000)]
quic: add more detailed statistics

Type: feature

Change-Id: I3df7b054ec08c7b307413d24468fc3df6a5aacc3
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
4 years agodevices: tap API cleanup 06/21706/19
Jakub Grajciar [Tue, 3 Sep 2019 08:40:01 +0000 (10:40 +0200)]
devices: tap API cleanup

Use consistent API types.

Type: fix

Change-Id: I11cc7f6347b7a60e5fd41e54f0c7994e2d81199f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agoipsec: Init salt value in SA creation CLI (so it's not random) 96/23896/2
Neale Ranns [Tue, 10 Dec 2019 01:08:19 +0000 (01:08 +0000)]
ipsec: Init salt value in SA creation CLI (so it's not random)

Type: fix

Change-Id: Idf4d0b59a1eb2c739a67a4786470884050f81561
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoquic: removing quicly_send call from quic_accept_connection 54/23654/4
MathiasRaoul [Wed, 27 Nov 2019 14:44:57 +0000 (14:44 +0000)]
quic: removing quicly_send call from quic_accept_connection

Type: fix

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I429b50b88c8e029b06854c7433d0bc77619e98a3

4 years agoapi: pass api and client main to rx thread 95/23895/4
Florin Coras [Tue, 10 Dec 2019 00:42:50 +0000 (16:42 -0800)]
api: pass api and client main to rx thread

Type: fix

Change-Id: Ib8313e87a89c80045edd897924917a88b98d1937
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoioam: use explicit api types 80/23880/2
Ole Troan [Mon, 9 Dec 2019 13:25:09 +0000 (14:25 +0100)]
ioam: use explicit api types

Also remove API boilerplate.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I62e795f5af3843af7912707ade4ba178ff326942

4 years agoip: use explicit types in api 87/23887/2
Ole Troan [Mon, 9 Dec 2019 15:08:27 +0000 (16:08 +0100)]
ip: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1fd190da28a765ba430952539c291a741aaa3dce

4 years agoflowprobe: use explicit types in api 83/23883/2
Ole Troan [Mon, 9 Dec 2019 14:51:44 +0000 (15:51 +0100)]
flowprobe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I4f1cccca7de0c07cee472bde80cd6b0ef60046bd

4 years agoapi: multiple connections per process 56/23656/6
Dave Barach [Wed, 27 Nov 2019 16:42:13 +0000 (11:42 -0500)]
api: multiple connections per process

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2272521d6e69edcd385ef684af6dd4eea5eaa953

4 years agovlib: improve test coverage 89/23889/2
Dave Barach [Mon, 9 Dec 2019 15:45:47 +0000 (10:45 -0500)]
vlib: improve test coverage

Add tests.
Remove unused rule-based parser code.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3ca3a9dd9da8ee8f3a47004c98f2f5644db10057

4 years agoapi: fix sock reg passing on read event 60/23860/6
Florin Coras [Sat, 7 Dec 2019 01:05:08 +0000 (17:05 -0800)]
api: fix sock reg passing on read event

Type: fix

Change-Id: I383242e04a114b69fe247d912842be3560e96c10
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoipsec: make sure pad_bytes does not exceed pad data size 63/23863/2
Benoît Ganne [Sat, 7 Dec 2019 16:14:27 +0000 (09:14 -0700)]
ipsec: make sure pad_bytes does not exceed pad data size

This helps GCC understand the memcpy will not overflow pad_data. GCC-6
(default on Debian 9) in particular got confused.

Type: fix

Change-Id: I176eb01531b9d5c7ebec40f015e510b2d56e77c4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agomarvell: use explicit types in api 65/23865/2
Ole Troan [Sun, 8 Dec 2019 12:30:30 +0000 (13:30 +0100)]
marvell: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1af842f38f90d3ede971da74cd28179b61f613cf

4 years agogtpu: use explicit types in api 66/23866/2
Ole Troan [Sun, 8 Dec 2019 13:14:37 +0000 (14:14 +0100)]
gtpu: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I16fcbd5e63526dbf062a3032701479324fe2a4f5

4 years agol3xc: use explicit types in api 68/23868/2
Ole Troan [Sun, 8 Dec 2019 15:09:47 +0000 (16:09 +0100)]
l3xc: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia94eab60689a07de522b8106dd48ff6b669bc770

4 years agoip: coverity fix 38/23838/2
johny [Fri, 6 Dec 2019 12:58:35 +0000 (13:58 +0100)]
ip: coverity fix

Delete Null-checking "p0" in function ip6_tcp_udp_icmp_bad_length,
because it's not necessary.

Type: fix

Signed-off-by: johny <jan.cavojsky@pantheon.tech>
Change-Id: I2bf43a60c1c1d76e42581df27f2285c9e9563093

4 years agolacp: use explit api types 26/23826/2
Ole Troan [Fri, 6 Dec 2019 09:00:47 +0000 (10:00 +0100)]
lacp: use explit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3f19c69a6f6282a97fd591adcd1e4490cf21e743

4 years agolacp: fix control_ping from plugins 59/23859/2
Ole Troan [Fri, 6 Dec 2019 23:39:49 +0000 (00:39 +0100)]
lacp: fix control_ping from plugins

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I030f75234a346ef6a20640c1a0ed65f4934867f2

4 years agostn: use explicit types in api 42/23842/2
Ole Troan [Fri, 6 Dec 2019 13:42:17 +0000 (14:42 +0100)]
stn: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifba4ff0e0f61641ca3f5e7bb72086cb4f32f1909

4 years agovmxnet3: use explicit types in api 45/23845/2
Ole Troan [Fri, 6 Dec 2019 13:55:38 +0000 (14:55 +0100)]
vmxnet3: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2e699fc812c45f88e359f0f7231f372955e70149

4 years agovlib: use explicit types in api 47/23847/2
Ole Troan [Fri, 6 Dec 2019 14:06:49 +0000 (15:06 +0100)]
vlib: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib3a5d9fc36692553eb109976e9365dc7d82911ab

4 years agomap: use explicit types in api 46/23846/2
Ole Troan [Fri, 6 Dec 2019 14:03:42 +0000 (15:03 +0100)]
map: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8f01f9e71c788fbca989d43d5b87da9c33fba0b1

4 years agosvs: use explicit types in api 44/23844/2
Ole Troan [Fri, 6 Dec 2019 13:50:51 +0000 (14:50 +0100)]
svs: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ic9570fca7e434c9b861be8ed064503492225f9fd

4 years agopppoe: use explicit types in api 41/23841/3
Ole Troan [Fri, 6 Dec 2019 13:23:10 +0000 (14:23 +0100)]
pppoe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifd1e1907740e55420dc040eb2afbbbf9887aea3c

4 years agoquic: update quicly to v0.0.7-vpp 79/23679/5
MathiasRaoul [Thu, 28 Nov 2019 11:04:59 +0000 (11:04 +0000)]
quic: update quicly to v0.0.7-vpp

Type: feature

Change-Id: Ieeb9abb59b4d094bbd7bfc04a9007d3cebd645d7
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
4 years agoapi: avoid swapping vlib_rp before barrier sync 59/23659/11
Florin Coras [Wed, 27 Nov 2019 17:15:25 +0000 (09:15 -0800)]
api: avoid swapping vlib_rp before barrier sync

Type: fix

Change-Id: I9868d13e827c6f5aa5535a38f629efb62ff12dbc
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agogso: fix the tap/virtio driver for header offset 48/23848/3
Mohsin Kazmi [Fri, 6 Dec 2019 14:47:48 +0000 (15:47 +0100)]
gso: fix the tap/virtio driver for header offset

Type: fix

Change-Id: Ied34466907fa8ad44f997c600dbf481be4d22027
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agoapi: fix free socket process args 22/23822/3
Florin Coras [Fri, 6 Dec 2019 04:10:53 +0000 (20:10 -0800)]
api: fix free socket process args

Type: fix

Change-Id: I910be067de6ed65790d25cc95a3d8b5b66680567
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agomactime: update api to use explicit types 25/23825/2
Ole Troan [Fri, 6 Dec 2019 08:55:45 +0000 (09:55 +0100)]
mactime: update api to use explicit types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id347e77d0230bf1b22df75bf1ae63a50eaf4d564

4 years agol2e: use explicit api types 27/23827/2
Ole Troan [Fri, 6 Dec 2019 09:05:29 +0000 (10:05 +0100)]
l2e: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1888a8247ef03cfb715a2c0e0e3ca2a108fecbc8

4 years agodpdk: use explicit types in api 34/23834/2
Ole Troan [Fri, 6 Dec 2019 12:20:43 +0000 (13:20 +0100)]
dpdk: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iff7e995499e422003147342ff14de483d807b3f3

4 years agoct6: use explicit type in api 33/23833/2
Ole Troan [Fri, 6 Dec 2019 12:19:01 +0000 (13:19 +0100)]
ct6: use explicit type in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2342baa91234db1336394305c031dbfa21d219a5

4 years agocdp: use explicit types in api 32/23832/2
Ole Troan [Fri, 6 Dec 2019 12:17:17 +0000 (13:17 +0100)]
cdp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If50e66638554e0fcfc72d35a89a39379dfcb530d

4 years agoabf: use explicit types in api 31/23831/3
Ole Troan [Fri, 6 Dec 2019 12:16:21 +0000 (13:16 +0100)]
abf: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9462de3d27b88539bff87c07a59987dd62fb2add

4 years agoigmp: use explicit types in api 36/23836/2
Ole Troan [Fri, 6 Dec 2019 12:33:35 +0000 (13:33 +0100)]
igmp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifdb623c092cf0a9d9e24117edc32c6ddf014052f

4 years agoikev2: use explicit api types 37/23837/2
Ole Troan [Fri, 6 Dec 2019 12:37:51 +0000 (13:37 +0100)]
ikev2: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2171ef678ecad12d681668257498a5a62004152f

4 years agonsh: use explicit api types 39/23839/2
Ole Troan [Fri, 6 Dec 2019 13:01:16 +0000 (14:01 +0100)]
nsh: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8fd870e757e9243d4f0916dfbbe65495f7e1a8c6

4 years agonsim: use explicit api types 40/23840/2
Ole Troan [Fri, 6 Dec 2019 13:05:07 +0000 (14:05 +0100)]
nsim: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icdc359beb127944418305775e42fa88c569dfbd7

4 years agoapi: multiple socket connections per single process 33/23633/7
Florin Coras [Mon, 25 Nov 2019 21:40:42 +0000 (13:40 -0800)]
api: multiple socket connections per single process

Type: feature

Change-Id: Idea1857eb2225881d2982a7aa2ae7a79536b3f33
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agosession: close for reset replies independent of state 21/23821/4
Florin Coras [Thu, 5 Dec 2019 20:05:57 +0000 (12:05 -0800)]
session: close for reset replies independent of state

Type: fix

Change-Id: I8b8875f1dc9203dfbb443ac43df8250cbb0b1edc
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotcp: fix tail rescue with sacks 83/23483/7
Florin Coras [Sat, 16 Nov 2019 01:56:48 +0000 (17:56 -0800)]
tcp: fix tail rescue with sacks

Type: fix

Change-Id: Iad73f47cef3d29c4b0b7d1f58f2f2b14ba4b1d38
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: move bfd over gre to extended tests 07/23807/2
Paul Vinciguerra [Thu, 5 Dec 2019 04:38:12 +0000 (23:38 -0500)]
tests: move bfd over gre to extended tests

This test should be fixed or removed.
EXTENDED_TESTS should not become "BROKEN_TESTS"

Type: test

Change-Id: Id998f0d3b7bd31100f917d076fbd7ddb46d99ed2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agosrv6-mobile 20/23820/2
Tetsuya Murakami [Thu, 5 Dec 2019 18:42:34 +0000 (10:42 -0800)]
srv6-mobile

Type: fix

Plug-in for IPv6 Segment Routing Mobile

Fix the static analysis issue on srv6-mobile/gtp4_d function.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I5c419b76a30c9616dc3557267fcceed0d512b67e

4 years agomap: fix MAP-T ip6 port check 00/23800/2
Matthew Smith [Wed, 4 Dec 2019 21:02:46 +0000 (15:02 -0600)]
map: fix MAP-T ip6 port check

Type: fix
Ticket: VPP-1804

Fix a regression introduced by 640edcd90.

The port set ID on received IPv6 packets for MAP-T was being
checked against the destination port. It should be checked
against the source port.

Added a new unit test to verify that a v6 packet with a good
source port is translated and forwarded and a v6 packet with
a bad source port is dropped. The important part of the test
which will prevent similar future regressions is that the
source port and destination port are not equal. The existing
unit test used the same source and destination port which is
why it did not fail when the regression was introduced.

Change-Id: Idc144ea509722bb9e0f80b3887d220384a04e6d6
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agotests: quic enable per testcase timeout overrides 06/23806/4
Paul Vinciguerra [Thu, 5 Dec 2019 04:18:02 +0000 (23:18 -0500)]
tests: quic enable per testcase timeout overrides

Type: test

Change-Id: I4f8aee3efa53d58f96631fe2d2da5756304fb75a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoclassify: vpp packet tracer support 01/23801/2
Dave Barach [Wed, 4 Dec 2019 22:19:12 +0000 (17:19 -0500)]
classify: vpp packet tracer support

Configure n-tuple classifier filters which apply to the vpp packet
tracer.

Update the documentation to reflect the new feature.

Add a test vector.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Iefa911716c670fc12e4825b937b62044433fec36

4 years agoip: fix cancel termination after receive malformed ip6 packet 83/22683/7
johny [Fri, 11 Oct 2019 16:28:51 +0000 (18:28 +0200)]
ip: fix cancel termination after receive malformed ip6 packet

This fix is for cancel termination of vpp after receive malformed
packet type of ip6.To avoid termination of vpp are checked if are
missing data in packet. This occours, when payload length in ip6
header packet is more than real count of data in packet. When
this error occours, packet is ignore.

Type: fix
Ticket: VPP-1693, VPP-1694

Change-Id: I9d9ecea7b75c8702cb31aa8051c8d4d7ce19659d
Signed-off-by: johny <jan.cavojsky@pantheon.tech>
4 years agosrv6-mobile 04/23804/2
Tetsuya Murakami [Thu, 5 Dec 2019 02:57:46 +0000 (18:57 -0800)]
srv6-mobile

Type: feature

Plug-in for IPv6 Segment Routing Mobile

Support the plug-in function in SR Policy.
Support GTP4.D plug-in as SR Policy plug-in.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I306160b7203921d879940193868944158867c482

4 years agotests: fix wrong checksum error message 13/23813/3
Klement Sekera [Thu, 5 Dec 2019 13:13:21 +0000 (13:13 +0000)]
tests: fix wrong checksum error message

This change fixes the error message, which would previously report
mismatch on IPv6 layer instead of TCP layer.

Type: fix

Change-Id: Ie78779685362a420d155f928b3cdb341bc3fb8bc
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoclassify: Fix 2 coverity errors 98/23798/2
Jon Loeliger [Wed, 4 Dec 2019 17:42:36 +0000 (11:42 -0600)]
classify: Fix 2 coverity errors

Validate two tainted scalars, filter_sw_if_index, that
came from an API message.

Type: fix
Change-Id: I3ac8a09f91f380185e36babeaa6330691f7cb24b
Signed-off-by: Jon Loeliger <jdl@netgate.com>
4 years agopapi: add call stats 63/23663/3
Ole Troan [Wed, 27 Nov 2019 22:12:48 +0000 (23:12 +0100)]
papi: add call stats

Type: feature
Change-Id: Ic6d44122d3e62e09402e3f1946f7e57e9b5e7c5f
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotests: Revert "Python Tests: Make VppTestCase unit testable." 38/23738/3
Paul Vinciguerra [Mon, 2 Dec 2019 18:12:56 +0000 (13:12 -0500)]
tests: Revert "Python Tests: Make VppTestCase unit testable."

Type: test
This reverts commit 087c811b63aa6b0575149749e188bb37e7fb0513.

Change-Id: Ica12597f27d5a75c33c12c2d27a227dc4866adcb
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agotests: add test run time. 84/23684/3
Ole Troan [Thu, 28 Nov 2019 13:48:44 +0000 (14:48 +0100)]
tests: add test run time.

Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id7b30b5fe63e68ae88f3a42aa77d2614ccda724d

4 years agovxlan: fix vxlan hw offload issue 81/23781/3
Chenmin Sun [Wed, 4 Dec 2019 17:41:35 +0000 (01:41 +0800)]
vxlan: fix vxlan hw offload issue

Type: fix

Since Vxlan hw offload jumps the ethernet-input node, so needs to
adjust the data offset accordingly

In original code, the current_data is 0 when arriving vxlan-flow-input
node(due to no graph node before it, except the dpdk-input), so this
code block cannot find the correct vxlan header:
enum
  { payload_offset = sizeof (ip4_vxlan_header_t) };
vlib_buffer_advance (b0, payload_offset);
see code in src/vnet/vxlan/decap.c, function vxlan4_flow_input_node

This patch fixes this issue

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Iab4af7a7dc3b69a117a4c9ea1c59662669a6438c

4 years agosession: fix session_main_get_worker_if_valid 84/23784/2
Nathan Skrzypczak [Wed, 4 Dec 2019 10:02:28 +0000 (11:02 +0100)]
session: fix session_main_get_worker_if_valid

Type: fix

Change-Id: Ie024792015f3c9c52102c9be03da63c79f3456af
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agovcl: resolve VCL part session cleanup issue 76/23776/3
Yu Ping [Tue, 3 Dec 2019 22:49:04 +0000 (06:49 +0800)]
vcl: resolve VCL part session cleanup issue

In Nginx performance test, we notice that there are so many session kept
open with the state of TRANSPORT_DELETE, and it is root caused that
vppcom fails to return close state.

Type: fix

Change-Id: Ia30f959e0e5adb5b8bcfa13fb1dd7b2cb410a31b
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agotls: change SSL_has_pending to avoid BIO check error 89/23689/4
Yu Ping [Thu, 28 Nov 2019 19:14:42 +0000 (03:14 +0800)]
tls: change SSL_has_pending to avoid BIO check error

Type: fix

Change-Id: I454aff1b187b75a1328c90e30b9b487377ae5f68
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agobuild: fix vom_test dependency on EXTENDED_TESTS 02/23802/2
Dave Wallace [Wed, 4 Dec 2019 23:29:39 +0000 (18:29 -0500)]
build: fix vom_test dependency on EXTENDED_TESTS

- Note: This was not caught by CI because the VPP 'make verify'
  target always build libvom.so

Type: fix
Fixes: f0797d130

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I8663e317e4e793c386b09d1cb887133de1e43faf

4 years agogso: add protocol header parser 32/22932/5
Mohsin Kazmi [Tue, 22 Oct 2019 11:33:13 +0000 (13:33 +0200)]
gso: add protocol header parser

Type: feature

Change-Id: I7c6be2b96d19f82be237f6159944f3164ea512d0
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotests: fix exception handling around vapi.connect()/.disconnect() 46/23746/2
Paul Vinciguerra [Tue, 3 Dec 2019 02:42:28 +0000 (21:42 -0500)]
tests: fix exception handling around vapi.connect()/.disconnect()

vapi.connect() only raises subclasses of vpp_papi.VPPIOError.
vapi.disconnect() doesn't raise any exceptions, removed uneeded try block.

Type: test

Change-Id: Ide6e6db298b205f14382065862e358757619a5ba
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agotests: add interface function chaining 47/23747/3
Paul Vinciguerra [Tue, 3 Dec 2019 03:38:00 +0000 (22:38 -0500)]
tests: add interface function chaining

Type: test

Change-Id: I24e740aa87a8a4061fa98740f2d636997e18f08d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agovom: get interface type from vpp device type 23/23123/4
Mohsin Kazmi [Wed, 30 Oct 2019 21:59:23 +0000 (22:59 +0100)]
vom: get interface type from vpp device type

Type: feature

Change-Id: Ia626188c22dc80c2b7a06b61cf0af435ee53d1e7
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agofib: Decouple source from priority and behaviour 77/23777/4
Neale Ranns [Wed, 4 Dec 2019 06:11:00 +0000 (06:11 +0000)]
fib: Decouple source from priority and behaviour

Type: feature

the fib_source_t enum alone no longer defines the priority and
behaviour, instead each source must be allocated these attributes.
This allows the creation of other sources by the plugins (and
soon over the API).

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I890ee820fbc16079ee417ea1fbc163192806e853

4 years agogre: Multi-point interfaces 68/20168/7
Neale Ranns [Thu, 18 Apr 2019 10:23:56 +0000 (10:23 +0000)]
gre: Multi-point interfaces

Type: feature

Change-Id: I0129ad6ace44a50a8a3b26db8e445cd06b2b49e8
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agobuild: Add Jon Loeliger as plugin/MAP maintainer. 96/23796/2
Jon Loeliger [Wed, 4 Dec 2019 17:14:49 +0000 (11:14 -0600)]
build: Add Jon Loeliger as plugin/MAP maintainer.

Change-Id: I2e25e6f9481afd7370bad4332906a2a7f0e78081
Type: make
Signed-off-by: Jon Loeliger <jdl@netgate.com>
4 years agomap: Fix a coverity MAP dead-code issue. 97/23797/2
Jon Loeliger [Wed, 4 Dec 2019 17:46:52 +0000 (11:46 -0600)]
map: Fix a coverity MAP dead-code issue.

Type: fix

Change-Id: I5467bbe3b25b1ea3fb44157abe6e7bfb3f191e77
Signed-off-by: Jon Loeliger <jdl@netgate.com>