Florin Coras [Wed, 3 Apr 2019 00:06:05 +0000 (17:06 -0700)]
session: do not enable pre-input node with 0 workers
Change-Id: I5c9e27b664ff1a8a74a6c1388f98af63571db7a5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Tue, 2 Apr 2019 11:53:26 +0000 (11:53 +0000)]
stat-segment: scaling improvement
don't walk the entire list of entries each time a new one is added
approximate/indicative numbers recorded on a VM:
after:
50000 tunnels in 1.124443 secs, 44466.45 tunnels/sec
before:
50000 tunnels in 5.202779 secs, 9610.25 tunnels/sec
Change-Id: Ie1155416be76f55f2a0a88360ce53e15aeace785
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Tue, 2 Apr 2019 17:17:48 +0000 (10:17 -0700)]
session: remove session logic from io rx evt sender
Change-Id: I54fff6986ea6455aff25e0cf1b83117860859e10
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 2 Apr 2019 18:38:51 +0000 (11:38 -0700)]
session: use app cb function wrappers
Change-Id: I77ad9eb4d4c7699397aa4be6a973ef37c60db4c5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Tue, 2 Apr 2019 17:06:50 +0000 (19:06 +0200)]
vppinfra: add u32x4 min / max sse4.2 inlines
Change-Id: I38e0be777199654ece286fdd1a42931ed99bbe8a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Mon, 1 Apr 2019 00:17:11 +0000 (17:17 -0700)]
tcp: improve rcv process ack processing
- Avoid doing cc in closing states.
- Rest connections closed with unread data
Change-Id: I97d46b0459f03ea5439eeb0f233b6c17d3e06dfd
Signed-off-by: Florin Coras <fcoras@cisco.com>
Filip Tehlar [Thu, 21 Mar 2019 12:56:59 +0000 (05:56 -0700)]
lisp: use crypto lib instead of openssl directly
Change-Id: I9667ed16939dede55b24959045737742d1c7c449
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Fri, 29 Mar 2019 20:23:58 +0000 (20:23 +0000)]
IPSEC-GRE; tests
failing test disabled on ARM
Change-Id: I6b7535cd8f51fdaf9786ba77f9f61a7d8d049bbd
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 2 Apr 2019 10:15:40 +0000 (10:15 +0000)]
IPSEC: tunnel scaling - don't stack the inbould SA
Change-Id: I0b47590400aebea09aa1b27de753be638e1ba870
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 2 Apr 2019 12:43:34 +0000 (05:43 -0700)]
IPSEC: remove pointless feature ordering
Change-Id: Ic1b657794d23cb4d1664fc749ad2468339e376df
Signed-off-by: Neale Ranns <nranns@cisco.com>
Matthew Smith [Mon, 1 Apr 2019 23:38:59 +0000 (18:38 -0500)]
dpdk: fix build error when mlx support enabled
When building with environment variables set to enable mlx PMD
support in DPDK, an error occurs:
CMake Error at plugins/dpdk/CMakeLists.txt:104 (vpp_plugin_find_library):
vpp_plugin_find_library Macro invoked with incorrect arguments for macro
named: vpp_plugin_find_library
Update a call to vpp_plugin_find_library() to include the right
number of parameters.
Change-Id: Ia0d66f93c6f94fdf822e2c3c4fe3f0ad01a90d57
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Andrew Yourtchenko [Thu, 28 Mar 2019 19:36:56 +0000 (20:36 +0100)]
vppinfra: fix sparse_vec_index() returning non-zero index for some nonexistent elements
If we are testing for an index whose membership bitmask happens to sit in LSB of uword,
and there is nothing else set in that uword in the member bitmask, the shortcut path
returning the valid index is taken even if the element with a given index doesn't
exist in the sparse vector. This happens because the count of leading zeroes on the
value of 0 is zero, which is equal to the value taken modulo bitsize uword.
Take care of that case.
Also add unittests showing the problem and verifying that sparse_vec_index2 does not
have the same issue.
Change-Id: I19117e13817c3e5de579b9250bb741de42491985
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Chenmin Sun [Thu, 28 Mar 2019 13:36:45 +0000 (21:36 +0800)]
dpdk 19.02: fixed speed capability error issue
Device speed capability should be specified based on different phy types
instead of a fixed value, this patch fix the issue.
Change-Id: Ia76231aefbcb0fe8370867b6e86a0d3bb9e169a0
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
John Lo [Mon, 1 Apr 2019 15:30:07 +0000 (11:30 -0400)]
Enhance vlib_buffer_clone to change headroom space for packet
Add function vlib_buffer_clone_at_offset() so that the cloned
packets' 1st buffer will have the original packet header copied
at the specified offset (instead of current_data). This can be
used to increase headroom in the cloned packet to allow large
header encaps in case the stdandard 128B predata is not enough.
The original vlib_buffer_clone() still works the same as before.
Change-Id: I3b50c8ad7e3952568bc141710567c99a3dacddce
Signed-off-by: John Lo <loj@cisco.com>
Dave Barach [Sat, 30 Mar 2019 14:24:28 +0000 (10:24 -0400)]
VPP-1576: fix a class of spurious warnings
Change-Id: I52198e97397bb6f3b5c0c30c44aac34c17650d4d
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Sat, 30 Mar 2019 11:56:37 +0000 (12:56 +0100)]
vppinfra: add few more cpuid flags
Change-Id: Ic2a61c45face18b6dd23d5509d75367d3b2441e9
Signed-off-by: Damjan Marion <damarion@cisco.com>
Igor Mikhailov (imichail) [Sat, 30 Mar 2019 02:25:15 +0000 (19:25 -0700)]
SPAN: Add pending frame on current thread, not on main
Previously, all frames were put for next node on the main thread,
even if the execution was happening on a worker thread.
Also, refactor to use API function vnet_get_main()
Change-Id: Ibefb1b3871563a78aa30352a37b9216537e15bf7
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
Dave Barach [Fri, 29 Mar 2019 23:41:50 +0000 (19:41 -0400)]
Convince Coverity that s = format (0, ...) is OK
Change-Id: Ia88c7228a46e251b8a7815240da6ddbbcde08bc7
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Barach [Fri, 29 Mar 2019 18:08:45 +0000 (14:08 -0400)]
Minor bug fixes
Drop the session reader lock across vlib_process_suspend(...) calls.
Fix the debug CLI command.
Change-Id: Ic0266dda1fdfa90971f2cb935248941317c01205
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Fri, 29 Mar 2019 20:22:09 +0000 (21:22 +0100)]
revert quicly related build/external changes
We dont't want git pull there, there is simple way to grab tarball
from github for every single commit
Change-Id: I7a98cab7660750e48084279d8b9892cdf229bceb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Tue, 19 Feb 2019 15:22:46 +0000 (15:22 +0000)]
IPSEC-GRE: fixes and API update to common types.
Change-Id: Icdcbac7453baa837a9c0c4a2401dff4a6aa6cba0
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Thu, 28 Mar 2019 20:07:00 +0000 (13:07 -0700)]
tests: test/vpp_l2.py fix missing name.
test/vpp_l2.py:213:26: F821 undefined name 'L2_VTR_OP'
self.itf.set_vtr(L2_VTR_OP.L2_DISABLED)
Move L2_VTR_OP enum to vpp_sub_interface.py where the VTR code is found.
Change-Id: I9eb9a3a2c679813c221ce1d0c4fa8aac6076c443
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Florin Coras [Fri, 29 Mar 2019 15:29:25 +0000 (08:29 -0700)]
vls: add pthread check on vls_attr
Change-Id: I455d108dfe52d45d040167fecb37b33e9d630c3c
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Thu, 28 Mar 2019 16:53:44 +0000 (09:53 -0700)]
tests: refactor vpp_object.py
Move __str__ to super for all subclasses of VppObject
Implement __repr__ in VppObject
Implement __hash__ and __eq__
Change-Id: Ibd4ea37b84b17f499ab86630fb5b9ed9c8b4b1c2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Nathan Skrzypczak [Tue, 19 Mar 2019 12:57:31 +0000 (13:57 +0100)]
Integrate first QUIC protocol implementation
Currently supports on single stream exposed through standard internal APIs
Based on libquicly & picotls by h2o
Change-Id: I7bc1ec0e399d1fb02bfd1da91aa7410076d08d14
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Neale Ranns [Fri, 29 Mar 2019 12:59:01 +0000 (05:59 -0700)]
VOM: recurive route update fix
Change-Id: Iff61904804d8218c4e02897521368f696002343d
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 29 Mar 2019 11:37:59 +0000 (11:37 +0000)]
BVI: coverity error fix
Change-Id: Idc1e1747035638777240b7ea9afcf675b22be7f1
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 29 Mar 2019 12:17:20 +0000 (08:17 -0400)]
Update MAINTAINERS
Change-Id: I1b041edb6f20a9f9c867fb243922985398485054
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Mon, 25 Mar 2019 14:54:40 +0000 (15:54 +0100)]
ipsec: esp-decrypt rework
Change-Id: Icf83c876d0880d1872b84e0a3d34be654b76149f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 28 Mar 2019 08:56:10 +0000 (08:56 +0000)]
IPSEC: tunnel fragmentation
Change-Id: I63741a22bc82f5f861e1c0f26a93b5569cc52061
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 28 Mar 2019 23:31:52 +0000 (16:31 -0700)]
tcp: remove sent rcv wnd 0 flag
Change-Id: If6c672d1caa8884eb5d819311606a79a3de81200
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matthew Smith [Wed, 27 Mar 2019 17:30:29 +0000 (12:30 -0500)]
dhcp: only register UDP ports that are needed
When configuring a DHCP client, both the UDP ports for DHCP client
and server are registered. Packets to the server port end up being
dropped unless you have also configured a DHCP proxy.
This breaks a common home/office gateway use case where the WAN
interface gets configured using a DHCP client and devices attached
to a LAN interface attempt to configure themselves using DHCP. If
you try to punt to an external DHCP daemon to handle the LAN client
requests, the packets never make it to the external daemon because
of the server port being registered.
Modify dhcp_maybe_register_udp_ports() to accept a parameter that
controls which ports get registered. For a DHCP client, only the
client port is registered. For a DHCP proxy, both client and server
ports are registered.
Change-Id: I2182d9827e4c7424b03ebb94952c3d2dc37abdb6
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Florin Coras [Thu, 28 Mar 2019 20:21:19 +0000 (13:21 -0700)]
tcp: improve updating of rcv wnd
Change-Id: I0b8a311979d3ccd15f3854e7ac44ca9951dc6ce4
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 22:34:56 +0000 (23:34 +0100)]
rdma: add option to specify inteface name
Change-Id: Ic6244511b88bdd42756f74e3163a70b8014e8547
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 20:40:48 +0000 (21:40 +0100)]
crypto: add vnet_crypto_op_init (...)
Change-Id: I2018d8367bb010e1ab30d9c7c23d9501fc38a2e5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 09:58:59 +0000 (10:58 +0100)]
ipsec: USE_EXTENDED_SEQ_NUM -> USE_ESN
Change-Id: Ib828ea5106f3ae280e4ce233f2462dee363580b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 19:54:47 +0000 (20:54 +0100)]
cmake: add vpp_plugin_find_library macro
Change-Id: I0b996460e05c40e74766563fb2a94c62a65063ce
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Fri, 28 Sep 2018 15:16:14 +0000 (15:16 +0000)]
Punt Infra
A punt/exception path that provides:
1) clients that use the infra
2) clients can create punt reasons
3) clients can register to recieve packets that are punted
for a given reason to be sent to the desired node.
4) nodes which punt packets fill in the {reason,protocol} of the
buffere (in the meta-data) and send to the new node "punt-dispatch"
5) punt-dispatch sends packets to the registered nodes or drops
Change-Id: Ia4f144337f1387cbe585b4f375d0842aefffcde5
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 18:19:31 +0000 (19:19 +0100)]
ipsec: anti-replay code cleanup
Change-Id: Ib73352d6be26d639a7f9d47ca0570a1248bff04a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 28 Mar 2019 15:34:25 +0000 (08:34 -0700)]
session: remove unused tx context field
Change-Id: I4a119937842eb188f5e5a7706cbe70e91ae4def8
Signed-off-by: Florin Coras <fcoras@cisco.com>
Benoît Ganne [Mon, 25 Mar 2019 10:41:34 +0000 (11:41 +0100)]
Add RDMA ibverb driver plugin
RDMA ibverb is a userspace API to efficiently rx/tx packets. This is an
initial, unoptimized driver targeting Mellanox cards.
Next steps should include batching, multiqueue and additional cards.
Change-Id: I0309c7a543f75f2f9317eaf63ca502ac7a093ef9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Thu, 28 Mar 2019 01:55:11 +0000 (18:55 -0700)]
session: cap max burst to a constant
Change-Id: I1919d3844936486f04f2bfde24dc7e0d9121927a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Thu, 28 Mar 2019 15:19:24 +0000 (16:19 +0100)]
Avoid overwrite in clib_memcpy_le{32,64}
Change-Id: Id4a8b6a31fc3e88af2f075cb97c85d3f9b738d9e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 28 Mar 2019 15:01:47 +0000 (08:01 -0700)]
VXLAN-GBP: format flags in encap trace
Change-Id: I561fd187b4865345f3bff86b3d6e67b0f0e97557
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 28 Mar 2019 15:39:01 +0000 (08:39 -0700)]
tcp: remove unused buffer flags
Change-Id: I86e71f32dee3cc48f680e6432a96caef0a7f66a1
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Wed, 27 Mar 2019 13:40:35 +0000 (13:40 +0000)]
IPSEC: 4o6 and 6o4 for tunnel interfaces
Change-Id: I4d3ba18ab5205317219989de55b6e50d3b1d8a79
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Thu, 28 Mar 2019 08:59:12 +0000 (08:59 +0000)]
IPSEC: fix build breakage from ships in the night merges
Change-Id: Iec7da9adc970d005cd7d3d42839b5e51b0b5f5c3
Signed-off-by: Neale Ranns <nranns@cisco.com>
ezkexma [Tue, 26 Mar 2019 14:24:38 +0000 (10:24 -0400)]
vat:ignore SIGWINCH signal
vpp/src/vat/main.c
When change the window size,the vat will get the SIGWINCH signal and then exit.
It is not a exit action,so we can ignore it.
Change-Id: If796762216910e23cace09406d413331f505d990
Signed-off-by: ezkexma <maqi.z.ke@ericsson.com>
Dave Barach [Sun, 24 Mar 2019 20:25:03 +0000 (16:25 -0400)]
AppImage packaging
Disabled by default. To kick the the tires:
wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
sudo mv linuxdeploy-x86_64.AppImage /usr/local/bin/linuxdeploy
sudo chmod +x linuxdeploy-x86_64.AppImage
Enable VPP_BUILD_APPIMAGE e.g. in ccmake
make build | make build-release
The vpp AppImage lands in .../install-xxx-native/VPP-x86_64.AppImage. To run it:
./VPP-x86_64.AppImage vpp unix interactive
To run it (as root) and inhale the usual startup.conf:
sudo ./VPP-x86_64.AppImage \${HERE}/bin/vpp -c \${HERE}/etc/vpp/startup.conf
To run vppctl, or any of the usual vpp binaries:
./VPP-x86_64.AppImage vppctl [etc]
Change-Id: Ide8cf4658cbb56f1d36a1ce7fc8f7338f8d38278
Signed-off-by: Dave Barach <dave@barachs.net>
Neale Ranns [Fri, 22 Mar 2019 08:12:48 +0000 (08:12 +0000)]
IPSEC: run encrpyt as a feautre on the tunnel
Change-Id: I6527e3fd8bbbca2d5f728621fc66b3856b39d505
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Wed, 27 Mar 2019 18:25:48 +0000 (11:25 -0700)]
Typos. A bunch of typos I've been collecting.
Change-Id: I53ab8d17914e6563110354e4052109ac02bf8f3b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Naveen Joy [Wed, 27 Mar 2019 21:28:50 +0000 (14:28 -0700)]
make-test: fix ValueError raised by hook in python3
Without this patch, the hook module raises a ValueError
when tests are run using python3. This patch updates the
exception being caught by ipaddress to ValueError.
Change-Id: I5e11e292a05ddf350fc04ebaf19cfd7dad2bd9d0
Signed-off-by: Naveen Joy <najoy@cisco.com>
Neale Ranns [Wed, 27 Mar 2019 12:32:03 +0000 (05:32 -0700)]
VOM: routes support multipath so set is_multipath in route update
Change-Id: Ib0249aec00c8a8306f2cf25394d39b4b7850d8f7
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Wed, 27 Mar 2019 12:06:47 +0000 (05:06 -0700)]
GBP: fixes for l3-out routing
Change-Id: I4d73b712da911588d511a8401b73cdc3c66346fe
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Tue, 26 Mar 2019 12:16:42 +0000 (13:16 +0100)]
ipsec: compress ipsec_sa_t so data used by dataplane code fits in cacheline
Change-Id: I81ecdf9fdcfcb017117b47dc031f93208e004d7c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Tue, 26 Mar 2019 21:05:38 +0000 (14:05 -0700)]
tcp: add cc algo lookup table
Change-Id: Ie7be0136c182cdc35193e47dd3249153c2f8d65e
Signed-off-by: Florin Coras <fcoras@cisco.com>
Mohsin Kazmi [Mon, 25 Mar 2019 15:41:01 +0000 (16:41 +0100)]
vom: Add support for BVI interface
Change-Id: Ie93f3a2107df0452f7a7436b78c337f482904899
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Tue, 26 Mar 2019 14:25:11 +0000 (07:25 -0700)]
FIB: do debug before remvoing last source
Change-Id: I4e1cde754eb4d6406cd6cd51f37d89552bdb6a53
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 26 Mar 2019 15:54:32 +0000 (08:54 -0700)]
GBP: missing L3-out type coversion
Change-Id: Ic6455a930fcb21b055bcf093359bc8328f88140a
Signed-off-by: Neale Ranns <nranns@cisco.com>
Benoît Ganne [Tue, 26 Mar 2019 09:27:57 +0000 (10:27 +0100)]
Add missing OpenSUSE Leap 15.0 build deps
Fresh OpenSUSE Leap 15.0 containers are missing build dependencies.
Change-Id: I9b62f36c658862d8f32db5547d2176e6f56df4ea
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Neale Ranns [Tue, 26 Mar 2019 07:02:58 +0000 (07:02 +0000)]
ADJ: midchain delegate to performing stacking
this can be used by e.g. tunnels so it doesn't need to be
implemented for each tunnel type.
Change-Id: I0790f89aa49f83421612b35108cce67693285999
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 26 Mar 2019 08:21:25 +0000 (08:21 +0000)]
IPSEC: more expressive API errors
Change-Id: I517a7bdae03abfea58451819e7854974397d77f8
Signed-off-by: Neale Ranns <nranns@cisco.com>
Kingwel Xie [Mon, 11 Mar 2019 07:53:48 +0000 (03:53 -0400)]
node: vector must be checked with vec_header
see register_node, node-name might be a vector
Change-Id: I883ec51c1fa9aa4da4ba6cba415a39bb6a4331e1
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Paul Vinciguerra [Wed, 20 Mar 2019 01:58:35 +0000 (18:58 -0700)]
VPP-1508: Tests: Update version of syslog_rfc5424_parser.
Bump to version v0.3.1.
Fixes an issue with stdlib enum imports under python3.5.
Change-Id: I7d8cb9e8ae9321beb4cb2ba052b08e776590c75d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Filip Tehlar [Mon, 25 Mar 2019 16:04:41 +0000 (09:04 -0700)]
crypto: add set crypto handler CLI
Change-Id: I40124f8d6e529256b1ccc6eb78dda9c5119b8951
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Su Wang [Thu, 21 Mar 2019 04:14:14 +0000 (00:14 -0400)]
perfmon: fix pmc hw indices out-dated when multiple pmc
When adding two or more events using a single "set pmc",
the pmc hardware indices might be out-dated due to kernel
reschdeduling the perf_event hardware counters.
E.g. set pmc cpu-cycles cache-misses
Solution:
Open and enable all the events first, then aquire the
indices from the kernel.
Change-Id: I6913a871ab169e3b2855ac6159f527a1fca343e9
Signed-off-by: Su Wang <su.z.wang@ericsson.com>
Kingwel Xie [Wed, 20 Mar 2019 07:45:47 +0000 (03:45 -0400)]
ip6-rewrite: bug fix buffer->error in dual loop
error should be recorded in buffer so that
process-error-punt can handle them correctly
Per Damjan's comments, move counter to under
else clause of last error0==NONE check. Both
v4 and v6 are changed.
Change-Id: I707c7877ccb12589337155173fc4a5200b42ee93
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Damjan Marion [Tue, 19 Mar 2019 14:38:40 +0000 (15:38 +0100)]
ipsec: esp-encrypt rework
Change-Id: Ibe7f806b9d600994e83c9f1be526fdb0a1ef1833
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Fri, 1 Mar 2019 13:19:55 +0000 (14:19 +0100)]
Convert GRE nodes to new buffer APIs and multiarch
Change-Id: I3b3c8333287bb704ac7b0bbc81b3dbb059e8d2ac
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Fri, 1 Mar 2019 13:14:10 +0000 (14:14 +0100)]
Simplify adjacency rewrite code
Using memcpy instead of complex specific copy logic. This simplify
the implementation and also improve perf slightly.
Also move adjacency data from tail to head of buffer, which improves
cache locality (header and data share the same cacheline)
Finally, fix VxLAN which used to workaround vnet_rewrite logic.
Change-Id: I770ddad9846f7ee505aa99ad417e6a61d5cbbefa
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Neale Ranns [Tue, 26 Mar 2019 08:26:39 +0000 (08:26 +0000)]
IPSEC: improved policy delete
Change-Id: Icdf51b094c34725c079d2e4acbb955744434302d
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Wallace [Mon, 25 Mar 2019 23:34:50 +0000 (19:34 -0400)]
VCL: add TLS opt to socket_test.sh
- add TLS transport opt to socket_test.sh
- resolve clash in vcl_test* args with
socket_test.sh opts
Change-Id: I952d5b64942664bc3af1098f67445e0f4b93ab32
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Florin Coras [Mon, 25 Mar 2019 15:30:53 +0000 (08:30 -0700)]
tls: make first segment and fifo size configurable
Change-Id: I6169ebdd3ac2d5d77fd2e12068c8aab6d8072c03
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Thu, 21 Mar 2019 14:34:09 +0000 (14:34 +0000)]
IPSEC tests fnd fix or Extended Sequence Numbers
Change-Id: Iad6c4b867961ec8036110a4e15a829ddb93193ed
Signed-off-by: Neale Ranns <nranns@cisco.com>
Aloys Augustin [Mon, 25 Mar 2019 10:29:17 +0000 (11:29 +0100)]
UDP: Fix session registration in lookup table
This fixes a bug where packets could be sent but not received when opening an UDP connection.
Change-Id: I0993dd806b277374232d551167970ab13a62dbf9
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
ezkexma [Thu, 21 Mar 2019 11:38:19 +0000 (07:38 -0400)]
add api trace print
/vpp/src/vlibapi/api_shared.c
after "set api-trace debug on",api trace will be print ontime when clients send msg to vpp.
Change-Id: Ib2e504afb9e674c5cdfa6dc5c522c7af0396d687
Signed-off-by: ezkexma <maqi.z.ke@ericsson.com>
Nathan Skrzypczak [Mon, 25 Mar 2019 09:20:56 +0000 (10:20 +0100)]
Fix unformat proto UDPC / UDP conflict
Change-Id: I9161959536c37f6f730650c9c0058a41af8e7001
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Mohsin Kazmi [Tue, 12 Mar 2019 15:40:47 +0000 (16:40 +0100)]
vxlan-gbp: Add api custom-dump
Change-Id: I1cb391c56463a770d874b2bfc8a0b7f6909ba55a
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Florin Coras [Fri, 22 Mar 2019 22:42:18 +0000 (15:42 -0700)]
tcp: make default mtu configurable
Change-Id: I56d8d8d67d5590e24c1ddb54b0c63a2cb03798e1
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Fri, 22 Mar 2019 19:49:45 +0000 (15:49 -0400)]
DOC-ONLY: improve multi-arch documentation
Document CLIB_MARCH_FN and CLIB_MARCH_FN_SELECT
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I661ba2af79db8205d70fa87203d40a2e31b795e4
Andrew Yourtchenko [Wed, 20 Mar 2019 16:47:03 +0000 (17:47 +0100)]
acl-plugin: get rid of doubly-linked list fields in hash applied ACEs
With collision match vector, the doubly-linked list is not needed anymore.
Change-Id: Iaf667ebe6ce0bdd78306bec31d3949e6acb8d401
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Andrew Yourtchenko [Wed, 20 Mar 2019 16:44:14 +0000 (17:44 +0100)]
acl-plugin: tuplemerge: fix a crash during soak test with split partition
Reload the hash-ready ACE vector pointer during the partition split
with each iteration, since the ACL# may change.
Change-Id: I1b001e06b52ff02ef59ca1d890f8462ca99e6634
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Andrew Yourtchenko [Wed, 20 Mar 2019 10:11:19 +0000 (11:11 +0100)]
acl-plugin: get rid of a separate "count" field in the linear acl struct
Long time ago, the linear array of rules in the ACL structure was not
a vector. Now it is, so get rid of the extraneous "count" member.
Do so in a manner that would ease potential the MP-safe manipulation of
ACL rules in the future.
Change-Id: Ib9c0731e4f21723c9ec4d7f00c3e5ead8e1e97bd
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Filip Tehlar [Wed, 20 Mar 2019 09:43:20 +0000 (02:43 -0700)]
crypto: implement rfc4231 test cases
Change-Id: I540241672a20f687d20bb70adbf2b33200f34167
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Damjan Marion [Fri, 22 Mar 2019 12:58:08 +0000 (13:58 +0100)]
ipv6: vectorized ext header check
Change-Id: I454bb01153d1d0536c4a6fe36103e7721aad8cd1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 14 Mar 2019 16:21:02 +0000 (09:21 -0700)]
ADJ: more thorough link up check
Change-Id: I04dbfb914706b25fcc3bd6ee0d19cfdc810234ae
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Wed, 13 Mar 2019 01:58:54 +0000 (18:58 -0700)]
tcp: improve handling of snd_nxt
- avoid changing snd_nxt when doing fast retransmits
- use snd_una_max only to keep track of the max seq number sent
- simplify future ack testing
Change-Id: I3580ad3aefe30128486c3375d0ac3f3f62c04c5e
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 22 Mar 2019 04:17:43 +0000 (21:17 -0700)]
svm/atomics: add clib_atomic_swap_rel_n
Change-Id: Iea2c173000570043beafef58ca923463ce76d872
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Fri, 22 Mar 2019 12:50:29 +0000 (08:50 -0400)]
add a "make test-gcov" target
add a line to "make help"
Change-Id: I94c9e54832e959f35ee28adc1b37091c1473f687
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Wed, 20 Mar 2019 15:30:54 +0000 (16:30 +0100)]
ipsec: fix esn handling
Change-Id: I27f24095309082363ba0d0ba4bd69e2c0741dc1c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 21 Mar 2019 16:36:28 +0000 (16:36 +0000)]
IPSEC: test for packet drop on sequence number wrap
Change-Id: Id546c56a4904d13d4278055f3c5a5e4548e2efd0
Signed-off-by: Neale Ranns <nranns@cisco.com>
Hyong Youb Kim [Thu, 21 Mar 2019 15:33:28 +0000 (08:33 -0700)]
dpdk: do not enable VLAN stripping on Cisco VIC adapters by default
With the following local patch, VIC adapters remove default vlan tags
from ingress packets. So, it is no longer necessary to enable VLAN
stripping by default. This change also allows VLAN sub interfaces to
work with VIC adapters.
patches/dpdk_19.02/0001-net-enic-untag-default-vlan-by-default.patch
Change-Id: I2e7d62c62120c351c27d827d90de4a8335efa044
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Hyong Youb Kim [Thu, 21 Mar 2019 15:21:26 +0000 (08:21 -0700)]
dpdk: add ENIC PMD patch to untag default vlan
The ingress vlan rewrite mode affects the vlan header of ingress
packet. The enic driver currently uses the 'passthrough' mode, which
leaves the vlan header intact. As all packets in UCS network are
tagged, this default mode leads to tagged ingress packets in the
following cases where VPP expects untagged packets.
1. Trunk-mode vNIC on UCS standalone server.
A remote device sends an untagged packet to the server. This packet is
ultimately tagged with vlan 0 as it reaches the driver, and VPP sees
an ingress packet tagged with vlan 0.
2. Access-mode vNIC on UCS blade or standalone server.
A remote device sends a packet on the vNIC's default vlan (e.g. 200)
to the server. This tag is untouched, and VPP sees an ingress packet
tagged with the default vlan (e.g. 200).
In both cases, VPP expects to see untagged packets. To work around the
issue, VPP currently enables vlan stripping on VIC interfaces, which
breaks vlan sub-interface features.
To avoid the current workaround, use the "untag default vlan" rewrite
mode. With this mode, the VIC adapter removes the vlan header if it
matches the default vlan. In the cases described above, VPP would see
untagged packets. Packets tagged with non-default vlan (e.g. non-0 for
case 1 and non-200 for case 2) are received with their tags intact, so
VPP sees tagged packets as expected.
The driver currently has no programmatic way to change the rewrite
mode after rte_eal_init. So use this patch to change the mode for the
time being.
Change-Id: Iff6408275363ed52d6016e7516d745214d6b30d4
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Andrew Yourtchenko [Tue, 19 Mar 2019 13:52:29 +0000 (14:52 +0100)]
vppapigen: allow for enum size other than u32
Change-Id: If20d2fbab9b854b7db276c81918fdff6abcb8385
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Paul Vinciguerra [Tue, 19 Mar 2019 18:54:39 +0000 (11:54 -0700)]
tests: update test_lb.py to use api call lb_conf.
Change-Id: I96a1d4b2b3ae22cf164c0acd6db9b323cd70f51a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Jon Loeliger [Thu, 21 Mar 2019 15:57:51 +0000 (10:57 -0500)]
MAP: Crush Coverity Complaint
Change-Id: I965229f5bf8fcde9176357536a23ba8056542919
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Dave Barach [Thu, 21 Mar 2019 22:01:48 +0000 (18:01 -0400)]
Ignore SIGTERM during the vpp boot sequence
Call setjmp and mark the setjmp context valid just prior to entering the
vpp main loop.
Change-Id: I26d5cd6a624cb2a497d81eb85a62365621b3b469
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Thu, 21 Mar 2019 06:16:15 +0000 (23:16 -0700)]
vec: use memset in vec_resize_allocate_memory
Change-Id: I0ed28846060a774b1f6cdc1e4e5974a7e16f9f16
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 21 Mar 2019 20:54:53 +0000 (13:54 -0700)]
session/fifo: make event unset atomic
Ensures that fifo cursize loads cannot be speculated to before the event
unset.
Change-Id: Ia7c20c510d58f26a8e9b82d3982c6d4143a3a4d6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Fri, 15 Mar 2019 09:16:20 +0000 (02:16 -0700)]
BVI Interface
a new dedicated BVI interface as opposed to [re]using a loopback.
benefits:
- removes ambiguity over the purpose of a loopback interface
- TX node dedicated to BVI only functions.
Change-Id: I749d6b38440d450ac5b909a28053c75ec9df946a
Signed-off-by: Neale Ranns <nranns@cisco.com>