Michal Cmarada [Thu, 24 Jan 2019 08:34:23 +0000 (09:34 +0100)]
Honeycomb 1.19.01-RC1
Change-Id: Ide7d955084f224e63d644a0e11299e01d3c7e9b5
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Wed, 23 Jan 2019 15:24:45 +0000 (16:24 +0100)]
Release notes: set <project-branch> to stable/1901
Change-Id: Ia85b5fd1352374ff6f9d73dd04a2544db1f576c6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Wed, 23 Jan 2019 15:08:12 +0000 (16:08 +0100)]
Set stable/1901 as default branch for gitreview
Change-Id: I65c77258bbc4bae45eaa864705a240a219832f05
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Thu, 18 Oct 2018 11:21:49 +0000 (13:21 +0200)]
Release notes: update jira project version for 1.19.01
Change-Id: I6e0820df7bc654f7847c517930c98599624dd288
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Thu, 18 Oct 2018 10:31:53 +0000 (12:31 +0200)]
Bump honeycomb version to 1.19.01-SNAPSHOT
Change-Id: Ic3e48d39d570632743c66b9317cd638fba84a34f
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Mon, 8 Oct 2018 07:51:04 +0000 (09:51 +0200)]
HONEYCOMB-431: add support for <validate> RPC
This patch introduces ValidableTransaction interface,
used by Honeycomb's DataBroker to implement
Netconf's DOMDataTransactionValidator.
WriteTransaction implements ValidableTransaction
by delegating validate to DataModification
for both config and operational modifications.
This patch requires ODL Fluorine (HONEYCOMB-433),
which brings support for <candidate> validation to Netconf.
Alternatively custom ODL Oxygen build
with patches from stable/oxygen/oxygen-hc-improvements.
Change-Id: Ic3eaffaef0314d22da3ea37f9416f18ccb0b99ae
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Michal Cmarada [Tue, 25 Sep 2018 09:15:35 +0000 (11:15 +0200)]
Bump ODL dependencies to Fluorine (HONEYCOMB-433)
Change-Id: I142ebd2899272feff00abe7d4bae708f093ee3ec
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
Vanessa Rene Valderrama [Fri, 24 Aug 2018 20:08:27 +0000 (15:08 -0500)]
Add INFO.yaml file
Add INFO.yaml to list:
- Project description
- Properties
- Issue Tracking
- Contacts
- PTL information
- Meeting information
- Committer information
Change-Id: Ibe3fae589600784d98880e017e54c66a34d0c2e3
Signed-off-by: Vanessa Rene Valderrama <vvalderrama@linuxfoundation.org>
Marek Gradzki [Fri, 24 Aug 2018 06:22:32 +0000 (08:22 +0200)]
Remove redundant ReadFailedException from Reader.isPresent
Change-Id: Ia64b0869d1f2d9620d233f31077e72d887ef4716
Signed-off-by: Marek Gradzki <margradz@gmail.com>
Marek Gradzki [Thu, 23 Aug 2018 06:24:00 +0000 (08:24 +0200)]
Make Validator.validateXXX methods optional
Some of the writers do not support update,
also write/delete might not require validation.
Therefore, in order to reduce amount of boilerplate code,
make validateXXX methods default with empty implementation.
Change-Id: Id205b478900024c59834a6e6cb18bdbeb9b43792
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 21 Aug 2018 07:01:37 +0000 (09:01 +0200)]
Mark improvements with TODO instead of FIXME
Sonar reports FIXMES as issues with higher priority as TODOs.
FIXMEs should only be used for known bugs,
not for improvements.
Also include JIRA issue ID in the TODO message.
Change-Id: I47461d948421ff17532f17ecec3ddae84239511f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 21 Aug 2018 06:52:12 +0000 (08:52 +0200)]
RWUtils: move fields to comply with Java Code Conventions
Change-Id: I2ab95afb733885b3034dfc6a8cbad795fbf5ba6c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 9 Aug 2018 08:07:36 +0000 (10:07 +0200)]
AbstractGenericWriter: remove xxxCurrent methods
Use xxxCurrentAttributes instead to simplify call graph.
Change-Id: I8201b115354dddd35ca0b63b2c72dfb4eac93646
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)]
HONEYCOMB-431: add validation support to Writers
This patch introduces FlatWriterRegistry.validateModifications.
Implementation iterates over writersOrder following bulkUpdate logic
to properly support subtree writers case.
Writers are now cabable of validating modifications.
Commonly used implementations (GenericWriter and GenericListWriter)
delegate validation capbility to Validators.
Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)]
HONEYCOMB-431: delegate DataModification.validate to WriterRegistry
This patch introduces ModifiableDataTreeDelegator.validateCandidate
that translates DataTreeCandidate to DataObjectUpdates
and delegates validation to WriterRegistry (similarly as for bulk update).
ModifiableDataTreeManager.commit implementation
invokes validation before bulk update.
To make it efficient, DataObjectUpdates are computed once
and stored in DataTreeContext.
Change-Id: If4bd558e64ed84c11c9c50c7a98a2aaa8db841bb
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)]
HONEYCOMB-431: make DataModification.validate idempotent
This patch modifies contract of DataModification.validate
to make it idempotent.
ModifiableDataTreeManager.validate now invokes dataTree.validate
on a copy of DataTreeModification.
ModifiableDataTreeManager.validateCandidate was introduced
to allow additional validation.
Change-Id: I86fc101faff9b04afde2f3eb16fff4d4df2867ad
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 13 Aug 2018 05:36:22 +0000 (07:36 +0200)]
Hide ResourceLoader.ResourceLoaderIml's constructor
Fixes issue reported by Sonar.
Change-Id: Ibf9bc89ee09f151a56766213714829abdb7012bb
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 13 Aug 2018 05:30:20 +0000 (07:30 +0200)]
Hide TranslationUtil's constructor
Utility classes should not be instantiated.
Change-Id: Iff821556ad6b593bce6b3e056241dc7e2bbe0c8b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 13 Aug 2018 05:00:16 +0000 (07:00 +0200)]
Bump maven-sonar-plugin version to 3.4.1.1170
Change-Id: Ic490d8b850fcd270ff49e1c682f40c0324afe3d6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Michal Cmarada [Fri, 10 Aug 2018 13:09:12 +0000 (15:09 +0200)]
remove obsolete HoneycombDOMBrokerProvider
this was used a while ago when we were using ODL dependencies with
config subsystem. Once ODL moved to Blueprint this become obsolete.
Several classes used in this provider are marked deprecated and are
removed in ODL Fluorine.
Change-Id: I5bd415a271a9d53ad40f785bdc3840c410f79249
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
Marek Gradzki [Fri, 8 Jun 2018 04:48:10 +0000 (06:48 +0200)]
HONEYCOMB-440: bump ODL dependencies to Oxygen-SR3
Change-Id: Ib178651a07b55f7e732a45751c31b678296b2083
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 9 Aug 2018 07:50:14 +0000 (09:50 +0200)]
Rename TestValidate to EditConfigTest
The test does not use <validate> RPC
in contrast to ValidateTest from:
https://gerrit.fd.io/r/#/c/14040/
Change-Id: I57da44256515cf10afbd86ef7d7b1607caa3f52e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 6 Aug 2018 06:56:14 +0000 (08:56 +0200)]
javadoc: add missing <name> in pom files
Change-Id: I2bed263c71b38e28706cb869232482b951158fd1
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 6 Aug 2018 06:16:48 +0000 (08:16 +0200)]
HoneycombDOMRpcService: remove unnecessary cast to Function
Fixes issue reported by Sonar.
Change-Id: I083eb089f1ccd691a2015eaa401fe5acf7c59d49
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 6 Aug 2018 06:24:21 +0000 (08:24 +0200)]
RWUtils: use lambdas instead of anonymous inner classes
Change-Id: Ie17b819efd381983754065a821771eb3aac11d06
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 3 Aug 2018 19:00:37 +0000 (21:00 +0200)]
Do not use FQN of DataBroker in ModifiableDataTreeDelegator
Change-Id: I5944e9fd9388fbc533bf909b171b0672d798ad82
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 31 Jul 2018 16:12:21 +0000 (18:12 +0200)]
Remove code repetitions from GenericListWriter
Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 20 Jul 2018 07:03:51 +0000 (09:03 +0200)]
Relese notes: update jira project version for 1.18.10
Change-Id: I02b4f5948ae8818412d1ae0f7b3e1ac4acd55726
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 20 Jul 2018 06:54:26 +0000 (08:54 +0200)]
Bump honeycomb version to 1.18.10-SNAPSHOT
Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 27 Jun 2018 19:33:28 +0000 (21:33 +0200)]
Register sutdown handler for Restconf server before start
Change-Id: I25a22a194048637ea72dd35767e1e1701b5723e4
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 27 Jun 2018 19:23:47 +0000 (21:23 +0200)]
DelegatingRewriteDeleteProducer: remove useles instanceof check
DataContainerNode is DataContainerChild.
Change-Id: I9122f9f3c27951f2d498f714d2ea15ebc96abdf3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 27 Jun 2018 19:03:03 +0000 (21:03 +0200)]
bgp: mark parameters of RouteWriter @NonNull
The RouteWriter interface is used by LocRibChangeListener, which
never passes null parameters.
Change-Id: I33a775de6c67d24bc271c0af21c9634c661e85e9
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 21 Jun 2018 09:44:03 +0000 (11:44 +0200)]
Cleanup WriterCustomizer
Change-Id: Ied63ccd3fbc7e645ba3fa2db16528b3209319fa7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 7 Jun 2018 10:34:43 +0000 (12:34 +0200)]
HONEYCOMB-439: bump ODL dependencies to Oxygen-SR2
Change-Id: I76cc110ac7e0a64cdad79a7614f9e8b5eb624428
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 11 Jun 2018 17:02:21 +0000 (19:02 +0200)]
ModifiableDataTreeManager: remove redundant non-default constructor
Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)]
WriteTransaction: make sure TransactionCommitFailedException is thrown
DataTreeModification.ready() used by DataModification.validate()
might throw IllegalArgumentException in case of missing mandatory nodes.
Use broader Exception type in WriteTransaction.submit()
to make sure contract defined by AsyncWriteTransaction is preserved.
Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 7 Jun 2018 10:30:47 +0000 (12:30 +0200)]
Bump odl.yang-binding version from 0.12.0 to 0.12.1
Change-Id: I37c247279c37c3fb066186c8390e827a9611b99e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 27 Apr 2018 09:31:47 +0000 (11:31 +0200)]
HONEYCOMB-432: bump ODL dependencies to Oxygen-SR1
Change-Id: Ibf01bcaf65bb048fcfae57b5ba0597faff5e4fe6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 16 May 2018 06:16:02 +0000 (08:16 +0200)]
Invoke CapabilityChangeNotificationProducer.close on shutdown
Also fixes Sonar warning regarding
useless CapabilityChangeNotificationProducer instantiation.
Change-Id: I376b834618d34f13615051abf622e6b12e031050
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 16 May 2018 08:30:28 +0000 (10:30 +0200)]
HONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributes
ReflexiveListReaderCustomizer used default NOOP implementation,
which caused issues during serialization, because
BindingNormalizedNodeCodecRegistry.toNormalizedNode requrires key to be set.
Change-Id: I7822e07efe57cbdee2c539583776f8cc677ddab7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 27 Apr 2018 19:26:37 +0000 (21:26 +0200)]
javadoc: add missing <name> in pom files
Change-Id: I3d65b568c3651e4b2474c25bdf80cf3fff416360
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 27 Apr 2018 19:07:32 +0000 (21:07 +0200)]
bgp-extensions: fix ODL BGP links in javadoc
Change-Id: I84b338774c8175a7e59f03db3b81297607df0141
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Maros Marsalek [Wed, 25 Apr 2018 08:20:59 +0000 (10:20 +0200)]
Collect all the updates for subtree writers
So far, when a subtree writer was registered on a list node
and ModificationDiff detected 2 or more updated list items for that writer,
FlatWriterRegistry just picked the first item in list, processed that one
and ignored the rest.
Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728
Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
Marek Gradzki [Mon, 16 Apr 2018 13:28:27 +0000 (15:28 +0200)]
WriteTransaction: log exception with error level when submit fails
Change-Id: Ibc269946c08702805531a62c40be295fecc6b4ce
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 10 Apr 2018 05:10:53 +0000 (07:10 +0200)]
Fix various Sonar warnings
Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 9 Apr 2018 14:06:38 +0000 (16:06 +0200)]
release notes: set ODL project branch to stable-oxygen
Change-Id: I03b48e387d370a4e264fb8bf4e3b22a03656fbba
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 9 Apr 2018 14:05:31 +0000 (16:05 +0200)]
Update jira project version in relese notes for 1.18.07
Change-Id: Ie86c53f0c5922704ea7cbb3e29ee258e53c2cc70
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 9 Apr 2018 14:00:33 +0000 (16:00 +0200)]
Bump Honeycomb version to 1.18.07-SNAPSHOT
Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 4 Jan 2018 06:08:34 +0000 (07:08 +0100)]
HONEYCOMB-424: bump ODL dependencies to Oxygen
Change-Id: I3160e5df4e66b3b3c732619fc1fc7599459fda76
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 19:34:47 +0000 (20:34 +0100)]
Fix Netconf TCP server shutdown
Change-Id: I0c74799a7249777c3258be915e9a95836fe0265e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 14:25:17 +0000 (15:25 +0100)]
ShutdownHandlerImpl: remove registered components after shutdown is performed
Prevents invoking AutoCloseable.close(), which might not be idempotent.
Change-Id: Id28200fb68a4c6e38878cf4f0b8aaee298dbc37b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 14:03:35 +0000 (15:03 +0100)]
Fix Restconf server shutdown
Change-Id: Ia7c0fc2d269ae88170297ef22476c8a61121238a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 13:51:18 +0000 (14:51 +0100)]
Move shutdown hook registration to dedicated provider
This change would allow using ShutdownHandlerImpl in integration tests.
Change-Id: I854f65d03b9e1a495fda7211fd1b7fd51b4e5ba3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 10:02:29 +0000 (11:02 +0100)]
Fix handling of RPCs that do not produce a result
The output statement of RPC operation is optional.
In such cases DefaultDOMRpcResult should be initialized with null result.
Change-Id: Ia832e480b3c72607b3636493bc044a9144f247be
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 7 Mar 2018 06:15:53 +0000 (07:15 +0100)]
Post HONEYCOMB-161 cleanup
Change-Id: I46652c9f109a6ede60cfb3143d945fe8b6f1f042
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 4 Jan 2018 06:08:34 +0000 (07:08 +0100)]
HONEYCOMB-418: Bump ODL dependencies from Nitrogen SR1 to Nitrogen SR2
Change-Id: I98f73e0cce217202e8c335b1fa06f1b3fc8bce05
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 2 Feb 2018 10:38:06 +0000 (11:38 +0100)]
Use XMLStreamNormalizedNodeStreamWriter from yang-data-codec-xml
instead of old and deprecated version from yang-data-impl.
Change-Id: If3f9dbffe83cdde29d2f4996dbd299a60bab90a9
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 2 Feb 2018 10:10:36 +0000 (11:10 +0100)]
Use YangParserTestUtils instead of CrossSourceStatementReactor.BuildAction
Simplifies code and removes usages of deprecated YangStatementSourceImpl.
Change-Id: I012e2de7a5a902927eaec87370f1850d54fbf4ee
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 2 Feb 2018 09:48:33 +0000 (10:48 +0100)]
Remove usages of deprecated BindingNormalizedNodeSerializer from yantools
Use mdsal version:
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer
instead of
org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer
Change-Id: Idfb977acee95de40183d4574565c46ac9ab54a27
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 2 Feb 2018 09:39:43 +0000 (10:39 +0100)]
Fix revision of hc-aug-test.yang
Change-Id: I1ca0e255c1467af31a39eb515c9cd4e7b4a4948a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Fri, 2 Feb 2018 09:36:29 +0000 (10:36 +0100)]
Improve error messages in distro tests
Change-Id: Ie0bc2e2add7940cb8f0ce2d5e4ea41d1e1c9d991
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 31 Jan 2018 06:43:02 +0000 (07:43 +0100)]
Update project-odl-branch property to match ODL version used
Change-Id: I2a036037245be07d2cd452a8036374967ca7622c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 30 Jan 2018 09:35:11 +0000 (10:35 +0100)]
HONEYCOMB-414: use NetconfNorthboundSshServer for NETCONF initialization
instead of rewriting it in HC.
Change-Id: Id2b5cb1b7bcd38728721ce92a7b5dbe1d919731c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 17 Jan 2018 07:56:09 +0000 (08:56 +0100)]
Integration test for SubtreeWriter update
Change-Id: Ic8d2cd524ea2d22859df28cb48aa41d5539efbee
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 16 Jan 2018 12:59:41 +0000 (13:59 +0100)]
Improve integration tests for SubtreeWriter
Change-Id: I20209b800eaa892e0fb742066003e956d00bbb22
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 10 Jan 2018 12:41:32 +0000 (13:41 +0100)]
Update jira project version in relese notes for 1.18.04
Change-Id: Ieb60319ad575c38e7539cf8d0c58d62e71a29387
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 9 Jan 2018 15:50:59 +0000 (16:50 +0100)]
Bump honeycomb version to 1.18.04-SNAPSHOT
Change-Id: Idb0fec8ab45ec76431ab6d05d70a61eee1929628
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 9 Jan 2018 13:11:26 +0000 (14:11 +0100)]
Add script for honeycomb version bump
The script replaces version string in all files from the Git index.
Usage:
./bump_hc_version.sh 1.18.01-SNAPSHOT 1.18.01-RC1
Change-Id: Icee55617dd0cbcdd97c2a1c19f77986f7300e057
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 8 Jan 2018 17:08:29 +0000 (18:08 +0100)]
Use Comparator.comparingInt instead of lambda
Change-Id: I42372554876c27e4c5d4f053f537d6d52ff449f8
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jakub Morvay [Thu, 4 Jan 2018 11:14:13 +0000 (12:14 +0100)]
Check for missing readers when building CompositeReaderRegistry
Change-Id: Ic5e16e7a53836600236701caa51599bc0b957955
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
Marek Gradzki [Wed, 20 Dec 2017 07:51:10 +0000 (08:51 +0100)]
Improve read failed error message
Change-Id: I5b74855284765b8281ec79122cad69d1a8f87856
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 14 Dec 2017 12:32:14 +0000 (13:32 +0100)]
Add Logger for RpcRegistryImpl
Change-Id: I6ef0133f0128fbf5cfb9ed9f0e738af0bda3a852
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Mon, 11 Dec 2017 07:42:24 +0000 (08:42 +0100)]
Do not hardcode websocket parameters in RestconfConfiguration
Change-Id: I3891eae1aac45fcd6e8adf4384c48d657998ed27
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
jan.srnicek [Tue, 5 Dec 2017 13:48:15 +0000 (14:48 +0100)]
Allow table type registration for BGP extension
modules with different package name
Change-Id: I0f6336052081fff923711e71cf85b748d8d4c730
Signed-off-by: jan.srnicek <jan.srnicek@pantheon.tech>
Martin Sunal [Wed, 29 Nov 2017 15:21:04 +0000 (16:21 +0100)]
Fixed bug in ModificationDiff
when leaf is modified in augmentation
modification type is subtree-modified.
Implementation expected only type write
or delete.
Change-Id: I3146b1a7322bd73d7972fecaceeafa654eeb84a4
Signed-off-by: Martin Sunal <msunal@frinx.io>
Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
Marek Gradzki [Thu, 30 Nov 2017 11:39:19 +0000 (12:39 +0100)]
HONEYCOMB-417: bump ODL dependencies to Nitrogen SR1
Change-Id: I6fe0d310a36dd8b0262c7db53f520616e65022e4
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
jan.srnicek [Mon, 27 Nov 2017 08:01:56 +0000 (09:01 +0100)]
Fixating of asciidoc-scripts
Same situation as honeycomb-common-scripts, this allows using different
versioning when using honeycomb artifacts
Change-Id: If78a2d542e8611b44260671fc27be285eed55317
Signed-off-by: jan.srnicek <jan.srnicek@pantheon.tech>
Marek Gradzki [Fri, 24 Nov 2017 05:52:04 +0000 (06:52 +0100)]
Fix getRevertTransactionContext() close
Also suppress Sonar warnings casused by SONARJAVA-1670.
until SonarCube is upgraded (HONEYCOMB-419).
Change-Id: Id5b775dfdd97180f6627192bd04aaac4f1e4e4c0
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 23 Nov 2017 11:23:36 +0000 (12:23 +0100)]
Set sonar-maven-plugin version to 3.3.0.603
If Maven encounters a plugin with no version declaration,
it will use the LATEST version,
which might not be compatible with Sonar server
(fd.io uses 5.6 currently).
Therefore it is recommended to lock down version of Sonar plugin:
http://blog.sonatype.com/2008/04/maven-209-released/
The patch should fix honeycomb and hc2vpp merge job failures
caused by using incompatible sonar-maven-plugin version.
Change-Id: Ib95aa4a131e1b8b7d85a531bba8e5a9f7c95cf2d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 23 Nov 2017 11:06:44 +0000 (12:06 +0100)]
Fix method/modifiers ordering to comply with JLS
Change-Id: I2b886a118ff5167df89a2922802b343ce5978c95
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 22 Nov 2017 15:59:39 +0000 (16:59 +0100)]
Fix Sonar warnings in FlatWriterRegistry
Remove useless variables and simplify if conditions.
Change-Id: I48a28334c47103057832f640c692c25625483bb6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 22 Nov 2017 15:35:20 +0000 (16:35 +0100)]
Cleanup various Sonar warings
Unused code, imports, etc.
Change-Id: Icb19d6a877d5ddbfd85caa86c4e62880e4db3c44
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 22 Nov 2017 14:38:23 +0000 (15:38 +0100)]
Make fields of UpdateFailedException transient
Exceptions are Serializable.
Fields of Serializable class must be either Serializable or transient.
But DataObjects are not serializable, and there is really no reason to
serialize UpdateFailedException.
This patch excludes fields of the UpdateFailedException
from serialization process to fix Sonar warnings.
Change-Id: I1eb9408289241bb4fe6f712ed9208f8460eef317
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 22 Nov 2017 10:17:15 +0000 (11:17 +0100)]
Add missing @Override annotations
Fix isses reported by Sonar
thanks to IntelliJ's code inspection.
Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Wed, 22 Nov 2017 09:40:26 +0000 (10:40 +0100)]
Add serialVersionUID to UpdateFailedException
Serializable classes should have serialVersionUID defined.
Change-Id: I0ad79f6d82ed72bcea521c4cafc53219ff82a7fa
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jan Srnicek [Tue, 21 Nov 2017 09:01:51 +0000 (10:01 +0100)]
Fixating version of common scripts
If something tries to use impl-parent, and its uses diferent versioning,
project.version would be override in this case with that project version
Change-Id: I5e2490a437712e36a11eb83550b2b05cd49477a3
Signed-off-by: Jan Srnicek <jan.srnicek@pantheon.tech>
Marek Gradzki [Mon, 20 Nov 2017 12:14:17 +0000 (13:14 +0100)]
Use InetAddresses.forString instead of InetAddress.getByName
Unlike InetAddress.getByName(), Guava's InetAddresses.forString()
never cause DNS services to be accessed.
JDK equivalents whenever you are expecting to handle only IP address string literals,
so there is no blocking DNS penalty for a malformed string.
See:
https://google.github.io/guava/releases/22.0/api/docs/com/google/common/net/InetAddresses.html#forString-java.lang.String-
Change-Id: Id1fc5fa45465b0e0b3aea7d60b9fdb855240d902
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 7 Nov 2017 08:21:08 +0000 (09:21 +0100)]
HONEYCOMB-385: bump ODL dependencies to Nitrogen
* guava bumped to 22.0 (same as used by ODL)
* use 4K RSA for SSH server (related to bouncy-castle bump in ODL)
- based on https://git.opendaylight.org/gerrit/#/c/60138/2
- also fixes HC2VPP-207
* removed some yang models from netconf-whitelist.xml,
that are no longer present in ODL dependencies,
* increased timeouts in distro tests, because generating 4K RSA key
my last longer (especially on slow jenkins nodes).
* EmptyMountPointService exposed to enable reuse by notification
and restconf providers
Change-Id: I2ff32bd7f0298716210fcfee4918007a42fab171
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Tue, 7 Nov 2017 13:32:16 +0000 (14:32 +0100)]
Make restconf depend on miminal-distribution-core
Follows infra/notrthbound/netconf dependency direction.
Change-Id: Ie29115e2b0b969d33270493c6d6cc4e9bda5e009
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jan Srnicek [Thu, 2 Nov 2017 11:06:12 +0000 (12:06 +0100)]
HONEYCOMB-359 - Wildcarded writers for BGP extensions
Defines wildcarded writers for BGP extensions to be able to
write theirs respective part of ApplicationRib
Change-Id: I0057b59c5977d5f75e0bc3c0c8eae9b8cfdf0f85
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Jan Srnicek [Fri, 3 Nov 2017 12:33:53 +0000 (13:33 +0100)]
HONEYCOMB-359 - Wildcarded writers
Adds option to specify subtree writer that can handle whole subtree
of nodes without having whole subtree specified. Its checking
if node is children at runtime, rather than having pre-computed tree
Change-Id: Ic46f2bd6de84f0dd14865825399f5a90a1f80859
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Marek Gradzki [Tue, 31 Oct 2017 09:21:21 +0000 (10:21 +0100)]
Post 1.17.10 release notes cleanup
Change-Id: Ib5760d558c1622e3ece7eae569c742e6fda3b82b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jan Srnicek [Mon, 23 Oct 2017 08:57:13 +0000 (10:57 +0200)]
HONEYCOMB-405 - Revert fix for indirect updates
If indirect update(delete+create) fails in a way, that delete passed,
but update part failed, delete part must be reverted
Moves reverter creation to MDTG and test cases related too it to
ModifiableDataTreeDelegatorRevertTest
Fixes tracking of allready processed changes by tracking them
from perspective of processModifications() method
Introduces UpdateFailedException as replacement
for BulkUpdateException(now thrown also for single updates)
Separates ReverterImpl from FlatWriterRegistry and ads unit tests
Change-Id: If0066d0716d9476be89b1d99985b6745becac15e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Jan Srnicek [Thu, 19 Oct 2017 06:14:23 +0000 (08:14 +0200)]
Adjust benchmark params
Increases number of iterations and reduces iteration time,
to produce more representative results.
Also describes what each annotation/parameter is used for
Change-Id: I0d8b693620c01a617870cc1999bfefbd2e0377fd
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Marek Gradzki [Wed, 23 Aug 2017 14:59:24 +0000 (16:59 +0200)]
HONEYCOMB-390: bump ODL dependencies to Carbon SR2
Change-Id: Ic7a5a7d883e7c6691b4b5deeb0980a93aef42799
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jan Srnicek [Mon, 9 Oct 2017 07:07:31 +0000 (09:07 +0200)]
HONEYCOMB-393 - Enable site plugin for yang-whitelist projects
Change-Id: I744ca366a81aecb5b79da7041e47db9c2363bd6e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Jan Srnicek [Mon, 9 Oct 2017 06:58:41 +0000 (08:58 +0200)]
HONEYCOMB-393 - Introduce asciidoc-scripts && scripts-parent
Change-Id: I15032951c52d25a3805c0348c8f400a935174eef
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Jan Srnicek [Mon, 9 Oct 2017 08:39:17 +0000 (10:39 +0200)]
HONEYCOMB-363 - Bgp extension modules
Provides maven modules per bgp extension.
Defines common configuration that can be used to define new
extensions(AbstractBgpExtensionModule).
Change-Id: I1c8ff65b6f9aa5474026f4bdf42476bd0559208e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Jan Srnicek [Wed, 4 Oct 2017 07:55:39 +0000 (09:55 +0200)]
HONEYCOMB-401 - Fix compilation issues for benchmark
Change-Id: I93df9e6b65273c82da308a194f4fe6488c6ce5e1
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Marek Gradzki [Tue, 3 Oct 2017 12:37:04 +0000 (14:37 +0200)]
Update jira project version in relese notes for 1.18.01
Change-Id: Iad1bdd2ab775dff9b207e0777858815edec88be3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>