honeycomb.git
5 years agoHoneycombDOMRpcService: remove unnecessary cast to Function 65/13965/1
Marek Gradzki [Mon, 6 Aug 2018 06:16:48 +0000 (08:16 +0200)]
HoneycombDOMRpcService: remove unnecessary cast to Function

Fixes issue reported by Sonar.

Change-Id: I083eb089f1ccd691a2015eaa401fe5acf7c59d49
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoRWUtils: use lambdas instead of anonymous inner classes 58/13958/1
Marek Gradzki [Mon, 6 Aug 2018 06:24:21 +0000 (08:24 +0200)]
RWUtils: use lambdas instead of anonymous inner classes

Change-Id: Ie17b819efd381983754065a821771eb3aac11d06
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoDo not use FQN of DataBroker in ModifiableDataTreeDelegator 52/13952/1
Marek Gradzki [Fri, 3 Aug 2018 19:00:37 +0000 (21:00 +0200)]
Do not use FQN of DataBroker in ModifiableDataTreeDelegator

Change-Id: I5944e9fd9388fbc533bf909b171b0672d798ad82
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoRemove code repetitions from GenericListWriter 49/13849/1
Marek Gradzki [Tue, 31 Jul 2018 16:12:21 +0000 (18:12 +0200)]
Remove code repetitions from GenericListWriter

Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoRelese notes: update jira project version for 1.18.10 73/13573/1
Marek Gradzki [Fri, 20 Jul 2018 07:03:51 +0000 (09:03 +0200)]
Relese notes: update jira project version for 1.18.10

Change-Id: I02b4f5948ae8818412d1ae0f7b3e1ac4acd55726
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoBump honeycomb version to 1.18.10-SNAPSHOT 72/13572/1
Marek Gradzki [Fri, 20 Jul 2018 06:54:26 +0000 (08:54 +0200)]
Bump honeycomb version to 1.18.10-SNAPSHOT

Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoRegister sutdown handler for Restconf server before start 56/13256/1
Marek Gradzki [Wed, 27 Jun 2018 19:33:28 +0000 (21:33 +0200)]
Register sutdown handler for Restconf server before start

Change-Id: I25a22a194048637ea72dd35767e1e1701b5723e4
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoDelegatingRewriteDeleteProducer: remove useles instanceof check 55/13255/1
Marek Gradzki [Wed, 27 Jun 2018 19:23:47 +0000 (21:23 +0200)]
DelegatingRewriteDeleteProducer: remove useles instanceof check

DataContainerNode is DataContainerChild.

Change-Id: I9122f9f3c27951f2d498f714d2ea15ebc96abdf3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agobgp: mark parameters of RouteWriter @NonNull 54/13254/1
Marek Gradzki [Wed, 27 Jun 2018 19:03:03 +0000 (21:03 +0200)]
bgp: mark parameters of RouteWriter @NonNull

The RouteWriter interface is used by LocRibChangeListener, which
never passes null parameters.

Change-Id: I33a775de6c67d24bc271c0af21c9634c661e85e9
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoCleanup WriterCustomizer 74/13174/1
Marek Gradzki [Thu, 21 Jun 2018 09:44:03 +0000 (11:44 +0200)]
Cleanup WriterCustomizer

Change-Id: Ied63ccd3fbc7e645ba3fa2db16528b3209319fa7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoHONEYCOMB-439: bump ODL dependencies to Oxygen-SR2 36/12936/2
Marek Gradzki [Thu, 7 Jun 2018 10:34:43 +0000 (12:34 +0200)]
HONEYCOMB-439: bump ODL dependencies to Oxygen-SR2

Change-Id: I76cc110ac7e0a64cdad79a7614f9e8b5eb624428
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoModifiableDataTreeManager: remove redundant non-default constructor 93/12993/1
Marek Gradzki [Mon, 11 Jun 2018 17:02:21 +0000 (19:02 +0200)]
ModifiableDataTreeManager: remove redundant non-default constructor

Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoWriteTransaction: make sure TransactionCommitFailedException is thrown 89/12989/2
Marek Gradzki [Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)]
WriteTransaction: make sure TransactionCommitFailedException is thrown

DataTreeModification.ready() used by DataModification.validate()
might throw IllegalArgumentException in case of missing mandatory nodes.

Use broader Exception type in WriteTransaction.submit()
to make sure contract defined by AsyncWriteTransaction is preserved.

Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoBump odl.yang-binding version from 0.12.0 to 0.12.1 35/12935/1
Marek Gradzki [Thu, 7 Jun 2018 10:30:47 +0000 (12:30 +0200)]
Bump odl.yang-binding version from 0.12.0 to 0.12.1

Change-Id: I37c247279c37c3fb066186c8390e827a9611b99e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoHONEYCOMB-432: bump ODL dependencies to Oxygen-SR1 39/12239/2
Marek Gradzki [Fri, 27 Apr 2018 09:31:47 +0000 (11:31 +0200)]
HONEYCOMB-432: bump ODL dependencies to Oxygen-SR1

Change-Id: Ibf01bcaf65bb048fcfae57b5ba0597faff5e4fe6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoInvoke CapabilityChangeNotificationProducer.close on shutdown 83/12583/2
Marek Gradzki [Wed, 16 May 2018 06:16:02 +0000 (08:16 +0200)]
Invoke CapabilityChangeNotificationProducer.close on shutdown

Also fixes Sonar warning regarding
useless CapabilityChangeNotificationProducer instantiation.

Change-Id: I376b834618d34f13615051abf622e6b12e031050
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributes 86/12586/2
Marek Gradzki [Wed, 16 May 2018 08:30:28 +0000 (10:30 +0200)]
HONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributes

ReflexiveListReaderCustomizer used default NOOP implementation,
which caused issues during serialization, because
BindingNormalizedNodeCodecRegistry.toNormalizedNode requrires key to be set.

Change-Id: I7822e07efe57cbdee2c539583776f8cc677ddab7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agojavadoc: add missing <name> in pom files 16/12316/1
Marek Gradzki [Fri, 27 Apr 2018 19:26:37 +0000 (21:26 +0200)]
javadoc: add missing <name> in pom files

Change-Id: I3d65b568c3651e4b2474c25bdf80cf3fff416360
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agobgp-extensions: fix ODL BGP links in javadoc 15/12315/1
Marek Gradzki [Fri, 27 Apr 2018 19:07:32 +0000 (21:07 +0200)]
bgp-extensions: fix ODL BGP links in javadoc

Change-Id: I84b338774c8175a7e59f03db3b81297607df0141
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoCollect all the updates for subtree writers 08/12108/2
Maros Marsalek [Wed, 25 Apr 2018 08:20:59 +0000 (10:20 +0200)]
Collect all the updates for subtree writers

So far, when a subtree writer was registered on a list node
and ModificationDiff detected 2 or more updated list items for that writer,
FlatWriterRegistry just picked the first item in list, processed that one
and ignored the rest.

Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728
Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
6 years agoWriteTransaction: log exception with error level when submit fails 23/11823/1
Marek Gradzki [Mon, 16 Apr 2018 13:28:27 +0000 (15:28 +0200)]
WriteTransaction: log exception with error level when submit fails

Change-Id: Ibc269946c08702805531a62c40be295fecc6b4ce
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix various Sonar warnings 39/11639/1
Marek Gradzki [Tue, 10 Apr 2018 05:10:53 +0000 (07:10 +0200)]
Fix various Sonar warnings

Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agorelease notes: set ODL project branch to stable-oxygen 17/11617/2
Marek Gradzki [Mon, 9 Apr 2018 14:06:38 +0000 (16:06 +0200)]
release notes: set ODL project branch to stable-oxygen

Change-Id: I03b48e387d370a4e264fb8bf4e3b22a03656fbba
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUpdate jira project version in relese notes for 1.18.07 16/11616/1
Marek Gradzki [Mon, 9 Apr 2018 14:05:31 +0000 (16:05 +0200)]
Update jira project version in relese notes for 1.18.07

Change-Id: Ie86c53f0c5922704ea7cbb3e29ee258e53c2cc70
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoBump Honeycomb version to 1.18.07-SNAPSHOT 13/11613/1
Marek Gradzki [Mon, 9 Apr 2018 14:00:33 +0000 (16:00 +0200)]
Bump Honeycomb version to 1.18.07-SNAPSHOT

Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-424: bump ODL dependencies to Oxygen 20/11320/1
Marek Gradzki [Thu, 4 Jan 2018 06:08:34 +0000 (07:08 +0100)]
HONEYCOMB-424: bump ODL dependencies to Oxygen

Change-Id: I3160e5df4e66b3b3c732619fc1fc7599459fda76
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix Netconf TCP server shutdown 22/11022/3
Marek Gradzki [Wed, 7 Mar 2018 19:34:47 +0000 (20:34 +0100)]
Fix Netconf TCP server shutdown

Change-Id: I0c74799a7249777c3258be915e9a95836fe0265e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoShutdownHandlerImpl: remove registered components after shutdown is performed 14/11014/1
Marek Gradzki [Wed, 7 Mar 2018 14:25:17 +0000 (15:25 +0100)]
ShutdownHandlerImpl: remove registered components after shutdown is performed

Prevents invoking AutoCloseable.close(), which might not be idempotent.

Change-Id: Id28200fb68a4c6e38878cf4f0b8aaee298dbc37b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix Restconf server shutdown 12/11012/1
Marek Gradzki [Wed, 7 Mar 2018 14:03:35 +0000 (15:03 +0100)]
Fix Restconf server shutdown

Change-Id: Ia7c0fc2d269ae88170297ef22476c8a61121238a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoMove shutdown hook registration to dedicated provider 11/11011/1
Marek Gradzki [Wed, 7 Mar 2018 13:51:18 +0000 (14:51 +0100)]
Move shutdown hook registration to dedicated provider

This change would allow using ShutdownHandlerImpl in integration tests.

Change-Id: I854f65d03b9e1a495fda7211fd1b7fd51b4e5ba3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix handling of RPCs that do not produce a result 98/10998/2
Marek Gradzki [Wed, 7 Mar 2018 10:02:29 +0000 (11:02 +0100)]
Fix handling of RPCs that do not produce a result

The output statement of RPC operation is optional.

In such cases DefaultDOMRpcResult should be initialized with null result.

Change-Id: Ia832e480b3c72607b3636493bc044a9144f247be
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoPost HONEYCOMB-161 cleanup 92/10992/1
Marek Gradzki [Wed, 7 Mar 2018 06:15:53 +0000 (07:15 +0100)]
Post HONEYCOMB-161 cleanup

Change-Id: I46652c9f109a6ede60cfb3143d945fe8b6f1f042
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-418: Bump ODL dependencies from Nitrogen SR1 to Nitrogen SR2 74/10774/2
Marek Gradzki [Thu, 4 Jan 2018 06:08:34 +0000 (07:08 +0100)]
HONEYCOMB-418: Bump ODL dependencies from Nitrogen SR1 to Nitrogen SR2

Change-Id: I98f73e0cce217202e8c335b1fa06f1b3fc8bce05
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUse XMLStreamNormalizedNodeStreamWriter from yang-data-codec-xml 89/10389/1
Marek Gradzki [Fri, 2 Feb 2018 10:38:06 +0000 (11:38 +0100)]
Use XMLStreamNormalizedNodeStreamWriter from yang-data-codec-xml

instead of old and deprecated version from yang-data-impl.

Change-Id: If3f9dbffe83cdde29d2f4996dbd299a60bab90a9
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUse YangParserTestUtils instead of CrossSourceStatementReactor.BuildAction 87/10387/1
Marek Gradzki [Fri, 2 Feb 2018 10:10:36 +0000 (11:10 +0100)]
Use YangParserTestUtils instead of CrossSourceStatementReactor.BuildAction

Simplifies code and removes usages of deprecated YangStatementSourceImpl.

Change-Id: I012e2de7a5a902927eaec87370f1850d54fbf4ee
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoRemove usages of deprecated BindingNormalizedNodeSerializer from yantools 86/10386/1
Marek Gradzki [Fri, 2 Feb 2018 09:48:33 +0000 (10:48 +0100)]
Remove usages of deprecated BindingNormalizedNodeSerializer from yantools

Use mdsal version:
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer

instead of
org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer

Change-Id: Idfb977acee95de40183d4574565c46ac9ab54a27
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix revision of hc-aug-test.yang 85/10385/1
Marek Gradzki [Fri, 2 Feb 2018 09:39:43 +0000 (10:39 +0100)]
Fix revision of hc-aug-test.yang

Change-Id: I1ca0e255c1467af31a39eb515c9cd4e7b4a4948a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoImprove error messages in distro tests 84/10384/1
Marek Gradzki [Fri, 2 Feb 2018 09:36:29 +0000 (10:36 +0100)]
Improve error messages in distro tests

Change-Id: Ie0bc2e2add7940cb8f0ce2d5e4ea41d1e1c9d991
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUpdate project-odl-branch property to match ODL version used 40/10340/1
Marek Gradzki [Wed, 31 Jan 2018 06:43:02 +0000 (07:43 +0100)]
Update project-odl-branch property to match ODL version used

Change-Id: I2a036037245be07d2cd452a8036374967ca7622c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-414: use NetconfNorthboundSshServer for NETCONF initialization 27/10327/2
Marek Gradzki [Tue, 30 Jan 2018 09:35:11 +0000 (10:35 +0100)]
HONEYCOMB-414: use NetconfNorthboundSshServer for NETCONF initialization

instead of rewriting it in HC.

Change-Id: Id2b5cb1b7bcd38728721ce92a7b5dbe1d919731c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoIntegration test for SubtreeWriter update 33/10133/1
Marek Gradzki [Wed, 17 Jan 2018 07:56:09 +0000 (08:56 +0100)]
Integration test for SubtreeWriter update

Change-Id: Ic8d2cd524ea2d22859df28cb48aa41d5539efbee
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoImprove integration tests for SubtreeWriter 18/10118/2
Marek Gradzki [Tue, 16 Jan 2018 12:59:41 +0000 (13:59 +0100)]
Improve integration tests for SubtreeWriter

Change-Id: I20209b800eaa892e0fb742066003e956d00bbb22
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUpdate jira project version in relese notes for 1.18.04 52/10052/2
Marek Gradzki [Wed, 10 Jan 2018 12:41:32 +0000 (13:41 +0100)]
Update jira project version in relese notes for 1.18.04

Change-Id: Ieb60319ad575c38e7539cf8d0c58d62e71a29387
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoBump honeycomb version to 1.18.04-SNAPSHOT 30/10030/1
Marek Gradzki [Tue, 9 Jan 2018 15:50:59 +0000 (16:50 +0100)]
Bump honeycomb version to 1.18.04-SNAPSHOT

Change-Id: Idb0fec8ab45ec76431ab6d05d70a61eee1929628
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoAdd script for honeycomb version bump 28/10028/2
Marek Gradzki [Tue, 9 Jan 2018 13:11:26 +0000 (14:11 +0100)]
Add script for honeycomb version bump

The script replaces version string in all files from the Git index.

Usage:

./bump_hc_version.sh 1.18.01-SNAPSHOT 1.18.01-RC1

Change-Id: Icee55617dd0cbcdd97c2a1c19f77986f7300e057
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUse Comparator.comparingInt instead of lambda 00/10000/1
Marek Gradzki [Mon, 8 Jan 2018 17:08:29 +0000 (18:08 +0100)]
Use Comparator.comparingInt instead of lambda

Change-Id: I42372554876c27e4c5d4f053f537d6d52ff449f8
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoCheck for missing readers when building CompositeReaderRegistry 46/9946/1
Jakub Morvay [Thu, 4 Jan 2018 11:14:13 +0000 (12:14 +0100)]
Check for missing readers when building CompositeReaderRegistry

Change-Id: Ic5e16e7a53836600236701caa51599bc0b957955
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
6 years agoImprove read failed error message 79/9879/1
Marek Gradzki [Wed, 20 Dec 2017 07:51:10 +0000 (08:51 +0100)]
Improve read failed error message

Change-Id: I5b74855284765b8281ec79122cad69d1a8f87856
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoAdd Logger for RpcRegistryImpl 45/9845/1
Marek Gradzki [Thu, 14 Dec 2017 12:32:14 +0000 (13:32 +0100)]
Add Logger for RpcRegistryImpl

Change-Id: I6ef0133f0128fbf5cfb9ed9f0e738af0bda3a852
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoDo not hardcode websocket parameters in RestconfConfiguration 84/9784/1
Marek Gradzki [Mon, 11 Dec 2017 07:42:24 +0000 (08:42 +0100)]
Do not hardcode websocket parameters in RestconfConfiguration

Change-Id: I3891eae1aac45fcd6e8adf4384c48d657998ed27
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoAllow table type registration for BGP extension 28/9728/1
jan.srnicek [Tue, 5 Dec 2017 13:48:15 +0000 (14:48 +0100)]
Allow table type registration for BGP extension
modules with different package name

Change-Id: I0f6336052081fff923711e71cf85b748d8d4c730
Signed-off-by: jan.srnicek <jan.srnicek@pantheon.tech>
6 years agoFixed bug in ModificationDiff 88/9688/2
Martin Sunal [Wed, 29 Nov 2017 15:21:04 +0000 (16:21 +0100)]
Fixed bug in ModificationDiff

when leaf is modified in augmentation
modification type is subtree-modified.
Implementation expected only type write
or delete.

Change-Id: I3146b1a7322bd73d7972fecaceeafa654eeb84a4
Signed-off-by: Martin Sunal <msunal@frinx.io>
Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
6 years agoHONEYCOMB-417: bump ODL dependencies to Nitrogen SR1 70/9670/1
Marek Gradzki [Thu, 30 Nov 2017 11:39:19 +0000 (12:39 +0100)]
HONEYCOMB-417: bump ODL dependencies to Nitrogen SR1

Change-Id: I6fe0d310a36dd8b0262c7db53f520616e65022e4
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFixating of asciidoc-scripts 75/9575/1
jan.srnicek [Mon, 27 Nov 2017 08:01:56 +0000 (09:01 +0100)]
Fixating of asciidoc-scripts

Same situation as honeycomb-common-scripts, this allows using different
versioning when using honeycomb artifacts

Change-Id: If78a2d542e8611b44260671fc27be285eed55317
Signed-off-by: jan.srnicek <jan.srnicek@pantheon.tech>
6 years agoFix getRevertTransactionContext() close 53/9553/2
Marek Gradzki [Fri, 24 Nov 2017 05:52:04 +0000 (06:52 +0100)]
Fix getRevertTransactionContext() close

Also suppress Sonar warnings casused by SONARJAVA-1670.
until SonarCube is upgraded (HONEYCOMB-419).

Change-Id: Id5b775dfdd97180f6627192bd04aaac4f1e4e4c0
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoSet sonar-maven-plugin version to 3.3.0.603 40/9540/1
Marek Gradzki [Thu, 23 Nov 2017 11:23:36 +0000 (12:23 +0100)]
Set sonar-maven-plugin version to 3.3.0.603

If Maven encounters a plugin with no version declaration,
it will use the LATEST version,
which might not be compatible with Sonar server
(fd.io uses 5.6 currently).

Therefore it is recommended to lock down version of Sonar plugin:
http://blog.sonatype.com/2008/04/maven-209-released/

The patch should fix honeycomb and hc2vpp merge job failures
caused by using incompatible sonar-maven-plugin version.

Change-Id: Ib95aa4a131e1b8b7d85a531bba8e5a9f7c95cf2d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix method/modifiers ordering to comply with JLS 39/9539/1
Marek Gradzki [Thu, 23 Nov 2017 11:06:44 +0000 (12:06 +0100)]
Fix method/modifiers ordering to comply with JLS

Change-Id: I2b886a118ff5167df89a2922802b343ce5978c95
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix Sonar warnings in FlatWriterRegistry 29/9529/1
Marek Gradzki [Wed, 22 Nov 2017 15:59:39 +0000 (16:59 +0100)]
Fix Sonar warnings in FlatWriterRegistry

Remove useless variables and simplify if conditions.

Change-Id: I48a28334c47103057832f640c692c25625483bb6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoCleanup various Sonar warings 28/9528/1
Marek Gradzki [Wed, 22 Nov 2017 15:35:20 +0000 (16:35 +0100)]
Cleanup various Sonar warings

Unused code, imports, etc.

Change-Id: Icb19d6a877d5ddbfd85caa86c4e62880e4db3c44
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoMake fields of UpdateFailedException transient 26/9526/1
Marek Gradzki [Wed, 22 Nov 2017 14:38:23 +0000 (15:38 +0100)]
Make fields of UpdateFailedException transient

Exceptions are Serializable.
Fields of Serializable class must be either Serializable or transient.

But DataObjects are not serializable, and there is really no reason to
serialize UpdateFailedException.

This patch excludes fields of the UpdateFailedException
from serialization process to fix Sonar warnings.

Change-Id: I1eb9408289241bb4fe6f712ed9208f8460eef317
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoAdd missing @Override annotations 17/9517/1
Marek Gradzki [Wed, 22 Nov 2017 10:17:15 +0000 (11:17 +0100)]
Add missing @Override annotations

Fix isses reported by Sonar
thanks to IntelliJ's code inspection.

Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoAdd serialVersionUID to UpdateFailedException 15/9515/1
Marek Gradzki [Wed, 22 Nov 2017 09:40:26 +0000 (10:40 +0100)]
Add serialVersionUID to UpdateFailedException

Serializable classes should have serialVersionUID defined.

Change-Id: I0ad79f6d82ed72bcea521c4cafc53219ff82a7fa
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFixating version of common scripts 03/9503/2
Jan Srnicek [Tue, 21 Nov 2017 09:01:51 +0000 (10:01 +0100)]
Fixating version of common scripts

If something tries to use impl-parent, and its uses diferent versioning,
project.version would be override in this case with that project version

Change-Id: I5e2490a437712e36a11eb83550b2b05cd49477a3
Signed-off-by: Jan Srnicek <jan.srnicek@pantheon.tech>
6 years agoUse InetAddresses.forString instead of InetAddress.getByName 95/9495/1
Marek Gradzki [Mon, 20 Nov 2017 12:14:17 +0000 (13:14 +0100)]
Use InetAddresses.forString instead of InetAddress.getByName

Unlike InetAddress.getByName(), Guava's InetAddresses.forString()
never cause DNS services to be accessed.
JDK equivalents whenever you are expecting to handle only IP address string literals,
so there is no blocking DNS penalty for a malformed string.

See:
https://google.github.io/guava/releases/22.0/api/docs/com/google/common/net/InetAddresses.html#forString-java.lang.String-

Change-Id: Id1fc5fa45465b0e0b3aea7d60b9fdb855240d902
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-385: bump ODL dependencies to Nitrogen 58/9258/6
Marek Gradzki [Tue, 7 Nov 2017 08:21:08 +0000 (09:21 +0100)]
HONEYCOMB-385: bump ODL dependencies to Nitrogen

* guava bumped to 22.0 (same as used by ODL)
* use 4K RSA for SSH server (related to bouncy-castle bump in ODL)
  - based on https://git.opendaylight.org/gerrit/#/c/60138/2
  - also fixes HC2VPP-207
* removed some yang models from netconf-whitelist.xml,
  that are no longer present in ODL dependencies,
* increased timeouts in distro tests, because generating 4K RSA key
  my last longer (especially on slow jenkins nodes).
* EmptyMountPointService exposed to enable reuse by notification
  and restconf providers

Change-Id: I2ff32bd7f0298716210fcfee4918007a42fab171
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoMake restconf depend on miminal-distribution-core 62/9262/1
Marek Gradzki [Tue, 7 Nov 2017 13:32:16 +0000 (14:32 +0100)]
Make restconf depend on miminal-distribution-core

Follows infra/notrthbound/netconf dependency direction.

Change-Id: Ie29115e2b0b969d33270493c6d6cc4e9bda5e009
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-359 - Wildcarded writers for BGP extensions 10/8710/8
Jan Srnicek [Thu, 2 Nov 2017 11:06:12 +0000 (12:06 +0100)]
HONEYCOMB-359 - Wildcarded writers for BGP extensions

Defines wildcarded writers for BGP extensions to be able to
write theirs respective part of ApplicationRib

Change-Id: I0057b59c5977d5f75e0bc3c0c8eae9b8cfdf0f85
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-359 - Wildcarded writers 34/8434/18
Jan Srnicek [Fri, 3 Nov 2017 12:33:53 +0000 (13:33 +0100)]
HONEYCOMB-359 - Wildcarded writers

Adds option to specify subtree writer that can handle whole subtree
of nodes without having whole subtree specified. Its checking
if node is children at runtime, rather than having pre-computed tree

Change-Id: Ic46f2bd6de84f0dd14865825399f5a90a1f80859
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoPost 1.17.10 release notes cleanup 35/9135/1
Marek Gradzki [Tue, 31 Oct 2017 09:21:21 +0000 (10:21 +0100)]
Post 1.17.10 release notes cleanup

Change-Id: Ib5760d558c1622e3ece7eae569c742e6fda3b82b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-405 - Revert fix for indirect updates 34/8734/7
Jan Srnicek [Mon, 23 Oct 2017 08:57:13 +0000 (10:57 +0200)]
HONEYCOMB-405 - Revert fix for indirect updates

If indirect update(delete+create) fails in a way, that delete passed,
but update part failed, delete part must be reverted

Moves reverter creation to MDTG and test cases related too it to
ModifiableDataTreeDelegatorRevertTest

Fixes tracking of allready processed changes by tracking them
from perspective of processModifications() method

Introduces UpdateFailedException as replacement
for BulkUpdateException(now thrown also for single updates)

Separates ReverterImpl from FlatWriterRegistry and ads unit tests

Change-Id: If0066d0716d9476be89b1d99985b6745becac15e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoAdjust benchmark params 53/8853/5
Jan Srnicek [Thu, 19 Oct 2017 06:14:23 +0000 (08:14 +0200)]
Adjust benchmark params

Increases number of iterations and reduces iteration time,
to produce more representative results.

Also describes what each annotation/parameter is used for

Change-Id: I0d8b693620c01a617870cc1999bfefbd2e0377fd
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-390: bump ODL dependencies to Carbon SR2 87/8187/4
Marek Gradzki [Wed, 23 Aug 2017 14:59:24 +0000 (16:59 +0200)]
HONEYCOMB-390: bump ODL dependencies to Carbon SR2

Change-Id: Ic7a5a7d883e7c6691b4b5deeb0980a93aef42799
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-393 - Enable site plugin for yang-whitelist projects 09/8709/2
Jan Srnicek [Mon, 9 Oct 2017 07:07:31 +0000 (09:07 +0200)]
HONEYCOMB-393 - Enable site plugin for yang-whitelist projects

Change-Id: I744ca366a81aecb5b79da7041e47db9c2363bd6e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-393 - Introduce asciidoc-scripts && scripts-parent 08/8708/2
Jan Srnicek [Mon, 9 Oct 2017 06:58:41 +0000 (08:58 +0200)]
HONEYCOMB-393 - Introduce asciidoc-scripts && scripts-parent

Change-Id: I15032951c52d25a3805c0348c8f400a935174eef
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-363 - Bgp extension modules 86/8486/10
Jan Srnicek [Mon, 9 Oct 2017 08:39:17 +0000 (10:39 +0200)]
HONEYCOMB-363 - Bgp extension modules

Provides maven modules per bgp extension.
Defines common configuration that can be used to define new
extensions(AbstractBgpExtensionModule).

Change-Id: I1c8ff65b6f9aa5474026f4bdf42476bd0559208e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-401 - Fix compilation issues for benchmark 51/8651/1
Jan Srnicek [Wed, 4 Oct 2017 07:55:39 +0000 (09:55 +0200)]
HONEYCOMB-401 - Fix compilation issues for benchmark

Change-Id: I93df9e6b65273c82da308a194f4fe6488c6ce5e1
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoUpdate jira project version in relese notes for 1.18.01 35/8635/1
Marek Gradzki [Tue, 3 Oct 2017 12:37:04 +0000 (14:37 +0200)]
Update jira project version in relese notes for 1.18.01

Change-Id: Iad1bdd2ab775dff9b207e0777858815edec88be3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoBump honeycomb version to 1.18.01-SNAPSHOT 34/8634/1
Marek Gradzki [Tue, 3 Oct 2017 12:33:14 +0000 (14:33 +0200)]
Bump honeycomb version to 1.18.01-SNAPSHOT

Change-Id: I64bcd7e45da5d7431ba436ff6ad1ac62cd1d1051
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoFix BGP RIB link-state configuration 36/8536/2
Marek Gradzki [Tue, 26 Sep 2017 11:00:02 +0000 (13:00 +0200)]
Fix BGP RIB link-state configuration

Change-Id: I896f1aae3b71e21bd6127aedf22faef07a132daf
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoUse relative paths in IT test config 10/8610/1
Marek Gradzki [Mon, 2 Oct 2017 07:18:47 +0000 (09:18 +0200)]
Use relative paths in IT test config

Change-Id: Ic19175c90fbd91ba81aaa812f735c03eb9c9a836
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoInclude IT coverage in JaCoCo and Sonar reports 96/8596/2
Marek Gradzki [Fri, 29 Sep 2017 08:52:07 +0000 (10:52 +0200)]
Include IT coverage in JaCoCo and Sonar reports

* introduces jacoco-it.exec which stores
  aggregated IT test execution data,
* configures Sonar to use jacoco-it.exec
  to report IT coverage,
* marks following modules as integration tests:
  - it-test
  - minimal-distribution-test
  - bgp-distribution-test

Change-Id: I538c1febb6112a6abad29061f6b00259a0d79f9f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoClean JaCoCo and Sonar configuration 95/8595/1
Marek Gradzki [Fri, 29 Sep 2017 08:36:17 +0000 (10:36 +0200)]
Clean JaCoCo and Sonar configuration

Remove unused and obsolete values from
honeycomb-parent's pom.

Change-Id: I520a1b69169db6778787bae9ac8d4092a9078e4f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoBump JaCoCo Maven Plugin to 0.7.9 94/8594/1
Marek Gradzki [Fri, 29 Sep 2017 09:43:10 +0000 (11:43 +0200)]
Bump JaCoCo Maven Plugin to 0.7.9

Change-Id: I67019b56d98b5896f7a4eb02657bd39ca2e238e5
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoYoung Generation sizing optimalization 23/8423/1
Jan Srnicek [Thu, 14 Sep 2017 10:30:55 +0000 (12:30 +0200)]
Young Generation sizing optimalization

Change-Id: I3fd503029f7734578142ae4606cfc8988204af2e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoMake data stored in ModificationCache eligible for GC earlier 48/8348/2
Marek Gradzki [Fri, 8 Sep 2017 06:16:55 +0000 (08:16 +0200)]
Make data stored in ModificationCache eligible for GC earlier

ModificationCache might store huge amount of data.
After DOs are retreved from readers it is not used anymore.

Change-Id: I66d57047212fed02321c416af3608c4998315ce7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-392 - Footprint measuring support 46/8246/7
Jan Srnicek [Tue, 12 Sep 2017 06:22:07 +0000 (08:22 +0200)]
HONEYCOMB-392 - Footprint measuring support

Change-Id: I079c8ceef84cda43159e1823fe42ad77cdc981e8
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoFix Sonar error-handling issues 29/8329/1
Marek Gradzki [Thu, 7 Sep 2017 10:22:28 +0000 (12:22 +0200)]
Fix Sonar error-handling issues

Change-Id: Iae8a7d27ed4ba778abe5bdbb937f55fa4d7a6638
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoDisable site for yang-whitelist 18/8318/2
Marek Gradzki [Wed, 6 Sep 2017 07:27:24 +0000 (09:27 +0200)]
Disable site for yang-whitelist

Should fix merge job issues introduced by HONEYCOMB-389

Change-Id: Ieb937267fdc05492c0f58761cb36b3f45749d042
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-389 - Netconf whitelist 12/8212/6
Jan Srnicek [Thu, 31 Aug 2017 08:43:46 +0000 (10:43 +0200)]
HONEYCOMB-389 - Netconf whitelist

Change-Id: I279f77fcada863c7ece2c2368fc4b5f957b45435
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-389 - Restconf whitelist 11/8211/8
Jan Srnicek [Thu, 31 Aug 2017 07:51:39 +0000 (09:51 +0200)]
HONEYCOMB-389 - Restconf whitelist

Change-Id: I4c60d0ea569e85b23a9d0127ef496545fc475a61
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHONEYCOMB-389 - Static yang binding api and impl 08/8208/7
Jan Srnicek [Wed, 30 Aug 2017 12:55:04 +0000 (14:55 +0200)]
HONEYCOMB-389 - Static yang binding api and impl

Also provides ignore option for default module list generation

Change-Id: I9e10215491c964e6e88f90d6a3ad4335c94ec7d2
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoMake DataModification closeable 97/8297/2
Maros Marsalek [Mon, 4 Sep 2017 12:37:57 +0000 (14:37 +0200)]
Make DataModification closeable

and close the modification from transactions.

This enables cleanup of underlay resources per transaction.
It is not needed when managing VPP, but might be useful for
other use-cases where underlay transactions are involved.

Change-Id: If14197052172be0158fd7efb5ee1794935d576bc
Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
6 years agoHC2VPP-218 - Context initialization binding 02/8202/2
Jan Srnicek [Thu, 24 Aug 2017 12:58:28 +0000 (14:58 +0200)]
HC2VPP-218 - Context initialization binding

Binds correct DOMDataBroker for context

Change-Id: Id09e77d6223a9c322e98879ccb5824539b5d2ce6
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoDo not fail if CloseableComponent's shutdown fails 98/8198/2
Marek Gradzki [Thu, 24 Aug 2017 08:33:15 +0000 (10:33 +0200)]
Do not fail if CloseableComponent's shutdown fails

Change-Id: I6875874f5b388a4d289c538f2d3dbfd4ff6feec3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoDumpCacheManager: make dumpParams optional 85/8185/1
Marek Gradzki [Wed, 23 Aug 2017 12:10:46 +0000 (14:10 +0200)]
DumpCacheManager: make dumpParams optional

Change-Id: I6ee37f9e39842468f746656dff53b98c2b3796ba
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoMove StaticCacheKeyFactory to honeycomb project 69/8169/1
Marek Gradzki [Wed, 23 Aug 2017 09:51:30 +0000 (11:51 +0200)]
Move StaticCacheKeyFactory to honeycomb project

Change-Id: I566c8ce15ac1cbf932c900812c12bd9c56b223f7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoRelease notes cleanup after releasing Honeycomb 1.17.07 77/8077/1
Marek Gradzki [Thu, 27 Jul 2017 05:13:24 +0000 (07:13 +0200)]
Release notes cleanup after releasing Honeycomb 1.17.07

Change-Id: I6eadb8123e09642899663e4195be6aabbdfc3075
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
6 years agoHONEYCOMB-386 - Make update optional 54/7954/7
Jan Srnicek [Wed, 16 Aug 2017 07:21:24 +0000 (09:21 +0200)]
HONEYCOMB-386 - Make update optional

If customizer does not support update directly,
updates for its handled nodes are broken up to delete + create pairs.

Change-Id: I2929109e8c9a1db0bef108367cf7d839135ce173
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoHoneycomb docs update 20/8020/2
Jan Srnicek [Tue, 15 Aug 2017 09:44:09 +0000 (11:44 +0200)]
Honeycomb docs update

Change-Id: I3f65dffad169634e5cf273d8568066b7f15bda37
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
6 years agoShutdown closing of resources 74/7974/3
Jan Srnicek [Thu, 10 Aug 2017 12:39:30 +0000 (14:39 +0200)]
Shutdown closing of resources

Change-Id: If57a5414153cb983138872c7a1ded7c7066b1b6d
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>