Florin Coras [Tue, 23 Oct 2018 14:59:24 +0000 (07:59 -0700)]
lisp: register cp port only if enabled
Change-Id: I7030951215f0cf7d00c037892ac92d9c304cb5a1
Signed-off-by: Florin Coras <fcoras@cisco.com>
Mohsin Kazmi [Fri, 28 Sep 2018 09:45:01 +0000 (11:45 +0200)]
vlib: Add support for pci io read/write
Change-Id: I9d96e7782a12c2e19eacbb75edb1fb450cf33bed
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Damjan Marion [Tue, 23 Oct 2018 17:50:20 +0000 (19:50 +0200)]
vlib: reduce default buffer memory size to be below RLIMIT_MEMLOCK
Change-Id: If36be24fa08e21c7718a1dced506a7f254dfb5cf
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sun, 30 Sep 2018 16:26:20 +0000 (18:26 +0200)]
Numa-aware, growable physical memory allocator (pmalloc)
Change-Id: Ic4c46bc733afae8bf0d8146623ed15633928de30
Signed-off-by: Damjan Marion <damarion@cisco.com>
Kingwel Xie [Thu, 11 Oct 2018 00:51:59 +0000 (20:51 -0400)]
pg: udp length & checsum issue
if udp length is specified, then use this length to calculate udp checksum
otherwise, use length from vlib_buffer
Change-Id: I5304a60d5d429993d0524b864b65ec503775412d
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Stephen Hemminger [Mon, 22 Oct 2018 18:17:57 +0000 (11:17 -0700)]
dpdk: support 18.11 changes to CRC flags
In DPDK 18.11 the device flags for keeping/stripping CRC flags has
changed. The old strip flag is gone, and replaced by a CRC keep
flag.
Change-Id: Iaa162854862a2a0855b418ee8029383fc116d3a2
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Matthew Smith [Mon, 22 Oct 2018 21:37:25 +0000 (16:37 -0500)]
dpdk: add esp6 decrypt nodes, func declarations
The function dpdk_ipsec_process() attempts to initialize some
globals that store node indexes after looking up the node
dpdk-esp6-decrypt. No such node was declared, so a segv
occurs after dereferencing the result of the lookup.
Add a node function that invokes dpdk_esp_decrypt_inline()
with is_ip6 set to 1. Add a declaration of node dpdk-esp6-decrypt
that uses the node function.
Change-Id: I31ce23a458c2d4181bf40cbc2118c4ef3b9baf97
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Dave Barach [Wed, 17 Oct 2018 14:38:51 +0000 (10:38 -0400)]
c11 safe string handling support
Change-Id: Ied34720ca5a6e6e717eea4e86003e854031b6eab
Signed-off-by: Dave Barach <dave@barachs.net>
Marco Varlese [Thu, 18 Oct 2018 07:19:15 +0000 (09:19 +0200)]
Release Notes for 18.10
Change-Id: I3500113f30d6d98eae69d39b59b90569c796e011
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
(cherry picked from commit
3a9a6f72d18aa72e4038422a4c882927037441e7)
Klement Sekera [Tue, 23 Oct 2018 09:05:23 +0000 (11:05 +0200)]
ipsec: fix wrong counter bump
Change-Id: I5105b688ef3df2c949ba09e1e90c1b8913502388
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Damjan Marion [Mon, 22 Oct 2018 11:38:57 +0000 (13:38 +0200)]
vlib: pci improvements
- logging
- pass vlib_main_t to all APIs
- open vfio container only when needed
Change-Id: I897e53e0af3f91c3a99f0c827401d1c0ec2e478a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ole Troan [Mon, 22 Oct 2018 12:11:45 +0000 (14:11 +0200)]
GBP: Revert back to using VppIpPrefix wrapper
Change-Id: I33567b9c5822008e6b75c7cc04f63853dee88654
Signed-off-by: Ole Troan <ot@cisco.com>
Klement Sekera [Mon, 22 Oct 2018 11:17:19 +0000 (13:17 +0200)]
ipsec fix missing node renames
Change-Id: I70bc5af646894811d373456ec66aa83f2d75a477
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Lijian Zhang [Wed, 26 Sep 2018 01:48:57 +0000 (09:48 +0800)]
add Contiv-VPP installation guidance on Aarch64
add Contiv-VPP installation guidance on Aarch64
Change-Id: I323c871d346c47396916a618934c5e169ee49212
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Song Zhu <Song.Zhu@arm.com>
Reviewed-by: Trevor Tao <Trevor.Tao@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Reviewed-by: Tina Tsou <Tina.Tsou@arm.com>
Damjan Marion [Mon, 22 Oct 2018 11:07:02 +0000 (13:07 +0200)]
vlib: introduce vlib_buffer_get_{pa,va,current_va,current_pa} inlines
Change-Id: I0b42ac6b05bc9910904a97924ea4bebc84507d4d
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 22 Oct 2018 11:01:46 +0000 (13:01 +0200)]
vppinfra: use log2 page size in hugepage functions
Change-Id: Ibec32c6df32f4cd9889d378e244f170c93ad295b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Juraj Sloboda [Tue, 16 Oct 2018 10:18:21 +0000 (12:18 +0200)]
Fix buffer overflow when fragmenting packets (VPP-1383)
Change-Id: Idcda9ae55fa2efb0b2e928bac3e8e86ff8d19eba
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Dave Barach [Mon, 10 Sep 2018 16:31:15 +0000 (12:31 -0400)]
X86_64 perf counter plugin
Change-Id: Ie5a00c15ee9536cc61afab57f6cadc1aa1972f3c
Signed-off-by: Dave Barach <dave@barachs.net>
Filip Varga [Mon, 22 Oct 2018 10:36:58 +0000 (12:36 +0200)]
VPP-1420 CDP check memory bounds fix
Change-Id: I7951ffd050acb618dd20b86ae5946e1228ff5d79
Signed-off-by: Filip Varga <fivarga@cisco.com>
Ole Troan [Mon, 22 Oct 2018 07:30:26 +0000 (09:30 +0200)]
PAPI: Add support for format/unformat functions.
With the introduction of new types, like vl_api_address_t
it is now possible to call a message using one of those
functions with a string representation. E.g. for an IP address
ip_add_address(address="1.1.1.1/24")
The language wrapper will automatically convert the string
into the vl_api_address_t representation. Currently
the caller must do the reverse conversion from the returned
named tuple with the unformat function.
rv = get_address_on_interface(sw_if_index=1)
print(VPPFormat.unformat(rv.address))
Change-Id: Ic872b4560b2f4836255bd5260289bfa38c75bc5d
Signed-off-by: Ole Troan <ot@cisco.com>
Juraj Sloboda [Mon, 22 Oct 2018 08:59:45 +0000 (10:59 +0200)]
Fix dereferencing null string in dpdk_early_init
Change-Id: Iffba7ebe5af8fadc0251f3a10022739d45f394ce
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Paul Vinciguerra [Sat, 20 Oct 2018 21:51:14 +0000 (14:51 -0700)]
Fix stat_segment.c issue.
* using default socket name even when overridden in config.
Change-Id: I1849bf5269629873afd1dd48d2df785a491781c3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Ole Troan [Mon, 22 Oct 2018 07:41:29 +0000 (09:41 +0200)]
stats: Add wrapper for vec_free
The result vector from stat_segment_ls must be freed
by the caller. Add wrapper for non-C language bindings.
Change-Id: I7eee7f80ec98b41696d354add47b26978e12ef0f
Signed-off-by: Ole Troan <ot@cisco.com>
Klement Sekera [Tue, 9 Oct 2018 14:05:48 +0000 (16:05 +0200)]
ipsec: split ipsec nodes into ip4/ip6 nodes
Change-Id: Ic6b27659f1fe9e8df39e80a0441305e4e952195a
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Damjan Marion [Sat, 20 Oct 2018 21:26:46 +0000 (23:26 +0200)]
dpdk: use rte_vfio_dma_map API instead of digging for vfio fd
This is new API introduced in DPDK 18.08.
Change-Id: I66d49fe54a6abf2af621b597e8d4535e29cecec4
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Sun, 21 Oct 2018 17:50:48 +0000 (10:50 -0700)]
lisp-gpe: register udp port only if enabled (VPP-1468)
Change-Id: I7d0930a19d927bbd7ba3fc879d5a0c8064827629
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 20 Oct 2018 00:49:00 +0000 (17:49 -0700)]
tcp: count first lost hole (VPP-1465)
Change-Id: I3ac136e2a10796d8fa86ddb6f0d6cabe5fa749f8
Signed-off-by: Florin Coras <fcoras@cisco.com>
Stephen Hemminger [Tue, 16 Oct 2018 00:50:46 +0000 (17:50 -0700)]
dpdk: add netvsc PMD
Teach DPDK plugin about the netvsc Poll Mode Driver.
The speed of the Netvsc device matches the speed of the external
port on the underlying vswitch. Therefore 1G, 10G, 25G, 56G and
even 100G are possible.
Change-Id: I14ab6907b7d8d350b63a083409d45fb9c348a364
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Stephen Hemminger [Fri, 19 Oct 2018 19:29:57 +0000 (12:29 -0700)]
dpdk: turn off unused DPDK components
DPDK has added a lot more drivers and config options that are not
used by current VPP code.
Change-Id: I385f8b5df02b95a31ca9abe506c79cf52e99a24c
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Andrew Yourtchenko [Sat, 6 Oct 2018 07:26:02 +0000 (09:26 +0200)]
acl-plugin: use the L2 feature arc infrastructure instead of L2 classifier for plumbing
This makes ACL plugin use the new feature arcs, which slightly increases performance.
Since for ethertype whitelisting we were using the L2 classifier, to retain
the functionality, make a simple node doing that, and plug it into non-ip
L2 feature arc whenever needed.
Change-Id: I3add377a6c790117dd3fd056e5615cb4c4438cf4
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Andrew Yourtchenko [Tue, 16 Oct 2018 10:04:51 +0000 (12:04 +0200)]
pipes: fix the l2.l2_len and the l[23]_hdr_offset setting behavior of pipe-rx node to match that of ethernet-input node
Since pipe-rx is a sibling node of ethernet-input, it ought to perform similarly: set l2/l3 header offsets,
and l2.l2_len value if the interface is in the l2 mode.
The use cases of pipes do not assume the tagged traffic, so
assume the simple ethernet header.
Change-Id: I7c9b5f4f2b1402cfbd10513f76cdd59b2db7a7a6
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Stephen Hemminger [Fri, 19 Oct 2018 20:20:12 +0000 (13:20 -0700)]
dpdk: use rx/tx_offload_names to format
Rather than keeping our own list of offload capabalities, use the
function in 18.08 or later to decode the value.
Also, introduce a formatter to convert to lower case because
DPDK API returns upper case names.
Change-Id: I87546fa2bec67f8a8b44288f5994514114cb6faf
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Damjan Marion [Fri, 19 Oct 2018 14:50:41 +0000 (16:50 +0200)]
avf: fix crash in rss key calculation
Change-Id: Id13a0b6ed54885babf679f05207170e36709d9fa
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 19 Oct 2018 10:54:42 +0000 (12:54 +0200)]
vppinfra: use memfd_create for hugepage mounts if supported
Starting with kernel 4.14 hugepage fd can be retrieved with
memfd_systemcall
Change-Id: I0f3bd6d0a7757ffe7b98e83763502013ac763ecb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Fri, 19 Oct 2018 11:01:19 +0000 (04:01 -0700)]
NAT44: fix ICMP virtual fragmentation reassembly (VPP-1466)
Change-Id: I8006bca02948d9121f474a3d14f0576747bb3c51
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Sirshak Das [Wed, 3 Oct 2018 22:53:51 +0000 (22:53 +0000)]
vppinfra: add atomic macros for __sync builtins
This is first part of addition of atomic macros with only macros for
__sync builtins.
- Based on earlier patch by Damjan (https://gerrit.fd.io/r/#/c/10729/)
Additionally
- clib_atomic_release macro added and used in the absence
of any memory barrier.
- clib_atomic_bool_cmp_and_swap added
Change-Id: Ie4e48c1e184a652018d1d0d87c4be80ddd180a3b
Original-patch-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Dave Barach [Thu, 18 Oct 2018 19:37:49 +0000 (15:37 -0400)]
Add pool_get_zero, pool_get_aligned_zero macros
Shorthand for the pattern:
pool_get (<pool>, ep);
memset (ep, 0, sizeof(*ep));
Should have done this years ago.
Change-Id: Ideeb27a79ff4ca3e9a077c973b297671d1fa2d26
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Thu, 18 Oct 2018 06:34:54 +0000 (23:34 -0700)]
tcp: fix sacks lost bytes counting (VPP-1465)
Change-Id: Ie46b3a81de4ed39b7b40e3879436f7e5a2908d98
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Wed, 17 Oct 2018 21:53:11 +0000 (14:53 -0700)]
tls: fix connection failures/interrupts at scale (VPP-1464)
Change-Id: I0bc4062c1fd3202ee201acb36a2bb14fc6ee1543
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Wed, 17 Oct 2018 17:41:28 +0000 (10:41 -0700)]
tcp: fix cleanup of non established connections (VPP-1463)
- fix delete of connection in syn-received
- fix delete of half-open connection
Change-Id: I72ff4b60406a2762d998328c52f41adea40d2c1b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Thu, 18 Oct 2018 09:18:06 +0000 (02:18 -0700)]
Ping; remove unused arrays
Change-Id: I104f2b4e0b1c354d3671962be3f6002f2721388d
Signed-off-by: Neale Ranns <nranns@cisco.com>
Ole Troan [Tue, 16 Oct 2018 12:42:50 +0000 (14:42 +0200)]
PAPI: Expose API enums to tests / applications
e.g:
from vpp_papi import VppEnum
VppEnum.vl_api_address_family_t.ADDRESS_IP4
Change-Id: I10c22d57234a1a06e98a889cf80b19085b468ed3
Signed-off-by: Ole Troan <ot@cisco.com>
Marco Varlese [Thu, 18 Oct 2018 07:37:17 +0000 (09:37 +0200)]
Update version (18.10) for API changes script
Change-Id: I41d22bfc87849e923628de08f922f7a541579fe1
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Eyal Bari [Wed, 17 Oct 2018 14:13:42 +0000 (17:13 +0300)]
vxlan:decap caching error (VPP-1462)
Change-Id: I3ef0725684bcb8ea526abe0ce62562b35a0070f5
Signed-off-by: Eyal Bari <ebari@cisco.com>
(cherry picked from commit
0d87894bf279a4678cfca6cc438583090b166f85)
Michal Cmarada [Wed, 17 Oct 2018 11:40:32 +0000 (13:40 +0200)]
fix ip6 prefix check for tap_v2
Change-Id: Ifbb1393fc3c50c140c09e8baedcd4a92189ba56e
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Marco Varlese [Wed, 17 Oct 2018 09:21:32 +0000 (11:21 +0200)]
Update to doxygen documentation for release 18.10
Change-Id: Id8eebd59bad27ac3cc46bf993a5ca1d8410bf84c
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
(cherry picked from commit
44c6ca6038776787671e78e3dae78e812c72429e)
Neale Ranns [Wed, 17 Oct 2018 06:38:00 +0000 (06:38 +0000)]
IP Route add/del API is MP safe
Change-Id: I0bfa4c9a3bb22155d7862cc13019cb172e77407c
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Wed, 17 Oct 2018 03:30:31 +0000 (20:30 -0700)]
tcp: fix multiple fin retries (VPP-1461)
Change-Id: I1be7c59df7b48875f81ebeebf5f39ed15a43d2d8
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Wed, 17 Oct 2018 07:28:23 +0000 (09:28 +0200)]
stats: vpp_get_stats missing last interface in dump
Change-Id: Ie1fa560cb255a9b13ddb4929da8f33286a8c137e
Signed-off-by: Ole Troan <ot@cisco.com>
Andrew Yourtchenko [Tue, 16 Oct 2018 15:18:26 +0000 (17:18 +0200)]
acl-plugin: tuplemerge: refresh the pointer to hash-readied ACL entries per each collision in split_partition() (VPP-1458)
A pointer to hash-ready ACL rules is only set once, which might cause a crash if there are colliding entries
from more than one ACL applied.
Solution: reload the pointer based on the element being processed.
Change-Id: I7a701c2c3b4236d67293159f2a33c4f967168953
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit
84112dd4f98e5a31a8c7340a741f89e77fd03363)
Florin Coras [Wed, 17 Oct 2018 02:52:10 +0000 (19:52 -0700)]
tcp: avoid sack processing when not needed (VPP-1460)
Change-Id: If81ee34e1f1e929de1a5b758ddb9aede4002e858
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Sat, 6 Oct 2018 12:33:18 +0000 (14:33 +0200)]
bond: tx optimizations
Break up bond tx function into multiple small workloads:
1. parse the packet header and hash it based on the configured algorithm
2. optionally, trace the packet
3. convert the hash value from (1) to the slave port
4. update the buffers with the slave sw_if_index
5. Add the buffers to the queues
6. Create and send the frames
old numbers
-----------
Time 5.3, average vectors/node 223.74, last 128 main loops 40.00 per node 222.61
vector rates in 3.3627e6, out 6.6574e6, drop 3.3964e4, punt 0.0000e0
Name State Calls Vectors Suspends Clocks Vectors/Call
BondEthernet0-output active 68998
17662979 0 1.89e1 255.99
BondEthernet0-tx active 68998
17662979 0 2.60e1 255.99
TenGigabitEthernet3/0/1-output active 68998
8797416 0 1.03e1 127.50
TenGigabitEthernet3/0/1-tx active 68998
8797416 0 7.85e1 127.50
TenGigabitEthernet7/0/1-output active 68996
8865563 0 1.02e1 128.49
TenGigabitEthernet7/0/1-tx active 68996
8865563 0 7.65e1 128.49
new numbers
-----------
BondEthernet0-output active 304064
77840384 0 2.29e1 256.00
BondEthernet0-tx active 304064
77840384 0 2.47e1 256.00
TenGigabitEthernet3/0/1-output active 304064
38765525 0 1.03e1 127.49
TenGigabitEthernet3/0/1-tx active 304064
38765525 0 7.66e1 127.49
TenGigabitEthernet7/0/1-output active 304064
39074859 0 1.01e1 128.51
Change-Id: I3ef9a52bfe235559dae09d055c03c5612c08a0f7
Signed-off-by: Damjan Marion <damarion@cisco.com>
mu.duojiao [Wed, 17 Oct 2018 02:59:09 +0000 (10:59 +0800)]
VPP-1459:Ip4 lookup fail when exist prefix cover.
Change-Id: I4ba0aeb65219596475345e42b8cd34019f5594c6
Signed-off-by: mu.duojiao <mu.duojiao@zte.com.cn>
Florin Coras [Tue, 16 Oct 2018 04:35:42 +0000 (21:35 -0700)]
tls: fix multi threaded medium scale test (VPP-1457)
- ensure session enqueue epoch does not wrap between two enqueues
- use 3 states for echo clients app, to distinguish between starting and
closing phases
- force tcp fin retransmit if out of buffers while sending a fin
Change-Id: I6f2cab46affd1148aba2a33fb6d58bcc54f32805
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Tue, 16 Oct 2018 13:14:03 +0000 (15:14 +0200)]
PAPI: Add bool type support in vppapigen.
Change-Id: I9c2eaa2ee04a1c9a92018afb92cb2c5610df2991
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 16 Oct 2018 13:16:07 +0000 (15:16 +0200)]
PAPI: Add timeout support for socket transport
Change-Id: I0402989e0ac738cab2f918e6e3d73c571457c08e
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Mon, 24 Sep 2018 12:36:26 +0000 (12:36 +0000)]
FIB: use vlib-log for debugging
Change-Id: I9052202b8cbcf656e61d635253d515f0f3a8d145
Signed-off-by: Neale Ranns <nranns@cisco.com>
Haiyang Tan [Mon, 15 Oct 2018 13:17:55 +0000 (06:17 -0700)]
Fix coverity issue for potentially overflowing of page size
Change-Id: I2779626d745badb63386efcf729da7a094a4f297
Signed-off-by: Haiyang Tan <haiyangtan@tencent.com>
Neale Ranns [Mon, 15 Oct 2018 12:47:58 +0000 (05:47 -0700)]
Ping; report failures to the terminal
Change-Id: Icd48de31302f62c59961c573699a1dd0474b8acb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Sat, 13 Oct 2018 19:20:01 +0000 (12:20 -0700)]
vcl: fix bidirectional tests (VPP-1455)
- add epoll dequeued events beyond maxevents to unhandled
- filter multiple epoll rx events
Change-Id: I618f5f02b19581473de891b3b59bb6a0faad10b5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Jakub Grajciar [Thu, 4 Oct 2018 09:05:35 +0000 (11:05 +0200)]
IGMP: proxy device
Create 'proxy device' per VRF and add one upstream
and one or many downstream interfaces.
Change-Id: I1cef05fb01e73a5b483c7a2f4debaaeffe2c8155
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Steven [Fri, 12 Oct 2018 17:21:32 +0000 (10:21 -0700)]
vmxnet3: show vmxnet3 with filtering capability [VPP-1452]
show vmxnet3 desc may display 5000 lines of output since it has 5 tables. Each
table may have 1000 entries. It would not be very useful to debug problem.
We need filtering capability for the subject show command. We need to be able
to display the descriptor table per interface, per interface per table, and
per interface per table per slot. The latter is the most useful.
tested the following valid combinations
show vmxnet3
show vmxnet3 desc
show vmxnet3 vmxnet3-0/13/0/0
show vmxnet3 vmxnet3-0/13/0/0 desc
show vmxnet3 vmxnet3-0/13/0/0 rx-comp
show vmxnet3 vmxnet3-0/13/0/0 rx-comp 1
show vmxnet3 vmxnet3-0/13/0/0 tx-comp
show vmxnet3 vmxnet3-0/13/0/0 tx-comp 1
show vmxnet3 vmxnet3-0/13/0/0 rx-desc-0
show vmxnet3 vmxnet3-0/13/0/0 rx-desc-0 1
show vmxnet3 vmxnet3-0/13/0/0 rx-desc-1
show vmxnet3 vmxnet3-0/13/0/0 rx-desc-1 1
show vmxnet3 vmxnet3-0/13/0/0 tx-desc
show vmxnet3 vmxnet3-0/13/0/0 tx-desc 1
negative tests and command is rejected
show vmxnet3 abc
show vmxnet3 desc abc
show vmxnet3 vmxnet3-0/13/0/0 abc
show vmxnet3 vmxnet3-0/13/0/0 desc abc
show vmxnet3 vmxnet3-0/13/0/0 rx-comp abc
show vmxnet3 vmxnet3-0/13/0/0 rx-comp 1 abc
Change-Id: I0ff233413496e58236f8fb4a94e493494c20c5cb
Signed-off-by: Steven <sluong@cisco.com>
Steven [Mon, 15 Oct 2018 17:22:53 +0000 (10:22 -0700)]
vmxnet3: vmxnet3_test_plugin.so: undefined symbol: format_vlib_pci_addr [VPP-1456]
When using vpp_api_test, there is an undefined symbol error for
format_vlib_pci_addr when vmxnet3_test_plugin.so is loaded.
The cause is due to vlib not included in vpp_api_test. Remove the reference
for vlib.so in vmxnet3_test.
Change-Id: I37c00dfe2f843d99ad6c4fc7af6ed10bac4c2df8
Signed-off-by: Steven <sluong@cisco.com>
(cherry picked from commit
3d29e83112a349b7d27ef792463f246b18115d3e)
Neale Ranns [Mon, 8 Oct 2018 14:51:11 +0000 (14:51 +0000)]
Sticky Load-balance
keep the number of buckets in the load-balanced fixed. If a
path goes dwon fill its buckets with those from the next
available up path.
Change-Id: I15603ccb899fa9b77556b898c99136379cf32eae
Signed-off-by: Neale Ranns <nranns@cisco.com>
Andrew Yourtchenko [Sat, 6 Oct 2018 07:18:00 +0000 (09:18 +0200)]
vnet: create L2 feature arc infrastructure
This commit adds two new nodes in the L2
datapath in input and output direction respectively.
These nodes fork the traffic into three feature
arcs: ip4, ip6 and nonip, which later join
to continue the usual L2 processing.
The vnet_l2_feature_enable_disable() function
with the same signature as
vnet_feature_enable_disable() takes care of
enabling the L2 datapath feature bits as needed, when
the features are enabled/disabled.
Thus, L2 features may use the similar plumbing as
the L3 features enjoy.
Change-Id: I76877b3a92d794c492bff1622bb26acba05705b2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Stephen Hemminger [Fri, 12 Oct 2018 23:43:58 +0000 (16:43 -0700)]
dpdk: drop no longer used config options
DPDK has switched to dynamic logging for initialization (since 18.05).
Don't generate config for unused options.
Change-Id: I3f1a5b3b8bee38abc9d0654737b59368646ed0fa
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Stephen Hemminger [Fri, 12 Oct 2018 00:04:13 +0000 (17:04 -0700)]
dpdk: only look at PCI information on PCI devices
The rte_device is use as a base type of all DPDK devices.
It is not valid to use container_of to find PCI information
unless the bus of the rte_device is pci. Otherwise, the
pointer is looking at some other data, which may or may not
be zero.
This change introduces a helper function to get rte_pci_device
pointer. If device is on PCI bus it returns pointer to
rte_pci_device info, otherwise it returns NULL.
Change-Id: Ia7446006bb93a7a54844969f3b3dd3b918890dfd
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
mu.duojiao [Thu, 11 Oct 2018 06:27:30 +0000 (14:27 +0800)]
VPP-1448: Fix error when recurse on down the trie.
Change-Id: Idfed8243643780d3f52dfe6e6ec621c440daa6ae
Signed-off-by: mu.duojiao <mu.duojiao@zte.com.cn>
Eyal Bari [Sun, 14 Oct 2018 07:54:32 +0000 (10:54 +0300)]
vxlan:fix ip6 tunnel deletion
Change-Id: I70fb7394f85b26f7e632d74fc31ef83597efdd16
Signed-off-by: Eyal Bari <ebari@cisco.com>
Andrew Yourtchenko [Sat, 6 Oct 2018 07:24:28 +0000 (09:24 +0200)]
acl-plugin: make each test in test_acl_plugin runnable separately
And improve the robustness of the ethertype whitelist test coverage
Change-Id: I64fe3a25208dbc619ae5cd6404f6122e69394a38
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Florin Coras [Fri, 12 Oct 2018 15:36:20 +0000 (08:36 -0700)]
session: mark apis for deprecation
Change-Id: I913ffc963928b74cf4753b6b9a0eed4436887e04
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 12 Oct 2018 20:09:36 +0000 (13:09 -0700)]
vcl: fix empty epoll returns (VPP-1453)
Change-Id: I0b191ddb749b1aa132c2d33b8359c146b36d27af
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 12 Oct 2018 23:55:14 +0000 (16:55 -0700)]
session: don't wait indefinitely for apps to consume evts (VPP-1454)
Change-Id: I544b24d2b2c4a09829773cf180d1747f4b087d4c
Signed-off-by: Florin Coras <fcoras@cisco.com>
Andrew Yourtchenko [Wed, 10 Oct 2018 14:15:55 +0000 (16:15 +0200)]
vnet: complete the fix for l3_hdr_offset calculation for single loop fastpass case (VPP-1444)
20e6d36b has moved the calculation of the l3_hdr_offset into the determine_next_node()
function, with the assumption that the current_data in the buffer is at
the L3 header. This is not the case for the single loop fastpath,
where the vlib_buffer_advance() call is made after the call to
determine_next_node(), as a day1 behavior. As a result - that path
incorrectly sets the l3_hdr_offset.
Solution: move the vlib_buffer_advance() call to before determine_next_node()
Change-Id: Id5eaa084c43fb6564f8239df4a0b3dc0412b15de
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit
376414f4c3f53af44da4e82ee5d0b1843b291f8e)
Matus Fabian [Wed, 3 Oct 2018 06:27:21 +0000 (23:27 -0700)]
ip: add container proxy dump API (VPP-1364)
Change-Id: I3cb89dbfb7174b9913a8c4ad9b3b1dc9f6ed6326
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Stephen Hemminger [Thu, 11 Oct 2018 17:01:04 +0000 (10:01 -0700)]
dpdk: support passing log-level
Since DPDK 17.05, DPDK logging supports per subsystem dynamic logging.
Allow passing this as log-level on EAL command line.
dpdk {
log-level pmd.net.virtio.*:debug
...
}
Change-Id: If9576c11aba390a5cd2740fc1c9da5768689bd74
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
juraj.linkes [Thu, 11 Oct 2018 08:06:44 +0000 (10:06 +0200)]
Add parallel test run info to test/doc
An overview of parallel test runs, describing the library used, results
gathering, stdout and stderr handling and how to execute a parallel run.
Change-Id: Ic83cd689751ee46914e3b858b0b24a74b083f99f
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Matus Fabian [Thu, 11 Oct 2018 11:28:48 +0000 (04:28 -0700)]
NAT44: identity NAT fix (VPP-1441)
Change-Id: Ic4affc54d15d08b9b730f6ec6146ee053b28b4b6
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Ole Troan [Thu, 11 Oct 2018 20:08:50 +0000 (22:08 +0200)]
Stats: Include stat_segment.h in packages.
Change-Id: I976c0aba8397badf64763c4dbddce67009a4fb23
Signed-off-by: Ole Troan <ot@cisco.com>
Damjan Marion [Thu, 11 Oct 2018 16:18:26 +0000 (09:18 -0700)]
Fix vpp-ext-deps package version in stable branch
Change-Id: Ifb33622b50113501f1d23ab94ba9da708678d6be
Signed-off-by: Damjan Marion <damarion@cisco.com>
(cherry picked from commit
5551e41f78249b72715203ecd93586f48acccbf4)
Eyal Bari [Thu, 11 Oct 2018 11:09:58 +0000 (14:09 +0300)]
bfd:fix handling session creation batch
when multiple session creating script is ran (via exec) only the first
one actually starts
Change-Id: I0fc36f65795c8921cf180e0b555c446e5a80be45
Signed-off-by: Eyal Bari <ebari@cisco.com>
Neale Ranns [Wed, 10 Oct 2018 15:55:01 +0000 (15:55 +0000)]
L2: BM traffic does not use UU-FWD (VPP-1445)
Change-Id: I5495c37da2fb8ff48c4af14ccba021d64eac52b6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Haiyang Tan [Wed, 10 Oct 2018 02:09:45 +0000 (19:09 -0700)]
vppinfra: introduce clib_mem_vm_ext_free() to avoid fd leaks
Change-Id: I8691a10493d159a97574550c111f07722960a7cd
Signed-off-by: Haiyang Tan <haiyangtan@tencent.com>
Juraj Sloboda [Wed, 10 Oct 2018 08:15:54 +0000 (10:15 +0200)]
reassembly: get number of workers instead of threads (VPP-1435)
Change-Id: If3abeab2b304e2df41139707a4c8d045fab6ef99
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Steven [Wed, 10 Oct 2018 04:12:25 +0000 (21:12 -0700)]
vmxnet3: better error handling
try harder on output - if there is no descriptor space available, try to free
up some and check again.
make sure we free the buffer if error is encoutered on input.
Change-Id: I41a45213e29de71935afe707889e515037cd081f
Signed-off-by: Steven <sluong@cisco.com>
juraj.linkes [Fri, 21 Sep 2018 11:55:16 +0000 (13:55 +0200)]
Setup, teardown, DEBUG=core, FAILFAST fixes
- Fixed a bug when an error occuring in tearDownClass would not result in
test being marked as failed
- Improved test results reporting in cases when an error occurs in setUpClass
and tearDownClass
- Fixed DEBUG=core when the core is produced in setUpClass or
tearDownClass
- Reworked DEBUG=core to always be handled after all tests have been
executed
- Fixed FAILFAST=1 for parallel test runs
Change-Id: I3e9cd3b97ba6fa802fa0aa2dd7678ff82eee09ec
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Neale Ranns [Wed, 10 Oct 2018 13:27:00 +0000 (13:27 +0000)]
Integer underflow and out-of-bounds read (VPP-1442)
Change-Id: Ife2a83b9d7f733f36e0e786ef79edcd394d7c0f9
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 2 Oct 2018 14:27:02 +0000 (07:27 -0700)]
L2-flood: no clone for 1 replication
Change-Id: If178dd38e7920f35588f5d821ff097168b078026
Signed-off-by: Neale Ranns <nranns@cisco.com>
Jakub Grajciar [Tue, 9 Oct 2018 10:28:21 +0000 (12:28 +0200)]
Test FW: Use unittest temp dir as unix runtime dir
Change-Id: I5273d5f3f59cc3c43da0a15bb0c4a4056098adcf
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Andrew Yourtchenko [Wed, 10 Oct 2018 08:39:36 +0000 (10:39 +0200)]
acl-plugin: reduce the syslog level for debug messages
Change-Id: Ie8380cb39424548bf64cb19aee59ec20e29d1e39
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Sirshak Das [Tue, 9 Oct 2018 16:28:44 +0000 (11:28 -0500)]
vppinfra: Fix extendto_high aarch64 NEON api.
This fixes the l2BD and ip4 test case failures.
Fixes VPP-1432, VPP-1428, VPP-1430
Change-Id: I48b5c961bab60cc3b39fcd6db47e098c81579480
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Jakub Grajciar [Tue, 9 Oct 2018 08:02:46 +0000 (10:02 +0200)]
memif: coverity fix
Change-Id: I2b14e2a035a37b04816aac1e610146be58ad1e92
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Ole Troan [Mon, 8 Oct 2018 09:24:22 +0000 (11:24 +0200)]
API: Spurious timeouts from timeout thread.
Change-Id: I1be1101ba4d82688a32b5ae2c39ca5d92dc244b7
Signed-off-by: Ole Troan <ot@cisco.com>
Andrew Yourtchenko [Fri, 5 Oct 2018 18:36:03 +0000 (20:36 +0200)]
vnet: ethernet-input incorrectly sets l3_hdr_offset in some cases
The issue surfaced when developing the tap GSO code, with
an iteration where output path is reliant on
vnet_buffer (b0)->l3_hdr_offset being set correctly in
the input path, during performance testing.
Adding a workaround in the TX path shows that
the issue surfaces only for relatively few packets
during the test (about 100 out of 600000).
Analysis shows the issue arises if the ethernet-input
is handling two untagged packets with different sw_if_index
values - then the accelerated path punts to slow path,
before the setting of the l2.l2_len values is done,
thus resulting in them being 0, and l3_hdr_offset being
the same as l2_hdr_offset, wreaking havoc on TX path.
The solution is to move the l2_hdr_offset calculation
into a place where it is done for all the packets,
and move the l3_hdr_offset calculation into
the determine_next_node() function - as that function is
also the one setting the special-case l2.l2_len value for
tagged packets and moving the current_data for the L2 case.
Change-Id: If728c7715e011930c1887691188c98055bddde67
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Jakub Grajciar [Mon, 8 Oct 2018 11:35:32 +0000 (13:35 +0200)]
memif: socket filename add/del bugfix
Check access rights using effective user/group IDs
Change-Id: I3683258c24bcd7817024bffbd56b54b2f596fdd7
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Vijayabhaskar Katamreddy [Fri, 5 Oct 2018 18:24:56 +0000 (11:24 -0700)]
Adding Multipath support for exclusive DPO based fib path entries via rpath
Change-Id: I3c84daf046dbad972b36e48fa2548bbe20c7b338
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Hongjun Ni [Mon, 8 Oct 2018 10:28:37 +0000 (18:28 +0800)]
Fix coverity issue for NSH plugin
Change-Id: Ie99ff9aebe3c896e3e104a5a7bebd84f7766e713
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Ole Troan [Mon, 8 Oct 2018 07:16:44 +0000 (09:16 +0200)]
Stats: prometheus export coverity errors.
Change-Id: Ibc0a25dcf7d734215e0cffe789b5726f23e1c3d7
Signed-off-by: Ole Troan <ot@cisco.com>
Matus Fabian [Mon, 8 Oct 2018 04:28:23 +0000 (21:28 -0700)]
NAT44: do not create session record for identity mapping (VPP-1439)
Change-Id: I39a3146a4e4ba8eadf50af7113b9ae6b1c1d688f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Neale Ranns [Mon, 8 Oct 2018 06:08:59 +0000 (06:08 +0000)]
replicate trace fix
Change-Id: I785ecadbf30812a500629870aa717e64f4cf0cdd
Signed-off-by: Neale Ranns <nranns@cisco.com>