Merge "Do not skip commit-message-only checkstyle"

diff --combined jjb/vpp/vpp.yaml
index 2afb5c7,dc1672e..a866115
--- 1/jjb/vpp/vpp.yaml
--- 2/jjb/vpp/vpp.yaml
+++ b/jjb/vpp/vpp.yaml
@@@ -30,7 -30,6 +30,7 @@@
      name: vpp-clang
      jobs:
        - 'vpp-verify-{stream}-clang'
 +      - 'vpp-coverity-{stream}'
  
      project: 'vpp'
      os:
@@@ -64,7 -63,7 +64,7 @@@
        - '1908':
            branch: 'stable/1908'
            repo-stream-part: 'stable.1908'
 -    os: ubuntu1604
 +    os: ubuntu1804
  
  - project:
      name: vpp-perpatch
@@@ -182,7 -181,16 +182,7 @@@
      project-type: freestyle
      node: '{os}-us'
      concurrent: true
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -      **/tmp/vpp-failed-unittests/*/* **/core
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
  
      triggers:
        - gerrit-trigger-checkstyle:
@@@ -242,6 -250,15 +242,6 @@@
  
      project-type: freestyle
      node: '{os}-us'
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -316,7 -333,15 +316,7 @@@
      project-type: freestyle
      node: '{os}arm-us'
      concurrent: true
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -367,6 -392,7 +367,6 @@@
      publishers:
        - fdio-infra-shiplogs:
            maven-version: 'mvn36'
 -          archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
        - naginator:
            rerun-unstable-builds: false
            max-failed-builds: 1
@@@ -377,6 -403,15 +377,6 @@@
  
      project-type: freestyle
      node: '{os}arm-m'
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -453,7 -488,6 +453,7 @@@
      project-type: freestyle
      node: '{os}-us'
      concurrent: true
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -469,7 -503,7 +469,7 @@@
        - os-parameter:
            os: '{os}'
        - repo-name-parameter:
 -          repo-name: '{repo-stream-part}.ubuntu.xenial.main'
 +          repo-name: '{repo-stream-part}.ubuntu.bionic.main'
  
      scm:
        - gerrit-trigger-scm:
@@@ -488,7 -522,7 +488,7 @@@
              - patchset-created-event:
                  exclude-drafts: 'true'
                  exclude-trivial-rebase: 'false'
-                 exclude-no-code-change: 'true'
+                 exclude-no-code-change: 'false'
              - draft-published-event
              - comment-added-contains-event:
                  comment-contains-value: 'checkstylecheck'
@@@ -543,6 -577,7 +543,6 @@@
      publishers:
        - fdio-infra-shiplogs:
            maven-version: 'mvn36'
 -          archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
        - naginator:
            rerun-unstable-builds: true
            max-failed-builds: 1
@@@ -554,7 -589,15 +554,7 @@@
      project-type: freestyle
      node: '{os}-us'
      concurrent: true
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -604,6 -647,7 +604,6 @@@
      publishers:
        - fdio-infra-shiplogs:
            maven-version: 'mvn36'
 -          archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
        - naginator:
            rerun-unstable-builds: false
            max-failed-builds: 2
@@@ -615,7 -659,6 +615,7 @@@
      project-type: freestyle
      node: 'ubuntu1804-us'
      concurrent: true
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -629,7 -672,7 +629,7 @@@
        - gerrit-parameter:
            branch: '{branch}'
        - os-parameter:
 -          os: 'ubuntu1604'
 +          os: 'ubuntu1804'
        - repo-name-parameter:
            repo-name: '{repo-stream-part}.ubuntu.bionic.main'
        - stream-parameter:
@@@ -661,115 -704,26 +661,115 @@@
      publishers:
        - fdio-infra-shiplogs:
            maven-version: 'mvn36'
 -          archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
        - naginator:
            rerun-unstable-builds: false
            max-failed-builds: 1
            fixed-delay: 90
  
 +- job-template:
 +    name: 'vpp-coverity-{stream}'
 +
 +    project-type: freestyle
 +    node: 'ubuntu1804-us'
 +    concurrent: true
 +    archive-artifacts: '/tmp/vpp-failed-unittests/*/* **/core'
 +
 +    build-discarder:
 +      daysToKeep: '{build-days-to-keep}'
 +      numToKeep: '{build-num-to-keep}'
 +      artifactDaysToKeep: '{build-artifact-days-to-keep}'
 +      artifactNumToKeep: '{build-artifact-num-to-keep}'
 +
 +    parameters:
 +      - project-parameter:
 +          project: '{project}'
 +      - gerrit-parameter:
 +          branch: '{branch}'
 +      - os-parameter:
 +          os: 'ubuntu1804'
 +      - repo-name-parameter:
 +          repo-name: '{repo-stream-part}.ubuntu.bionic.main'
 +      - stream-parameter:
 +          stream: '{stream}'
 +
 +    scm:
 +      - gerrit-trigger-scm:
 +          credentials-id: 'jenkins-gerrit-credentials'
 +          refspec: ''
 +          choosing-strategy: 'gerrit'
 +
 +    wrappers:
 +      - fdio-infra-wrappers:
 +          build-timeout: '{build-timeout}'
 +
 +    triggers:
 +      - timed: '0 14 * * *'
 +
 +    builders:
 +      - shell:
 +          command: !include-raw-escape: include-raw-vpp-coverity.sh
 +          unstable-return: 42
 +
 +    publishers:
 +      - email-ext:
 +          # yamllint disable-line rule:line-length
 +          recipients: 'ejk@cisco.com'
 +          reply-to: ''
 +          content-type: 'text'
 +          subject: 'Coverity run passing as of $BUILD_TIMESTAMP'
 +          # yamllint disable-line rule:line-length
 +          body: |
 +                Coverity run passing.
 +
 +                ${{FILE,path="output.txt"}}
 +          failure: false
 +          success: true
 +      - email-ext:
 +          # yamllint disable-line rule:line-length
 +          recipients: 'ejk@cisco.com'
 +          reply-to: ''
 +          content-type: 'text'
 +          subject: 'Coverity run UNSTABLE as of $BUILD_TIMESTAMP'
 +          # yamllint disable-line rule:line-length
 +          body: |
 +                Coverity run UNSTABLE.
 +
 +                Something went wrong with daily scan.
 +          failure: false
 +          unstable: true
 +      - email-ext:
 +          # yamllint disable-line rule:line-length
 +          recipients: 'vpp-dev@lists.fd.io, ejk@cisco.com'
 +          reply-to: ''
 +          content-type: 'text'
 +          subject: 'Coverity run FAILED as of $BUILD_TIMESTAMP'
 +          # yamllint disable-line rule:line-length
 +          body: |
 +                Coverity run failed today.
 +
 +                ${{FILE,path="output.txt"}}
 +          failure: true
 +      - email-ext:
 +          # yamllint disable-line rule:line-length
 +          recipients: 'vpp-dev@lists.fd.io, ejk@cisco.com'
 +          reply-to: ''
 +          content-type: 'text'
 +          subject: 'Coverity run as of $BUILD_TIMESTAMP'
 +          # yamllint disable-line rule:line-length
 +          body: |
 +                Coverity run fixed today.
 +
 +                ${{FILE,path="output.txt"}}
 +          failure: false
 +          fixed: true
 +      - fdio-infra-shiplogs:
 +          maven-version: 'mvn36'
 +
  - job-template:
      name: 'vpp-merge-{stream}-{os}'
  
      project-type: freestyle
      node: '{os}-us'
 -    archive-artifacts: >
 -      **/build-root/*.rpm
 -      **/build-root/*.deb
 -      **/dpdk/*.rpm
 -      **/dpdk/*.deb
 -    allow-empty: 'true'
 -    fingerprint: false
 -    only-if-success: true
 -    default-excludes: false
  
      build-discarder:
        daysToKeep: '{build-days-to-keep}'
@@@ -878,6 -832,9 +878,6 @@@
            name: ARCHIVE_ARTIFACTS
            default: '{archive-artifacts}'
            description: Artifacts to archive to the logs server.
 -      # The API CRC job fails on mismatch, we hunt for real incompatibilities.
 -      - csit-fail-on-crc-mismatch-parameter:
 -          fail-on-crc-mismatch: 'False'
  
      scm:
        - gerrit-trigger-scm:
@@@ -956,6 -913,9 +956,6 @@@
            name: ARCHIVE_ARTIFACTS
            default: '{archive-artifacts}'
            description: Artifacts to archive to the logs server.
 -      # The API CRC job fails on mismatch, try compare API versions if possible.
 -      - csit-fail-on-crc-mismatch-parameter:
 -          fail-on-crc-mismatch: 'False'
  
      scm:
        - gerrit-trigger-scm:
@@@ -1016,10 -976,6 +1016,10 @@@
            name: ARCHIVE_ARTIFACTS
            default: '{archive-artifacts}'
            description: Artifacts to archive to the logs server.
 +      # Not sure whether not failing has any useful usage,
 +      # but it does not hurt to have some flexibility for future.
 +      - csit-fail-on-crc-mismatch-parameter:
 +          fail-on-crc-mismatch: 'True'
  
      scm:
        - gerrit-trigger-scm: