Autogen checker: Fix difference reporting branch 39/22839/1
authorVratko Polak <vrpolak@cisco.com>
Fri, 18 Oct 2019 13:34:51 +0000 (15:34 +0200)
committerVratko Polak <vrpolak@cisco.com>
Fri, 18 Oct 2019 13:34:51 +0000 (15:34 +0200)
Change-Id: I85da5ec38643524fa1af7ed7628025a4a52463f5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
resources/libraries/bash/entry/check/autogen.sh

index 0164b65..822c50c 100644 (file)
@@ -50,10 +50,11 @@ cp -rf "${CSIT_DIR}/tests"/* "${GENERATED_DIR}/tests_tmp"/
 # I think archiving the diff is enough.
 
 diff_cmd=("diff" "-dur" "${GENERATED_DIR}/tests_tmp" "${GENERATED_DIR}/tests")
-lines="$("${diff_cmd[@]}" | tee "autogen.log" | wc -l)" || die
+# Diff returns RC=1 if output is nonzero, so we do not die on the next line.
+lines="$("${diff_cmd[@]}" | tee "autogen.log" | wc -l)"
 if [ "${lines}" != "0" ]; then
     # TODO: Decide which text goes to stdout and which to stderr.
-    warn "Autogen conflict diff nonzero lines: ${lines}"
+    warn "Autogen conflict, diff sees nonzero lines: ${lines}"
     # TODO: Disable if output size does more harm than good.
     cat "autogen.log" >&2
     warn