Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 8563cb3) | patch
vppinfra: fix page boundary crossing bug in hash_memory64 33/22633/5
authorDave Barach <dave@barachs.net>
Wed, 9 Oct 2019 16:57:13 +0000 (12:57 -0400)
committerDamjan Marion <dmarion@me.com>
Fri, 11 Oct 2019 12:30:58 +0000 (12:30 +0000)
commit7e2cea3d26701ff1d80fda7d8ca907890e3e7baa
tree49dfbace1a56e09ef46402573090f9880fa57f2ftree | snapshot
parent8563cb389a7e8d6d4e042e146c0d94b8af98ca7acommit | diff
vppinfra: fix page boundary crossing bug in hash_memory64

Fix a day-1 bug, possibly dating back as far as 2002. The zap64() game
involves fetching 8 byte chunks, and clearing octets not to be
included in the key.

That's fine *unless* the 8-byte fetch happens to cross a page boundary
into unmapped or no-access space.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4607e9840032257c96ba7387f86c931c0921749d
src/plugins/unittest/util_test.c diff | blob | history
src/vppinfra/hash.c diff | blob | history
Vector Packet Processing