qos mark/record: fix disable-sw_if_index range check 36/13536/4
authorEyal Bari <ebari@cisco.com>
Wed, 18 Jul 2018 14:15:26 +0000 (17:15 +0300)
committerJohn Lo <loj@cisco.com>
Wed, 18 Jul 2018 21:09:35 +0000 (21:09 +0000)
Change-Id: I2abb3ceebae3a32cee9aa2a999bd47c37719d3ac
Signed-off-by: Eyal Bari <ebari@cisco.com>
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
src/vnet/qos/qos_mark.c
src/vnet/qos/qos_record.c

index cec7192..5dc87e8 100644 (file)
@@ -361,7 +361,7 @@ qos_mark_enable (u32 sw_if_index,
 int
 qos_mark_disable (u32 sw_if_index, qos_source_t output_source)
 {
-  if (vec_len (qos_mark_configs[output_source]) < sw_if_index)
+  if (vec_len (qos_mark_configs[output_source]) <= sw_if_index)
     return VNET_API_ERROR_NO_MATCHING_INTERFACE;
   if (INDEX_INVALID == qos_mark_configs[output_source][sw_if_index])
     return VNET_API_ERROR_VALUE_EXIST;
index c69b4f1..7181e3b 100644 (file)
@@ -68,7 +68,7 @@ qos_record_enable (u32 sw_if_index, qos_source_t input_source)
 int
 qos_record_disable (u32 sw_if_index, qos_source_t input_source)
 {
-  if (vec_len (qos_record_configs[input_source]) < sw_if_index)
+  if (vec_len (qos_record_configs[input_source]) <= sw_if_index)
     return VNET_API_ERROR_NO_MATCHING_INTERFACE;
 
   if (0 == qos_record_configs[input_source][sw_if_index])