VOM: GBP-bridge-domain fix 47/16547/2
authorNeale Ranns <nranns@cisco.com>
Wed, 19 Dec 2018 12:27:15 +0000 (04:27 -0800)
committerNeale Ranns <nranns@cisco.com>
Wed, 19 Dec 2018 15:26:53 +0000 (15:26 +0000)
Change-Id: I504efbf214d891f4be2f1658a90a19b13764ab37
Signed-off-by: Neale Ranns <nranns@cisco.com>
extras/vom/vom/gbp_bridge_domain.cpp
extras/vom/vom/gbp_route_domain.cpp

index 953c40c..d9ea487 100644 (file)
@@ -136,12 +136,9 @@ void
 gbp_bridge_domain::replay()
 {
   if (rc_t::OK == m_id.rc()) {
-    if (m_bvi && m_uu_fwd)
-      HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(m_id, m_bvi->handle(),
-                                                         m_uu_fwd->handle()));
-    else
-      HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(
-        m_id, handle_t::INVALID, handle_t::INVALID));
+    HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(
+      m_id, (m_bvi ? m_bvi->handle() : handle_t::INVALID),
+      (m_uu_fwd ? m_uu_fwd->handle() : handle_t::INVALID)));
   }
 }
 
@@ -182,12 +179,9 @@ gbp_bridge_domain::update(const gbp_bridge_domain& desired)
    * the desired state is always that the interface should be created
    */
   if (rc_t::OK != m_id.rc()) {
-    if (m_bvi && m_uu_fwd)
-      HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(m_id, m_bvi->handle(),
-                                                         m_uu_fwd->handle()));
-    else
-      HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(
-        m_id, handle_t::INVALID, handle_t::INVALID));
+    HW::enqueue(new gbp_bridge_domain_cmds::create_cmd(
+      m_id, (m_bvi ? m_bvi->handle() : handle_t::INVALID),
+      (m_uu_fwd ? m_uu_fwd->handle() : handle_t::INVALID)));
   }
 }
 
index 46208b7..873cea6 100644 (file)
@@ -141,9 +141,9 @@ gbp_route_domain::to_string() const
   s << "gbp-route-domain:[" << m_rd->to_string();
 
   if (m_ip4_uu_fwd)
-    s << " v4-uu:" << m_ip4_uu_fwd->to_string();
+    s << " v4-uu:[" << m_ip4_uu_fwd->to_string() << "]";
   if (m_ip6_uu_fwd)
-    s << " v6-uu:" << m_ip6_uu_fwd->to_string();
+    s << " v6-uu:[" << m_ip6_uu_fwd->to_string() << "]";
 
   s << "]";