fib: invalid check for adj types. 45/24745/2
authorNeale Ranns <nranns@cisco.com>
Mon, 3 Feb 2020 10:33:51 +0000 (10:33 +0000)
committerDave Barach <openvpp@barachs.net>
Mon, 3 Feb 2020 12:30:46 +0000 (12:30 +0000)
Type: fix

coverity found invalid logic.

Change-Id: Ic9144ac805a4e5a18aa299794fedda044dcb65fe
Signed-off-by: Neale Ranns <nranns@cisco.com>
src/vnet/adj/adj_midchain.c

index 33da0ed..fcd6993 100644 (file)
@@ -513,7 +513,7 @@ adj_nbr_midchain_update_rewrite (adj_index_t adj_index,
      * one time only update. since we don't support changing the tunnel
      * src,dst, this is all we need.
      */
-    if (adj->lookup_next_index != IP_LOOKUP_NEXT_MIDCHAIN ||
+    if (adj->lookup_next_index != IP_LOOKUP_NEXT_MIDCHAIN &&
         adj->lookup_next_index != IP_LOOKUP_NEXT_MCAST_MIDCHAIN)
     {
         adj_midchain_setup(adj_index, fixup, fixup_data, flags);