ip: Punt rather than drop unkown IPv6 ICMP packets 91/22991/2
authorNeale Ranns <nranns@cisco.com>
Fri, 25 Oct 2019 14:20:42 +0000 (07:20 -0700)
committerOle Trøan <otroan@employees.org>
Mon, 28 Oct 2019 16:21:44 +0000 (16:21 +0000)
Type: feature

Change-Id: Ib137c453ff2dd5b9d028c653afa80e6b2b81b9e0
Signed-off-by: Neale Ranns <nranns@cisco.com>
src/vnet/ip/icmp6.c

index 9d283ff..95baa71 100644 (file)
@@ -130,7 +130,7 @@ static char *icmp_error_strings[] = {
 
 typedef enum
 {
-  ICMP_INPUT_NEXT_DROP,
+  ICMP_INPUT_NEXT_PUNT,
   ICMP_INPUT_N_NEXT,
 } icmp_input_next_t;
 
@@ -199,7 +199,7 @@ ip6_icmp_input (vlib_main_t * vm,
 
          next0 = im->input_next_index_by_type[type0];
          error0 =
-           next0 == ICMP_INPUT_NEXT_DROP ? ICMP6_ERROR_UNKNOWN_TYPE : error0;
+           next0 == ICMP_INPUT_NEXT_PUNT ? ICMP6_ERROR_UNKNOWN_TYPE : error0;
 
          /* Check code is valid for type. */
          error0 =
@@ -223,7 +223,7 @@ ip6_icmp_input (vlib_main_t * vm,
 
          b0->error = node->errors[error0];
 
-         next0 = error0 != ICMP6_ERROR_NONE ? ICMP_INPUT_NEXT_DROP : next0;
+         next0 = error0 != ICMP6_ERROR_NONE ? ICMP_INPUT_NEXT_PUNT : next0;
 
          vlib_validate_buffer_enqueue_x1 (vm, node, next_index,
                                           to_next, n_left_to_next,
@@ -250,7 +250,7 @@ VLIB_REGISTER_NODE (ip6_icmp_input_node) = {
 
   .n_next_nodes = 1,
   .next_nodes = {
-    [ICMP_INPUT_NEXT_DROP] = "ip6-drop",
+    [ICMP_INPUT_NEXT_PUNT] = "ip6-punt",
   },
 };
 /* *INDENT-ON* */
@@ -784,7 +784,7 @@ icmp6_init (vlib_main_t * vm)
 #undef _
 
   clib_memset (cm->input_next_index_by_type,
-              ICMP_INPUT_NEXT_DROP, sizeof (cm->input_next_index_by_type));
+              ICMP_INPUT_NEXT_PUNT, sizeof (cm->input_next_index_by_type));
   clib_memset (cm->max_valid_code_by_type, 0,
               sizeof (cm->max_valid_code_by_type));