dns: fix double-unlock 34/30134/1
authorBenoît Ganne <bganne@cisco.com>
Wed, 25 Nov 2020 12:53:21 +0000 (13:53 +0100)
committerBenoît Ganne <bganne@cisco.com>
Wed, 25 Nov 2020 15:49:47 +0000 (16:49 +0100)
dns cache should no longer be unlocked by caller.

Type: fix
Fixes: 84a563ae4050cc0389dcd438fbe9ea882f2b8404

Change-Id: I3708718ae8f00e4e4f4e04381caa0095c8494b82
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/plugins/dns/dns.c

index de1862d..f063e4f 100644 (file)
@@ -1471,12 +1471,6 @@ vl_api_dns_resolve_name_t_handler (vl_api_dns_resolve_name_t * mp)
     rmp->retval = clib_host_to_net_u32 (rv);
   }));
   /* *INDENT-ON* */
-
-  /*
-   * dns_resolve_name leaves the cache locked when it returns
-   * a cached result, so unlock it here.
-   */
-  dns_cache_unlock (dm);
 }
 
 static void
@@ -1551,12 +1545,6 @@ vl_api_dns_resolve_ip_t_handler (vl_api_dns_resolve_ip_t * mp)
     rmp->retval = clib_host_to_net_u32 (rv);
   }));
   /* *INDENT-ON* */
-
-  /*
-   * vnet_dns_resolve_name leaves the cache locked when it returns
-   * a cached result, so unlock it here.
-   */
-  dns_cache_unlock (dm);
 }
 
 static clib_error_t *