Fix coverity issues in LISP 96/3596/2
authorFilip Tehlar <ftehlar@cisco.com>
Wed, 26 Oct 2016 12:58:18 +0000 (14:58 +0200)
committerFlorin Coras <florin.coras@gmail.com>
Thu, 27 Oct 2016 13:43:09 +0000 (13:43 +0000)
Change-Id: Ifef27540f02f423070e8843951be5cba0acea8cf
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
vnet/vnet/lisp-cp/gid_dictionary.c

index 0632ef0..9efc1a0 100644 (file)
@@ -39,7 +39,7 @@ foreach_sfib4_subprefix (BVT (clib_bihash_kv) * kvp, void *arg)
   ip4_address_t *mask;
   u8 plen = ip_prefix_len (&a->src);
 
-  ASSERT (plen >= 0 && plen <= 32);
+  ASSERT (plen <= 32);
   mask = &a->ip4_table->ip4_fib_masks[plen];
 
   u32 src_ip = clib_host_to_net_u32 (ip_prefix_v4 (&a->src).as_u32);
@@ -394,6 +394,7 @@ gid_dictionary_sd_lookup (gid_dictionary_t * db, gid_address_t * dst,
                        gid_address_sd_dst_type (dst));
          break;
        }
+      break;
     default:
       clib_warning ("address type %d not supported!", gid_address_type (dst));
       break;