make build failure. 26/16426/4
authorPaul Vinciguerra <pvinci@vinciconsulting.com>
Mon, 10 Dec 2018 22:50:13 +0000 (14:50 -0800)
committerDave Barach <openvpp@barachs.net>
Thu, 13 Dec 2018 14:34:15 +0000 (14:34 +0000)
[84/597] Building C object vnet/CMakeFiles/vnet.dir/ip/ip_types_api.c.o
FAILED: ccache /usr/lib/ccache/cc  -DWITH_LIBSSL=1 -Dvnet_EXPORTS -I/vpp/src -I. -Iinclude -march=corei7 -mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror -fPIC   -Wno-address-of-packed-member -Wall -MMD -MT vnet/CMakeFiles/vnet.dir/ip/ip_types_api.c.o -MF vnet/CMakeFiles/vnet.dir/ip/ip_types_api.c.o.d -o vnet/CMakeFiles/vnet.dir/ip/ip_types_api.c.o   -c /vpp/src/vnet/ip/ip_types_api.c
/vpp/src/vnet/ip/ip_types_api.c: In function 'ip_address_union_encode':
/vpp/src/vnet/ip/ip_types_api.c:70:13: error: incompatible type for argument 1 of 'memcpy'
     memcpy (out->ip6, &in->ip6, sizeof (out->ip6));
             ^
In file included from /usr/include/string.h:635:0,
                 from /vpp/src/vppinfra/string.h:55,
                 from /vpp/src/vppinfra/mem.h:55,
                 from /vpp/src/vppinfra/vec.h:42,
                 from /vpp/src/vppinfra/error.h:53,
                 from /vpp/src/vppinfra/hash.h:41,
                 from /vpp/src/vnet/ip/ip.h:43,
                 from /vpp/src/vnet/ip/ip_types_api.h:23,
                 from /vpp/src/vnet/ip/ip_types_api.c:16:
/usr/include/x86_64-linux-gnu/bits/string3.h:50:42: note: expected 'void * restrict' but argument is of type 'vl_api_ip6_address_t {aka struct _vl_api_ip6_address}'
 __NTH (memcpy (void *__restrict __dest, const void *__restrict __src,
                                          ^
/vpp/src/vnet/ip/ip_types_api.c:72:13: error: incompatible type for argument 1 of 'memcpy'
     memcpy (out->ip4, &in->ip4, sizeof (out->ip4));
             ^
In file included from /usr/include/string.h:635:0,
                 from /vpp/src/vppinfra/string.h:55,
                 from /vpp/src/vppinfra/mem.h:55,
                 from /vpp/src/vppinfra/vec.h:42,
                 from /vpp/src/vppinfra/error.h:53,
                 from /vpp/src/vppinfra/hash.h:41,
                 from /vpp/src/vnet/ip/ip.h:43,
                 from /vpp/src/vnet/ip/ip_types_api.h:23,
                 from /vpp/src/vnet/ip/ip_types_api.c:16:
/usr/include/x86_64-linux-gnu/bits/string3.h:50:42: note: expected 'void * restrict' but argument is of type 'vl_api_ip4_address_t {aka struct _vl_api_ip4_address}'
 __NTH (memcpy (void *__restrict __dest, const void *__restrict __src,
                                          ^
/vpp/src/vnet/ip/ip_types_api.c: At top level:
cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror]
cc1: all warnings being treated as errors
[84/597] Building C object vnet/CMakeFiles/vnet.dir/ip/ip4_forward.c.o
ninja: build stopped: subcommand failed.
Makefile:691: recipe for target 'vpp-build' failed
make[1]: *** [vpp-build] Error 1
make[1]: Leaving directory '/vpp/build-root'
Makefile:394: recipe for target 'test' failed
make: *** [test] Error 2

DBGvpp# show cpu
Model name:               Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Microarchitecture:        Haswell (Crystalwell)
Flags:                    sse3 ssse3 sse41 sse42 avx avx2 aes invariant_tsc
Base frequency:           2.49 GHz

DBGvpp# show version verbose
Version:                  v19.01-rc0~447-g3be662f
Compiled by:              vagrant
Compile host:             vpp
Compile date:             Mon Dec 10 14:55:24 PST 2018
Compile location:         /vpp
Compiler:                 GCC 5.4.0 20160609
Current PID:              14104

Change-Id: I6ff03bc5ad1c3517256e244b6986e9a1507a3349
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
src/plugins/igmp/igmp_api.c
src/plugins/map/map_api.c
src/vnet/ip/ip_types_api.c
src/vnet/syslog/syslog_api.c

index 8c14fab..0149b2a 100644 (file)
@@ -172,8 +172,8 @@ send_igmp_details (unix_shared_memory_queue_t * q, igmp_main_t * im,
   mp->_vl_msg_id = htons (IGMP_MSG_ID (VL_API_IGMP_DETAILS));
   mp->context = context;
   mp->sw_if_index = htonl (config->sw_if_index);
-  clib_memcpy (mp->saddr, &src->key->ip4, sizeof (src->key->ip4));
-  clib_memcpy (mp->gaddr, &group->key->ip4, sizeof (group->key->ip4));
+  clib_memcpy (&mp->saddr, &src->key->ip4, sizeof (src->key->ip4));
+  clib_memcpy (&mp->gaddr, &group->key->ip4, sizeof (group->key->ip4));
 
   vl_msg_api_send_shmem (q, (u8 *) & mp);
 }
index 8ce6428..b32b7c2 100644 (file)
@@ -179,7 +179,7 @@ vl_api_map_rule_dump_t_handler (vl_api_map_rule_dump_t * mp)
       clib_memset (rmp, 0, sizeof (*rmp));
       rmp->_vl_msg_id = ntohs (VL_API_MAP_RULE_DETAILS + mm->msg_id_base);
       rmp->psid = htons (i);
-      clib_memcpy (rmp->ip6_dst, &dst, sizeof (rmp->ip6_dst));
+      clib_memcpy (&rmp->ip6_dst, &dst, sizeof (rmp->ip6_dst));
       rmp->context = mp->context;
       vl_api_send_msg (reg, (u8 *) rmp);
     }
index 168e615..6bc035e 100644 (file)
@@ -67,9 +67,9 @@ ip_address_union_encode (const ip46_address_t * in,
                         vl_api_address_union_t * out)
 {
   if (ADDRESS_IP6 == clib_net_to_host_u32 (af))
-    memcpy (out->ip6, &in->ip6, sizeof (out->ip6));
+    memcpy (&out->ip6, &in->ip6, sizeof (out->ip6));
   else
-    memcpy (out->ip4, &in->ip4, sizeof (out->ip4));
+    memcpy (&out->ip4, &in->ip4, sizeof (out->ip4));
 }
 
 void
index cef7b60..9fc8e55 100644 (file)
@@ -149,9 +149,9 @@ vl_api_syslog_get_sender_t_handler (vl_api_syslog_get_sender_t * mp)
   /* *INDENT-OFF* */
   REPLY_MACRO2 (VL_API_SYSLOG_GET_SENDER_REPLY,
   ({
-    clib_memcpy (rmp->collector_address, &(sm->collector),
+    clib_memcpy (&rmp->collector_address, &(sm->collector),
                  sizeof(ip4_address_t));
-    clib_memcpy (rmp->src_address, &(sm->src_address),
+    clib_memcpy (&rmp->src_address, &(sm->src_address),
                  sizeof(ip4_address_t));
     rmp->collector_port = htons (sm->collector_port);
     if (sm->fib_index == ~0)