vppinfra: fix coverity warnings 81/29281/2
authorDave Barach <dave@barachs.net>
Wed, 7 Oct 2020 13:37:36 +0000 (09:37 -0400)
committerDamjan Marion <dmarion@me.com>
Thu, 8 Oct 2020 06:10:16 +0000 (06:10 +0000)
Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I654747d618cc4fe99b7774827303769fe43392ed

src/vppinfra/linux/mem.c
src/vppinfra/mem.h

index 22268ea..f31b456 100644 (file)
@@ -374,7 +374,7 @@ clib_mem_vm_map_hdr_t *
 clib_mem_vm_get_next_map_hdr (clib_mem_vm_map_hdr_t * hdr)
 {
   clib_mem_main_t *mm = &clib_mem_main;
-  uword sys_page_sz = 1 << mm->log2_page_sz;
+  uword sys_page_sz = 1ULL << mm->log2_page_sz;
   clib_mem_vm_map_hdr_t *next;
   if (hdr == 0)
     {
@@ -396,7 +396,7 @@ clib_mem_vm_map_internal (void *base, clib_mem_page_sz_t log2_page_sz,
 {
   clib_mem_main_t *mm = &clib_mem_main;
   clib_mem_vm_map_hdr_t *hdr;
-  uword sys_page_sz = 1 << mm->log2_page_sz;
+  uword sys_page_sz = 1ULL << mm->log2_page_sz;
   int mmap_flags = MAP_FIXED, is_huge = 0;
 
   if (fd != -1)
@@ -436,7 +436,7 @@ clib_mem_vm_map_internal (void *base, clib_mem_page_sz_t log2_page_sz,
   if (log2_page_sz == CLIB_MEM_PAGE_SZ_UNKNOWN)
     return CLIB_MEM_VM_MAP_FAILED;
 
-  size = round_pow2 (size, 1 << log2_page_sz);
+  size = round_pow2 (size, 1ULL << log2_page_sz);
 
   base = (void *) clib_mem_vm_reserve ((uword) base, size, log2_page_sz);
 
@@ -492,7 +492,7 @@ int
 clib_mem_vm_unmap (void *base)
 {
   clib_mem_main_t *mm = &clib_mem_main;
-  uword size, sys_page_sz = 1 << mm->log2_page_sz;
+  uword size, sys_page_sz = 1ULL << mm->log2_page_sz;
   clib_mem_vm_map_hdr_t *hdr = base - sys_page_sz;;
 
   if (mprotect (hdr, sys_page_sz, PROT_READ | PROT_WRITE) != 0)
index a94b66a..ca8161a 100644 (file)
@@ -543,7 +543,7 @@ clib_mem_log2_page_size_validate (clib_mem_page_sz_t log2_page_size)
 static_always_inline uword
 clib_mem_page_bytes (clib_mem_page_sz_t log2_page_size)
 {
-  return 1 << clib_mem_log2_page_size_validate (log2_page_size);
+  return 1ULL << clib_mem_log2_page_size_validate (log2_page_size);
 }
 
 static_always_inline clib_error_t *