VPP-1430: remove unnecessary padding 34/15134/3
authorMarco Varlese <marco.varlese@suse.com>
Thu, 4 Oct 2018 09:52:44 +0000 (11:52 +0200)
committerDamjan Marion <dmarion@me.com>
Thu, 4 Oct 2018 12:36:04 +0000 (12:36 +0000)
A copy/paste mistake caused to add padding to the buffer used to send
data.

Change-Id: I04d8dfec4ae195927be1675c5ce8b30230d5b376
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
src/vnet/sctp/sctp_output.c
test/test_sctp.py

index e69ff5c..08640a4 100644 (file)
@@ -1378,8 +1378,6 @@ sctp_push_hdr_i (sctp_connection_t * sctp_conn, vlib_buffer_t * b,
   u16 bytes_to_add = sizeof (sctp_payload_data_chunk_t);
   u16 chunk_length = data_len + bytes_to_add - sizeof (sctp_header_t);
 
-  bytes_to_add += vnet_sctp_calculate_padding (bytes_to_add + data_len);
-
   sctp_payload_data_chunk_t *data_chunk =
     vlib_buffer_push_uninit (b, bytes_to_add);
 
index f77b9dc..4d04aa0 100644 (file)
@@ -68,7 +68,7 @@ class TestSCTP(VppTestCase):
             self.logger.critical(error)
             self.assertEqual(error.find("failed"), -1)
 
-        error = self.vapi.cli("test echo client mbytes 1" +
+        error = self.vapi.cli("test echo client mbytes 10" +
                               " appns 1" +
                               " fifo-size 4" +
                               " no-output test-bytes syn-timeout 3" +