Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
ab4d917
)
fib: keep AddressSanitizer happy
50/38050/2
author
Benoît Ganne
<bganne@cisco.com>
Thu, 26 Jan 2023 16:16:54 +0000
(17:16 +0100)
committer
Neale Ranns
<neale@graphiant.com>
Thu, 2 Feb 2023 00:09:40 +0000
(
00:09
+0000)
adj_delegate_remove() makes 'ad' invalid, invalidate it only after its
use.
Type: fix
Change-Id: I6908d3dd2962ebd3fdf37e946cb19dae727bda09
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/adj/adj_midchain_delegate.c
patch
|
blob
|
history
diff --git
a/src/vnet/adj/adj_midchain_delegate.c
b/src/vnet/adj/adj_midchain_delegate.c
index
de57442
..
16129ff
100644
(file)
--- a/
src/vnet/adj/adj_midchain_delegate.c
+++ b/
src/vnet/adj/adj_midchain_delegate.c
@@
-148,12
+148,11
@@
adj_midchain_delegate_remove (adj_index_t ai)
{
adj_nbr_midchain_unstack(ai);
- adj_delegate_remove (ai, ADJ_DELEGATE_MIDCHAIN);
-
amd = pool_elt_at_index(amd_pool, ad->ad_index);
fib_entry_untrack(amd->amd_fei, amd->amd_sibling);
-
pool_put(amd_pool, amd);
+
+ adj_delegate_remove (ai, ADJ_DELEGATE_MIDCHAIN);
}
}