Switch atomic test and set API from __sync to __atomic builtin 29/19929/3
authorSirshak Das <sirshak.das@arm.com>
Tue, 28 May 2019 13:44:46 +0000 (08:44 -0500)
committerDamjan Marion <dmarion@me.com>
Wed, 5 Jun 2019 13:48:53 +0000 (13:48 +0000)
__sync_test_and_set uses full memory barriers for AArch64,
__atomic_exchange(ACQUIRE) would use load acquire.

Change-Id: Ifdf2481db3b9dde6c5842d75671402862adb6d81
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
src/vppinfra/atomics.h

index 5444b6d..1d480af 100644 (file)
@@ -37,7 +37,7 @@
 #define clib_atomic_cmp_and_swap(addr,old,new) __sync_val_compare_and_swap(addr, old, new)
 #define clib_atomic_bool_cmp_and_swap(addr,old,new) __sync_bool_compare_and_swap(addr, old, new)
 
-#define clib_atomic_test_and_set(a) __sync_lock_test_and_set(a, 1)
+#define clib_atomic_test_and_set(a) __atomic_exchange_n(a, 1, __ATOMIC_ACQUIRE)
 #define clib_atomic_release(a) __sync_lock_release(a)
 
 #define clib_atomic_fence_rel() __atomic_thread_fence(__ATOMIC_RELEASE);