feature: exit on misconfigured features (VPP-915) 75/8075/4
authorFlorin Coras <fcoras@cisco.com>
Thu, 17 Aug 2017 04:23:44 +0000 (21:23 -0700)
committerDave Barach <openvpp@barachs.net>
Fri, 18 Aug 2017 12:58:09 +0000 (12:58 +0000)
Change-Id: Ifa11f356d727b69cb121a2bf4cfb9d87883f545d
Signed-off-by: Florin Coras <fcoras@cisco.com>
src/vnet/feature/feature.c

index f0e9004..ad4047e 100644 (file)
@@ -65,8 +65,11 @@ vnet_feature_init (vlib_main_t * vm)
       vnet_feature_registration_t *next;
       uword *p = hash_get_mem (fm->arc_index_by_name, freg->arc_name);
       if (p == 0)
-       return clib_error_return (0, "Unknown feature arc '%s'",
-                                 freg->arc_name);
+       {
+         /* Don't start vpp with broken features arcs */
+         clib_warning ("Unknown feature arc '%s'", freg->arc_name);
+         os_exit (1);
+       }
 
       areg = uword_to_pointer (p[0], vnet_feature_arc_registration_t *);
       arc_index = areg->feature_arc_index;
@@ -95,7 +98,8 @@ vnet_feature_init (vlib_main_t * vm)
                                          fm->next_feature_by_arc[arc_index],
                                          &fm->feature_nodes[arc_index])))
        {
-         return error;
+         clib_error_report (error);
+         os_exit (1);
        }
 
       fm->next_feature_by_name[arc_index] =