srtp: cleanup build and default to disabled 89/32489/4
authorFlorin Coras <fcoras@cisco.com>
Fri, 28 May 2021 16:06:51 +0000 (09:06 -0700)
committerDave Barach <openvpp@barachs.net>
Tue, 1 Jun 2021 18:19:02 +0000 (18:19 +0000)
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I62fb56257445a05105e556d1ea6cc6280b5eeccc

src/plugins/srtp/CMakeLists.txt
src/plugins/srtp/srtp.c

index acbdf31..5771ad2 100644 (file)
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-include (CheckFunctionExists)
-
 vpp_plugin_find_library(srtp SRTP_LIB libsrtp2.a)
-
-if (NOT SRTP_LIB)
-  message(WARNING "srtp plugin - srtp2 lib not found - plugin disabled")
-  return()
-endif()
-
 vpp_find_path(SRTP_INCLUDE_DIR NAMES srtp2/srtp.h)
 
 if (NOT SRTP_INCLUDE_DIR)
@@ -29,9 +21,6 @@ endif()
 
 include_directories (${SRTP_INCLUDE_DIR})
 
-set(CMAKE_REQUIRED_FLAGS "-fPIC -shared -pthread -Wno-unused-command-line-argument ${SRTP_LIB}")
-set(CMAKE_REQUIRED_INCLUDES "${SRTP_INCLUDE_DIR}")
-
 add_vpp_plugin(srtp
   SOURCES
   srtp.c
index 98bf908..58a35c3 100644 (file)
@@ -982,7 +982,7 @@ VLIB_INIT_FUNCTION (srtp_transport_init);
 VLIB_PLUGIN_REGISTER () = {
   .version = VPP_BUILD_VER,
   .description = "Secure Real-time Transport Protocol (SRTP)",
-  /* .default_disabled = 1, */
+  .default_disabled = 1,
 };
 
 /*