VPP-1109 Fix loop for some CLI (code review)

Change-Id: I518387ab479bee4778d45a33c95f7b0f72aa1b72
Signed-off-by: Swarup Nayak <swarupnpvt@gmail.com>

diff --git a/src/plugins/ioam/ip6/ioam_cache.c b/src/plugins/ioam/ip6/ioam_cache.c
index 627f8b6..e2f878a 100644 (file)
--- a/src/plugins/ioam/ip6/ioam_cache.c
+++ b/src/plugins/ioam/ip6/ioam_cache.c
@@ -351,6 +351,9 @@ show_ioam_cache_command_fn (vlib_main_t * vm,
     {
       if (unformat (input, "verbose"))
        verbose = 1;
+      else
+       return clib_error_return (0, "unknown input `%U'",
+                                 format_unformat_error, input);
     }
   ioam_cache_table_print (vm, verbose);
 

diff --git a/src/plugins/nat/nat.c b/src/plugins/nat/nat.c
index df00f5e..e9b2c2c 100644 (file)
--- a/src/plugins/nat/nat.c
+++ b/src/plugins/nat/nat.c
@@ -3967,6 +3967,7 @@ snat_det_reverse_command_fn (vlib_main_t * vm,
         {
           error =  clib_error_return (0, "unknown input '%U'",
                                       format_unformat_error, line_input);
+          goto done;
         }
     }
 

diff --git a/src/vnet/udp/udp_encap.c b/src/vnet/udp/udp_encap.c
index 91d730c..87b2c09 100644 (file)
--- a/src/vnet/udp/udp_encap.c
+++ b/src/vnet/udp/udp_encap.c
@@ -581,6 +581,9 @@ udp_encap_show (vlib_main_t * vm,
     {
       if (unformat (input, "%d", &ue_id))
        ;
+      else
+       return clib_error_return (0, "unknown input `%U'",
+                                 format_unformat_error, input);
     }
 
   if (~0 == ue_id)