IP reassembly: workaround coverity warnings 95/10395/2
authorKlement Sekera <ksekera@cisco.com>
Fri, 2 Feb 2018 15:17:55 +0000 (16:17 +0100)
committerNeale Ranns <nranns@cisco.com>
Sat, 3 Feb 2018 09:36:29 +0000 (09:36 +0000)
Change-Id: Ide577f036d9d8dcedd99cdb4666a0eaf8a19b92e
Signed-off-by: Klement Sekera <ksekera@cisco.com>
src/vnet/ip/ip4_reassembly.c
src/vnet/ip/ip6_reassembly.c

index 6b8d665..7a10271 100644 (file)
@@ -412,6 +412,7 @@ ip4_reass_finalize (vlib_main_t * vm, vlib_node_runtime_t * node,
          trim_front = 0;
          trim_end = vlib_buffer_length_in_chain (vm, tmp) - data_len -
            ip4_header_bytes (ip);
+         ASSERT (vlib_buffer_length_in_chain (vm, tmp) - trim_end > 0);
        }
       u32 keep_data =
        vlib_buffer_length_in_chain (vm, tmp) - trim_front - trim_end;
index d448032..5a7c081 100644 (file)
@@ -451,6 +451,7 @@ ip6_reass_finalize (vlib_main_t * vm, vlib_node_runtime_t * node,
          trim_end = vlib_buffer_length_in_chain (vm, tmp) - data_len -
            (vnet_buffer (tmp)->ip.reass.ip6_frag_hdr_offset +
             sizeof (*frag_hdr));
+         ASSERT (vlib_buffer_length_in_chain (vm, tmp) - trim_end > 0);
        }
       u32 keep_data =
        vlib_buffer_length_in_chain (vm, tmp) - trim_front - trim_end;