classify: fix crash if no pcap filter has been configured 64/31464/3
authorBenoît Ganne <bganne@cisco.com>
Fri, 26 Feb 2021 13:46:58 +0000 (14:46 +0100)
committerDave Barach <openvpp@barachs.net>
Tue, 2 Mar 2021 12:59:55 +0000 (12:59 +0000)
If no pcap filters have ever been configured and we try to enable pcap
capture with a filter, cm->classify_table_index_by_sw_if_index is not
initialized yet.

Type: fix

Change-Id: I2f509c58f9984951b1ad81c1c8ed912cb594fce1
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/interface_cli.c

index a901e17..54e0673 100644 (file)
@@ -1971,7 +1971,8 @@ vnet_pcap_dispatch_trace_configure (vnet_pcap_dispatch_trace_args_t * a)
 
   /* Classify filter specified, but no classify filter configured */
   if ((a->rx_enable + a->tx_enable + a->drop_enable) && a->filter &&
-      cm->classify_table_index_by_sw_if_index[0] == ~0)
+      (!cm->classify_table_index_by_sw_if_index ||
+       cm->classify_table_index_by_sw_if_index[0] == ~0))
     return VNET_API_ERROR_NO_SUCH_LABEL;
 
   if (a->rx_enable + a->tx_enable + a->drop_enable)