Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
de6caf4
)
api: fix dead client scan heap issue
17/23317/2
author
Nathan Skrzypczak
<nathan.skrzypczak@gmail.com>
Thu, 7 Nov 2019 15:00:57 +0000
(16:00 +0100)
committer
Florin Coras
<florin.coras@gmail.com>
Thu, 7 Nov 2019 18:29:31 +0000
(18:29 +0000)
Type: fix
On multiworker setup when an app client dies, the
vec_reset_length call fails the assert in
clib_mem_is_heap_object. Same thing might happen for
the clib_warnings
Change-Id: I369f9d2dbe60407c84994a4e8d25f6df7848ca93
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
src/vlibmemory/memory_api.c
patch
|
blob
|
history
diff --git
a/src/vlibmemory/memory_api.c
b/src/vlibmemory/memory_api.c
index
34fd956
..
c9eebab
100644
(file)
--- a/
src/vlibmemory/memory_api.c
+++ b/
src/vlibmemory/memory_api.c
@@
-666,14
+666,18
@@
vl_mem_api_dead_client_scan (api_main_t * am, vl_shmem_hdr_t * shm, f64 now)
vec_delete (am->vlib_private_rps, 1, i);
goto found;
}
+ svm_pop_heap (oldheap);
clib_warning ("private rp %llx AWOL", dead_rp);
+ oldheap = svm_push_data_heap (svm);
found:
/* Kill it, accounting for the memfd header page */
+ svm_pop_heap (oldheap);
if (munmap ((void *) virtual_base, virtual_size) < 0)
clib_unix_warning ("munmap");
/* Reset the queue-length-address cache */
vec_reset_length (vl_api_queue_cursizes);
+ oldheap = svm_push_data_heap (svm);
}
else
{