fib: fix use-after-free for interface adj removal 71/22771/2
authorBenoît Ganne <bganne@cisco.com>
Wed, 16 Oct 2019 13:08:37 +0000 (15:08 +0200)
committerNeale Ranns <nranns@cisco.com>
Wed, 16 Oct 2019 15:19:46 +0000 (15:19 +0000)
Type: fix

Change-Id: I82308e368d14d84f5970dad229bdcf2de7d1839d
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/adj/adj_nbr.c

index cbd6691..7f053c8 100644 (file)
@@ -823,12 +823,15 @@ adj_nbr_interface_delete_one (adj_index_t ai,
     };
     ip_adjacency_t *adj;
 
+    adj_lock(ai);
+
     adj = adj_get(ai);
 
     adj->ia_flags |= ADJ_FLAG_SYNC_WALK_ACTIVE;
     fib_walk_sync(FIB_NODE_TYPE_ADJ, ai, &bw_ctx);
     adj->ia_flags &= ~ADJ_FLAG_SYNC_WALK_ACTIVE;
 
+    adj_unlock(ai);
     return (ADJ_WALK_RC_CONTINUE);
 }