Remove unused jvpp dependency on plugins' control_ping 83/3683/2
authorMarek Gradzki <mgradzki@cisco.com>
Thu, 3 Nov 2016 12:33:07 +0000 (13:33 +0100)
committerDamjan Marion <dmarion.lists@gmail.com>
Thu, 3 Nov 2016 16:42:03 +0000 (16:42 +0000)
Change-Id: I6ebb69443e79e60c7ce6afded6a2d3af85048e6e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
plugins/ioam-plugin/Makefile.am
plugins/snat-plugin/Makefile.am
vpp-api/java/jvpp/gen/jvpp_gen.py
vpp-api/java/jvpp/gen/jvppgen/jvpp_impl_gen.py

index 3f1edb1..cd70f32 100644 (file)
@@ -164,7 +164,7 @@ $(jvpp_root)/io_fd_vpp_jvpp_ioamtrace_JVppIoamtraceImpl.h: defs_ioam_trace_papi.
        mkdir -p $(jvpp_root)/$(jvpp_package_dir);              \
        cd $(jvpp_root)/$(jvpp_package_dir);                    \
        mkdir -p dto future callfacade callback notification test;      \
-       @srcdir@/$(jvpp_registry_root)/jvpp/gen/jvpp_gen.py -i $${dir}/defs_ioam_trace_papi.py --plugin_name ioamtrace --control_ping_class IoamTraceControlPing;               \
+       @srcdir@/$(jvpp_registry_root)/jvpp/gen/jvpp_gen.py -i $${dir}/defs_ioam_trace_papi.py --plugin_name ioamtrace;         \
        cd -;                                                   \
        mv -f $(jvpp_root)/$(jvpp_package_dir)/jvpp_ioamtrace_gen.h $(jvpp_root)/jvpp_ioam_trace_gen.h;                                                 \
        cp $(srcdir)/$(jvpp_root)/$(jvpp_package_dir)/test/*.java $(jvpp_root)/$(jvpp_package_dir)/test/;                               \
index 081340b..9f41193 100644 (file)
@@ -88,7 +88,7 @@ $(jvpp_root)/io_fd_vpp_jvpp_snat_JVppSnatImpl.h: defs_snat_papi.py
        mkdir -p $(jvpp_root)/$(jvpp_package_dir);              \
        cd $(jvpp_root)/$(jvpp_package_dir);                    \
        mkdir -p dto future callfacade callback notification test;      \
-       @srcdir@/$(jvpp_registry_root)/jvpp/gen/jvpp_gen.py -i $${dir}/defs_snat_papi.py --plugin_name snat --control_ping_class SnatControlPing;               \
+       @srcdir@/$(jvpp_registry_root)/jvpp/gen/jvpp_gen.py -i $${dir}/defs_snat_papi.py --plugin_name snat;            \
        cd -;                                                   \
        mv -f $(jvpp_root)/$(jvpp_package_dir)/jvpp_snat_gen.h $(jvpp_root)/jvpp_snat_gen.h;                                                    \
        cp $(srcdir)/$(jvpp_root)/$(jvpp_package_dir)/test/*.java $(jvpp_root)/$(jvpp_package_dir)/test/;                               \
index 3be8382..1b9ceff 100755 (executable)
@@ -42,7 +42,6 @@ from jvppgen import util
 parser = argparse.ArgumentParser(description='VPP Java API generator')
 parser.add_argument('-i', action="store", dest="inputfile")
 parser.add_argument('--plugin_name', action="store", dest="plugin_name")
-parser.add_argument('--control_ping_class', action="store", dest="control_ping_class", default="ControlPing")
 args = parser.parse_args()
 
 sys.path.append(".")
@@ -55,8 +54,6 @@ inputfile = inputfile.replace('.py', '')
 print "inputfile %s" % inputfile
 plugin_name = args.plugin_name
 print "plugin_name %s" % plugin_name
-control_ping_class = args.control_ping_class
-print "control_ping_class %s" % control_ping_class
 sys.path.append(importdir)
 cfg = importlib.import_module(inputfile, package=None)
 
@@ -131,7 +128,6 @@ notification_package = 'notification'
 future_package = 'future'
 # TODO find better package name
 callback_facade_package = 'callfacade'
-control_ping_class_fqn = "%s.%s.%s" % (plugin_package, dto_package, control_ping_class)
 
 types_list, types_name = get_definitions(cfg.types)
 
@@ -139,7 +135,7 @@ types_gen.generate_types(types_list, plugin_package, types_package, inputfile)
 
 func_list, func_name = get_definitions(cfg.messages)
 dto_gen.generate_dtos(func_list, base_package, plugin_package, plugin_name.title(), dto_package, args.inputfile)
-jvpp_impl_gen.generate_jvpp(func_list, base_package, plugin_package, plugin_name, control_ping_class_fqn, dto_package, args.inputfile)
+jvpp_impl_gen.generate_jvpp(func_list, base_package, plugin_package, plugin_name, dto_package, args.inputfile)
 callback_gen.generate_callbacks(func_list, base_package, plugin_package, plugin_name.title(), callback_package, dto_package, args.inputfile)
 notification_gen.generate_notification_registry(func_list, base_package, plugin_package, plugin_name.title(), notification_package, callback_package, dto_package, args.inputfile)
 jvpp_c_gen.generate_jvpp(func_list, plugin_name, args.inputfile)
index 16c84ce..4146c14 100644 (file)
@@ -160,7 +160,7 @@ no_arg_method_impl_template = Template("""    public final int $name() throws io
 """)
 
 
-def generate_jvpp(func_list, base_package, plugin_package, plugin_name_underscore, control_ping_class, dto_package, inputfile):
+def generate_jvpp(func_list, base_package, plugin_package, plugin_name_underscore, dto_package, inputfile):
     """ Generates JVpp interface and JNI implementation """
     print "Generating JVpp"
     plugin_name = util.underscore_to_camelcase_upper(plugin_name_underscore)
@@ -214,7 +214,6 @@ def generate_jvpp(func_list, base_package, plugin_package, plugin_name_underscor
                                                   plugin_package=plugin_package,
                                                   plugin_name=plugin_name,
                                                   plugin_name_underscore=plugin_name_underscore,
-                                                  dto_package=dto_package,
-                                                  control_ping_class=control_ping_class))
+                                                  dto_package=dto_package))
     jvpp_file.flush()
     jvpp_file.close()