Fix coverity CIDs 161048, 163895 02/5702/2
authorPavel Kotucek <pkotucek@cisco.com>
Fri, 10 Mar 2017 09:03:59 +0000 (10:03 +0100)
committerOle Trøan <otroan@employees.org>
Fri, 10 Mar 2017 11:32:24 +0000 (11:32 +0000)
Change-Id: Ic206601413bb366e2a920daf00524e92a47287ef
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
src/vnet/ipsec/ipsec_api.c
src/vnet/span/node.c

index e37bcce..9c4ba52 100644 (file)
@@ -209,8 +209,7 @@ static void vl_api_ipsec_sad_add_del_entry_t_handler
   sa.crypto_key_len = mp->crypto_key_length;
   clib_memcpy (&sa.crypto_key, mp->crypto_key, sizeof (sa.crypto_key));
   /* check for unsupported integ-alg */
-  if (mp->integrity_algorithm < IPSEC_INTEG_ALG_NONE ||
-      mp->integrity_algorithm >= IPSEC_INTEG_N_ALG)
+  if (mp->integrity_algorithm >= IPSEC_INTEG_N_ALG)
     {
       clib_warning ("unsupported integ-alg: '%U'", format_ipsec_integ_alg,
                    mp->integrity_algorithm);
index eb69c39..2a43b6e 100644 (file)
@@ -69,8 +69,6 @@ span_mirror (vlib_main_t * vm, vlib_node_runtime_t * node, u32 sw_if_index0,
   u32 i;
 
   si0 = vec_elt_at_index (sm->interfaces, sw_if_index0);
-  if (!si0)
-    return;
 
   if (is_rx != 0 && si0->num_rx_mirror_ports == 0)
     return;