Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
770178e
)
devices: allow link state down with netlink
98/26698/2
author
Matthew Smith
<mgsmith@netgate.com>
Fri, 24 Apr 2020 18:43:12 +0000
(13:43 -0500)
committer
Damjan Marion
<dmarion@me.com>
Mon, 27 Apr 2020 10:54:13 +0000
(10:54 +0000)
Type: fix
Use the up parameter in vnet_netlink_set_link_state(). It was
ignoring the parameter and always setting IFF_UP on an interface.
Change-Id: I0d44406d982afbdc43bc6b26d0f22c0bdd47abdc
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
src/vnet/devices/netlink.c
patch
|
blob
|
history
diff --git
a/src/vnet/devices/netlink.c
b/src/vnet/devices/netlink.c
index
7260351
..
34309e1
100644
(file)
--- a/
src/vnet/devices/netlink.c
+++ b/
src/vnet/devices/netlink.c
@@
-201,7
+201,7
@@
vnet_netlink_set_link_state (int ifindex, int up)
struct ifinfomsg ifmsg = { 0 };
clib_error_t *err = 0;
- ifmsg.ifi_flags =
IFF_UP
;
+ ifmsg.ifi_flags =
((up) ? IFF_UP : 0)
;
ifmsg.ifi_change = IFF_UP;
ifmsg.ifi_index = ifindex;