ip: fix coverity warning 39/34239/3
authorKlement Sekera <ksekera@cisco.com>
Mon, 25 Oct 2021 11:39:13 +0000 (13:39 +0200)
committerDamjan Marion <dmarion@me.com>
Tue, 2 Nov 2021 22:34:28 +0000 (22:34 +0000)
Remove unnecessary NULL check of t0, which causes coverity to scream. t0
is always initilised to *something* by doing pool_elt_at_index().

Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I7cf21767c43a24923e490ad40622743c17142fe2

src/vnet/ip/ip_in_out_acl.c

index e858c8e..2ed571a 100644 (file)
@@ -663,7 +663,7 @@ ip_in_out_acl_inline_trace (vlib_main_t *vm, vlib_node_runtime_t *node,
          t->sw_if_index =
            ~0 == way ? 0 : vnet_buffer (b[0])->sw_if_index[way];
          t->next_index = next0;
-         t->table_index = t0 ? t0 - tables : ~0;
+         t->table_index = t0 - tables;
          t->offset = (e0 && t0) ? vnet_classify_get_offset (t0, e0) : ~0;
        }