Python API: Incorrect error for empty VLA list. 46/4446/2
authorOle Troan <ot@cisco.com>
Wed, 21 Dec 2016 10:51:05 +0000 (11:51 +0100)
committerDamjan Marion <dmarion.lists@gmail.com>
Wed, 21 Dec 2016 17:05:05 +0000 (17:05 +0000)
Change-Id: Ie3e9a54ca23af6b9ee43615f59a48cb05e3906d4
Signed-off-by: Ole Troan <ot@cisco.com>
vpp-api/python/tests/test_vpp_papi2.py
vpp-api/python/vpp_papi/vpp_papi.py

index 18f6b68..f45f791 100755 (executable)
@@ -434,7 +434,7 @@ class TestACL(unittest.TestCase):
 
         rv = vpp.acl_plugin_get_version()
         print('RV', rv)
-        self.assertEqual(rv.major, 0)
+        self.assertEqual(rv.major, 1)
         self.assertEqual(rv.minor, 1)
 
         rv = vpp.acl_add_replace(acl_index = 0xFFFFFFFF,
@@ -472,6 +472,16 @@ class TestACL(unittest.TestCase):
         vpp = VPP(jsonfiles)
         vpp.status()
 
+    def test_acl_interface_get(self):
+        vpp = VPP(jsonfiles)
+
+        vpp.connect('test_vpp_papi2')
+
+        rv = vpp.macip_acl_interface_get()
+
+        print('RV', rv)
+
+        vpp.disconnect()
 
 if __name__ == '__main__':
     unittest.main()
index 02fe245..6b6b79f 100644 (file)
@@ -206,9 +206,6 @@ class VPP():
                     e = v[0] if type(v[0]) is int else res[v[2]]
                     if e == -1:
                         e = (len(buf) - off) / v[1].size
-                    if e == 0:
-                        raise ValueError(1,
-                                         'Variable length array, empty length: ' + k)
                     lst = []
                     res.append(lst)
                     size = 0