Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
803c162
)
api: fromjson/tojson generated code memory leak
41/30641/2
author
Ole Troan
<ot@cisco.com>
Wed, 6 Jan 2021 12:58:00 +0000
(13:58 +0100)
committer
Dave Barach
<openvpp@barachs.net>
Wed, 6 Jan 2021 17:05:40 +0000
(17:05 +0000)
Found by coverity. Fix potential memory leakage in generated code.
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If492541b8b66e574f30ecdd0dd533099cbe068ad
src/tools/vppapigen/vppapigen_c.py
patch
|
blob
|
history
diff --git
a/src/tools/vppapigen/vppapigen_c.py
b/src/tools/vppapigen/vppapigen_c.py
index
66e0c2f
..
0727619
100644
(file)
--- a/
src/tools/vppapigen/vppapigen_c.py
+++ b/
src/tools/vppapigen/vppapigen_c.py
@@
-553,7
+553,7
@@
class FromJSON():
write(' item = cJSON_GetObjectItem(o, "{}");\n'
.format(t.fieldname))
- write(' if (!item)
return 0;
\n')
+ write(' if (!item)
{ free(a); return 0; }
\n')
self._dispatch[t.type](self, t, toplevel=True)
write('\n')