svm: fix coverity warnings 30/25430/3
authorFlorin Coras <fcoras@cisco.com>
Tue, 25 Feb 2020 22:28:27 +0000 (22:28 +0000)
committerDave Barach <openvpp@barachs.net>
Wed, 26 Feb 2020 15:28:45 +0000 (15:28 +0000)
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2d5cb7cccb67a3193ce5a25323e70bc05737e023

src/svm/fifo_segment.c
src/vnet/session/segment_manager.c

index ec6f082..e19113f 100644 (file)
@@ -75,7 +75,6 @@ static inline uword
 fsh_n_cached_bytes (fifo_segment_header_t * fsh)
 {
   uword n_cached = clib_atomic_load_relax_n (&fsh->n_cached_bytes);
-  ASSERT (n_cached >= 0);
   return n_cached;
 }
 
index db38097..cbd4443 100644 (file)
@@ -981,8 +981,7 @@ void
 segment_manager_set_watermarks (segment_manager_t * sm,
                                u8 high_watermark, u8 low_watermark)
 {
-  ASSERT (high_watermark >= 0 && high_watermark <= 100 &&
-         low_watermark >= 0 && low_watermark <= 100 &&
+  ASSERT (high_watermark <= 100 && low_watermark <= 100 &&
          low_watermark <= high_watermark);
 
   sm->high_watermark = high_watermark;